Reset Non-migratable streams and migrate the rest streams during connection migration |
||
Issue descriptionCurrently connection migration will not take effect if there is any non-migratable stream in the connection. We might want to consider reset the non-migratable streams and migrate the rest streams during connection migration so that the rest of the stream still have a chance to succeed. Resetting the non-migratable stream should be fine in most cases(platform notification, write error) as without this change, the stream will also fail if we don't do connection migration. The only tricky case is that a non-migratable stream might have a little chance to succeed on path degrading, while resetting during connection migration(previously called early migration) will definitely make the request fail. This behavior change should be controlled by a separate finch knob so that we could easily turn on/off the feature.
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0439ecc7046e75a406443037e6012ec6bfbae4b6 commit 0439ecc7046e75a406443037e6012ec6bfbae4b6 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Wed Jul 11 04:41:26 2018 Close non-migratable streams but migrate the rest of the steams when QUIC connection migration migrates to an alternate network. Bug: 791886 Change-Id: Idf803b0e7453ffc1ef44de3209e7cda74e58f64d Reviewed-on: https://chromium-review.googlesource.com/1125525 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#574075} [modify] https://crrev.com/0439ecc7046e75a406443037e6012ec6bfbae4b6/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/0439ecc7046e75a406443037e6012ec6bfbae4b6/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/0439ecc7046e75a406443037e6012ec6bfbae4b6/net/quic/chromium/quic_stream_factory_test.cc
,
Jul 11
,
Jul 13
Fix in #2 landed in 69.0.3489.0.
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21e99532a6af2ec22ed42ef0990dcbe494125fef commit 21e99532a6af2ec22ed42ef0990dcbe494125fef Author: Zhongyi Shi <zhongyi@chromium.org> Date: Tue Jul 17 22:23:07 2018 QUIC Connection Migration: do not check non-migratable streams when starting to probe an alternative network. Instead, check and reset non-migratable streams when probe is successful and session is about to migrate to the probed path. Bug: 791886 Change-Id: Icdff9b77d340fedbf64ab8e8eb05d1d99aaf0b65 Reviewed-on: https://chromium-review.googlesource.com/1139314 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#575806} [modify] https://crrev.com/21e99532a6af2ec22ed42ef0990dcbe494125fef/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/21e99532a6af2ec22ed42ef0990dcbe494125fef/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/21e99532a6af2ec22ed42ef0990dcbe494125fef/net/quic/chromium/quic_stream_factory_test.cc |
||
►
Sign in to add a comment |
||
Comment 1 by zhongyi@chromium.org
, Jun 30 2018