New issue
Advanced search Search tips

Issue 791881 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove bool type |mirror| from DisplayLayout

Project Member Reported by weidongg@chromium.org, Dec 5 2017

Issue description

Now after  crbug.com/785416  changes the rule for mirror mode persistency. Restoring mirror mode no longer depends on display layout. So We should remove the unused |mirror| in DisplayLayout.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15abd3172ad6594844e09abe9dc494d4718e0f71

commit 15abd3172ad6594844e09abe9dc494d4718e0f71
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Dec 22 19:05:26 2017

Remove |mirrored| in DisplayLayout

Changes:
Remove |mirrored| in DisplayLayout and related code because mirror mode
restoring no longer depends on DisplayLayout any more.

Bug:  791881 
Change-Id: I99c5d7d443e0ab511c0c6003190c4e09843f97d9
Reviewed-on: https://chromium-review.googlesource.com/835626
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526036}
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/chrome/browser/chromeos/display/display_preferences_unittest.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/display_layout.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/display_layout.h
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/display_layout_builder.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/manager/display_layout_store.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/manager/display_layout_store.h
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/manager/display_manager.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/manager/json_converter.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/manager/json_converter_unittest.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/mojo/display_layout.mojom
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/mojo/display_layout_struct_traits.cc
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/mojo/display_layout_struct_traits.h
[modify] https://crrev.com/15abd3172ad6594844e09abe9dc494d4718e0f71/ui/display/mojo/display_struct_traits_unittest.cc

Status: Fixed (was: Assigned)
Status: Archived (was: Fixed)

Sign in to add a comment