New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791874 link

Starred by 1 user
Status: Archived
Owner:
█ youcheng@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

factory: Revise report filename format on factory server

Project Member Reported by youcheng@chromium.org, Dec 5 2017 
Currently the report filename format is "{stage}{opt_name}-{serial}-{gmtime}.rpt.xz".
And there are two programs that upload reports: gooftool and pytest sync_factory_server.
For the reports uploaded by gooftool, the filename on factory server would be like "FA-20171121T010101Z_SN123.tar.xz-SN123-20171121T020202Z.rpt.xz".
For the reports uploaded by sync_factory_server, the filename would be like "FA-SMT-SN123-20171205T051541Z.rpt.xz".

Both of the above filenames looks weird.

We should revise the filename format and make it less confusing.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef

commit f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Wed Dec 06 11:45:54 2017

Report: Revise report filename format on factory server.

Current report filename format is very confusing:
1. sync_factory_server uploads report with filename like
   "FA-SMT-SN123-20171205T051541Z.rpt.xz". Both "FA" and "SMT" occur at
   the same time.
2. gooftool uploads report with filename like
   "FA-20171121T010101Z_SN123.tar.xz-SN123-20171121T020202Z.rpt.xz".

This change changes the report filename format of sync_factory_server to
"SMT-SN123-20171205T051541Z.rpt.xz" and changes the report filename
format of gooftool to "GRT-gooftool-SN123-20171205T051541Z.rpt.xz".

BUG= chromium:791874 
TEST=manually

Change-Id: I65ab200e38c5998c75cc41cc9a824270ad1c4ffd
Reviewed-on: https://chromium-review.googlesource.com/807341
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef/py/gooftool/gooftool_unittest.py
[modify] https://crrev.com/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef/py/umpire/server/rpc_dut.py
[modify] https://crrev.com/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef/py/gooftool/report_upload.py
[modify] https://crrev.com/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef/py/umpire/server/e2e_test/e2e_test.py
[modify] https://crrev.com/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef/py/gooftool/commands.py
[modify] https://crrev.com/f0f4be1ba930ad4e03f1889ebb9d8e13fca9feef/py/test/pytests/sync_factory_server.py

Comment 2 by youcheng@chromium.org, Dec 7 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@google.com, Jul 30

Status: Archived (was: Fixed)
►

Sign in to add a comment