New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791838 link

Starred by 23 users
Status: Fixed
Owner:
caseq@chromium.org
Closed: Apr 2018
Cc:
█ krajshree@chromium.org
davidben@chromium.org
yhirano@chromium.org
█ sindhu.chelamcherla@chromium.org
jam@chromium.org
clamy@chromium.org
caseq@chromium.org
pfeldman@chromium.org
dgozman@chromium.org
alex...@chromium.org
arthurso...@chromium.org
dtrainor@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: report main resource network events from browser

Project Member Reported by caseq@chromium.org, Dec 5 2017 
Currently, we report all resource loading events for the main resource (Network.{requestWillBeSent,responseReceived,dataReceived,loadingFinixhed}) from the renderer. In case of browser-side navigation, requestWillBeSent would thus be sent only after the navigation is committed. This complicates the
client-side logic (see https://docs.google.com/document/d/1D_1EktSKNzxLD2MK36LQZdqI0n45G-KxPebUmn-wdMo for detailed discussion).

We should instead report main resource loading events from the browser, as they happen.

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37608a0ee146d87f2a1d897e28fc3044e9aa25f0

commit 37608a0ee146d87f2a1d897e28fc3044e9aa25f0
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Feb 07 02:09:09 2018

DevTools: emit requestWillBeSent & responseReceived for nav requests from browser

This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
events are still reported from the renderer.

TBR=alexclarke

Bug:  791838 
Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647
Reviewed-on: https://chromium-review.googlesource.com/861952
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534878}
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/common/navigation_params.mojom
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/renderer/render_frame_impl.h
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/content/test/test_render_frame_host.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/37608a0ee146d87f2a1d897e28fc3044e9aa25f0/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1

commit 0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Feb 07 09:31:33 2018

Revert "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"

This reverts commit 37608a0ee146d87f2a1d897e28fc3044e9aa25f0.

Reason for revert: Speculative revert since this might be causing DevTools timeouts on the Linux Tests (dbg) bot.
See https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/70144

Will reland if the revert does not fix the bot.

Original change's description:
> DevTools: emit requestWillBeSent & responseReceived for nav requests from browser
> 
> This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
> to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
> events are still reported from the renderer.
> 
> TBR=alexclarke
> 
> Bug:  791838 
> Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647
> Reviewed-on: https://chromium-review.googlesource.com/861952
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534878}

TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org

Change-Id: Id7ea47d167f2127bac9717fc58cc4d8ba576691d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  791838 
Reviewed-on: https://chromium-review.googlesource.com/905644
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534962}
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/common/navigation_params.mojom
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/renderer/render_frame_impl.h
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/content/test/test_render_frame_host.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/0fc61e04e77774f06ddc82d7bd3885bbd7f2cdb1/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e18366aa62b0adf17ccc9f2a88642915dfd711

commit 84e18366aa62b0adf17ccc9f2a88642915dfd711
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Feb 07 16:18:15 2018

Reland "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"

This is a reland of 37608a0ee146d87f2a1d897e28fc3044e9aa25f0.

Original change's description:
> DevTools: emit requestWillBeSent & responseReceived for nav requests from browser
>
> This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
> to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
> events are still reported from the renderer.
>
> TBR=alexclarke
>
> Bug:  791838 
> Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647
> Reviewed-on: https://chromium-review.googlesource.com/861952
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534878}

TBR=alexclarke

Bug:  791838 
Change-Id: Ib034f8687bfdb9a84c7e3ce2debd25c61fb0e0cf
Reviewed-on: https://chromium-review.googlesource.com/906628
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535020}
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/common/navigation_params.mojom
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/renderer/render_frame_impl.h
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/content/test/test_render_frame_host.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/84e18366aa62b0adf17ccc9f2a88642915dfd711/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff

commit e41fd2de99e467fcc9c9b57cdb96f2b6430233ff
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Wed Feb 07 20:28:14 2018

Revert "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"

This reverts commit 37608a0ee146d87f2a1d897e28fc3044e9aa25f0.

Reason for revert: Suspected cause of the timeout failures on Linux Tests (dbg)(1).  Will reland if the timeouts are not fixed.
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/70144

Original change's description:
> DevTools: emit requestWillBeSent & responseReceived for nav requests from browser
> 
> This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
> to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
> events are still reported from the renderer.
> 
> TBR=alexclarke
> 
> Bug:  791838 
> Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647
> Reviewed-on: https://chromium-review.googlesource.com/861952
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534878}

TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org

Change-Id: I1a9d199033f5b74b351b788ab6e5eee14869c760
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  791838 
Reviewed-on: https://chromium-review.googlesource.com/907339
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535129}
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/common/navigation_params.mojom
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/content/test/test_render_frame_host.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/e41fd2de99e467fcc9c9b57cdb96f2b6430233ff/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a

commit 618456e7d8be03dc76e6a7b74b8fd1a5eff3508a
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Wed Feb 07 22:44:57 2018

Reland "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"

This reverts commit e41fd2de99e467fcc9c9b57cdb96f2b6430233ff.

Reason for revert: Tests are still failing with the revert

Original change's description:
> Revert "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"
> 
> This reverts commit 37608a0ee146d87f2a1d897e28fc3044e9aa25f0.
> 
> Reason for revert: Suspected cause of the timeout failures on Linux Tests (dbg)(1).  Will reland if the timeouts are not fixed.
> https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/70144
> 
> Original change's description:
> > DevTools: emit requestWillBeSent & responseReceived for nav requests from browser
> > 
> > This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
> > to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
> > events are still reported from the renderer.
> > 
> > TBR=alexclarke
> > 
> > Bug:  791838 
> > Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647
> > Reviewed-on: https://chromium-review.googlesource.com/861952
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#534878}
> 
> TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org
> 
> Change-Id: I1a9d199033f5b74b351b788ab6e5eee14869c760
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  791838 
> Reviewed-on: https://chromium-review.googlesource.com/907339
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535129}

TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org,thomasanderson@chromium.org

Change-Id: I3688bc4230c71eb1c0ddff896ccdf34255c788bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  791838 
Reviewed-on: https://chromium-review.googlesource.com/906846
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535169}
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/common/navigation_params.mojom
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/renderer/render_frame_impl.h
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/content/test/test_render_frame_host.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/618456e7d8be03dc76e6a7b74b8fd1a5eff3508a/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c1392370b396d7642208c6bcbc0c76fd918cd9

commit 30c1392370b396d7642208c6bcbc0c76fd918cd9
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Feb 08 01:46:52 2018

Revert "Reland "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser""

This reverts commit 618456e7d8be03dc76e6a7b74b8fd1a5eff3508a.

Reason for revert: http://crbug.com/809996

Original change's description:
> Reland "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"
> 
> This reverts commit e41fd2de99e467fcc9c9b57cdb96f2b6430233ff.
> 
> Reason for revert: Tests are still failing with the revert
> 
> Original change's description:
> > Revert "DevTools: emit requestWillBeSent & responseReceived for nav requests from browser"
> > 
> > This reverts commit 37608a0ee146d87f2a1d897e28fc3044e9aa25f0.
> > 
> > Reason for revert: Suspected cause of the timeout failures on Linux Tests (dbg)(1).  Will reland if the timeouts are not fixed.
> > https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/70144
> > 
> > Original change's description:
> > > DevTools: emit requestWillBeSent & responseReceived for nav requests from browser
> > > 
> > > This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
> > > to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
> > > events are still reported from the renderer.
> > > 
> > > TBR=alexclarke
> > > 
> > > Bug:  791838 
> > > Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647
> > > Reviewed-on: https://chromium-review.googlesource.com/861952
> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#534878}
> > 
> > TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org
> > 
> > Change-Id: I1a9d199033f5b74b351b788ab6e5eee14869c760
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  791838 
> > Reviewed-on: https://chromium-review.googlesource.com/907339
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#535129}
> 
> TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org,thomasanderson@chromium.org
> 
> Change-Id: I3688bc4230c71eb1c0ddff896ccdf34255c788bf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  791838 
> Reviewed-on: https://chromium-review.googlesource.com/906846
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535169}

TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,pfeldman@chromium.org,alexclarke@chromium.org,thomasanderson@chromium.org

Change-Id: I08699e62d2a7bde13b73ef33a2bfcf83f7953159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  791838 
Reviewed-on: https://chromium-review.googlesource.com/908008
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535245}
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/common/navigation_params.mojom
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/renderer/render_frame_impl.h
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/content/test/test_render_frame_host.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/30c1392370b396d7642208c6bcbc0c76fd918cd9/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30f8822a37972aabd4b76d4559d1062d6799c9cb

commit 30f8822a37972aabd4b76d4559d1062d6799c9cb
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Feb 13 17:32:39 2018

Reland: DevTools: emit requestWillBeSent & responseReceived for nav requests from browser

This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed}
to browser and prevents renderer from reporting these. The dataReceived and loadingFinished
events are still reported from the renderer.

The original CL: https://chromium-review.googlesource.com/c/chromium/src/+/861952

This adds the code to trim initiator's asyn stack chain to address issue 809996, plus
a couple of fields in ResponseReceived event that were missing compared to the rendeder instrumentation.

TBR=alexclarke,dcheng,dgozman

Bug:  791838 ,809996
Change-Id: I73bf0c1dcde8a961860d1f986f3a9f0a64cd8723
Reviewed-on: https://chromium-review.googlesource.com/912400
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536402}
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/common/navigation_params.mojom
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/renderer/render_frame_impl.h
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/content/test/test_render_frame_host.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping.js
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6.js
[add] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-long-async-stack-expected.txt
[add] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-long-async-stack.js
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger-expected.txt
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/wait-for-debugger.js
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/30f8822a37972aabd4b76d4559d1062d6799c9cb/third_party/WebKit/public/web/WebFrameClient.h
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cc05b1059c06dee98b1775383e4d7b8d0b09256

commit 2cc05b1059c06dee98b1775383e4d7b8d0b09256
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Feb 14 01:59:34 2018

DevTools: fix status returned by ResponseReceived when navigating to data: urls

Normally, only requests fulfilled by HTTP have status code & text. However,
we fake these just for data: URLs in the renderer:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/network/NetworkUtils.cpp?rcl=04dc3fe0ebce31ddfe0249be05e7658177235605&l=91
so let's be consistent when reporting these from the browser.

Bug:  791838 
Change-Id: I05af36e5313264e43af15c9d0402ee17ddbcd18c
Reviewed-on: https://chromium-review.googlesource.com/917212
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536602}
[modify] https://crrev.com/2cc05b1059c06dee98b1775383e4d7b8d0b09256/content/browser/devtools/protocol/network_handler.cc
[add] https://crrev.com/2cc05b1059c06dee98b1775383e4d7b8d0b09256/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/data-url-status-expected.txt
[add] https://crrev.com/2cc05b1059c06dee98b1775383e4d7b8d0b09256/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/data-url-status.js
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86a31915e7840f51cd52ac33486dc05b835ffb2f

commit 86a31915e7840f51cd52ac33486dc05b835ffb2f
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Feb 14 02:19:00 2018

DevTools: ensure FrameAttached is emitted before RequestWillBeSent

Flush event queue when emitting FrameAttached to ensure it gets to
the client before RequestWillBeSent related to the frame navigation,
which is now emitted by the browser.

Bug:  791838 
Change-Id: I9b1e85af7121f6b27acc9779c88b8be936f0e108
Reviewed-on: https://chromium-review.googlesource.com/917425
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536615}
[modify] https://crrev.com/86a31915e7840f51cd52ac33486dc05b835ffb2f/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[modify] https://crrev.com/86a31915e7840f51cd52ac33486dc05b835ffb2f/third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedDetached-expected.txt
[modify] https://crrev.com/86a31915e7840f51cd52ac33486dc05b835ffb2f/third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedDetached.js
[modify] https://crrev.com/86a31915e7840f51cd52ac33486dc05b835ffb2f/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Comment 11 by caseq@chromium.org, Mar 1 2018

Cc: caseq@chromium.org sindhu.chelamcherla@chromium.org
 Issue 817453  has been merged into this issue.

Comment 12 by caseq@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)

Comment 13 by caseq@chromium.org, Apr 11 2018

Cc: arthurso...@chromium.org yhirano@chromium.org davidben@chromium.org dtrainor@chromium.org alex...@chromium.org clamy@chromium.org krajshree@chromium.org jam@chromium.org nasko@chromium.org
 Issue 760924  has been merged into this issue.
►

Sign in to add a comment