New issue
Advanced search Search tips

Issue 791831 link

Starred by 4 users
Status: Fixed
Owner:
b...@chromium.org
Closed: May 2018
Cc:
gab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NetTestSuite has a global ScopedTaskEnvironment

Project Member Reported by xunji...@chromium.org, Dec 5 2017 
NetTestSuite (net/test/net_test_suite.h) has a global ScopedTaskEnvironment of message loop type IO.

This makes testing of individual test difficult because the task environment is shared between tests. One test might have left things in the task environment which would affect subsequent tests. 

As base::ScopedMockTimeMessageLoopTaskRunner is being deprecated, individual tests which want to mock out time need to use a ScopedTaskEnvironment of MOCK_TIME. Since there's already a global ScopedTaskEnvironment, individual tests can't create its own ScopedTaskEnvironment.

The ScopedTaskEnvironment should be bound to a test base class instead of the test suite.

Comment 1 by b...@chromium.org, Dec 5 2017

Cc: -b...@chromium.org
Owner: b...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f39a0ab4d84f7704af79fbb9909334ec1a82de4

commit 1f39a0ab4d84f7704af79fbb9909334ec1a82de4
Author: Miriam Gershenson <mgersh@chromium.org>
Date: Thu Dec 21 18:40:43 2017

Add method to reset the NetTestSuite's ScopedTaskEnvironment

Bug:  791831 
Change-Id: If1df41372aec7317847b77825a89b96c6e547e54
Reviewed-on: https://chromium-review.googlesource.com/839966
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525748}
[modify] https://crrev.com/1f39a0ab4d84f7704af79fbb9909334ec1a82de4/net/dns/dns_transaction_unittest.cc
[modify] https://crrev.com/1f39a0ab4d84f7704af79fbb9909334ec1a82de4/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/1f39a0ab4d84f7704af79fbb9909334ec1a82de4/net/test/net_test_suite.cc
[modify] https://crrev.com/1f39a0ab4d84f7704af79fbb9909334ec1a82de4/net/test/net_test_suite.h

Comment 3 by gab@chromium.org, Jan 9 2018

Cc: gab@chromium.org
It would be very nice to automatically have a fresh ScopedTaskEnvironment for every test. It is specifically designed to give a "scoped task environment" to every test so they don't interfere with each other... sharing it in a suite defeats the purpose... (as we saw in  issue 799081 ).

Barring that I'm curious what prevents MOCK_TIME by default? Is it because it doesn't mix with MainThreadType::IO? (if so I'm working on that!)

I'd love to move towards ScopedTaskEnvironment having mock time by default everywhere so if there's something that prevents that in net I'd like to know as soon as possible :)

Comment 4 by xunji...@chromium.org, Jan 9 2018 

> Barring that I'm curious what prevents MOCK_TIME by default? Is it because it doesn't mix with MainThreadType::IO? (if so I'm working on that!)

> I'd love to move towards ScopedTaskEnvironment having mock time by default everywhere so if there's something that prevents that in net I'd like to know as soon as possible :)

If we can have a MOCK_TIME that allows IO operations that will be great. //net have thread checks to make sure the task runner can handle IO.

Comment 5 by b...@chromium.org, Mar 27 2018

Cc: b...@chromium.org
Owner: ----
Status: Available (was: Started)

Comment 6 by mmenke@chromium.org, Mar 28 2018

Labels: Network-Triaged

Comment 7 by b...@chromium.org, Apr 16 2018 

Circling back to comments #8 and #9, if kDefaultMainThreadType in net_test_suite.cc is changed from IO to MOCK_TIME, then 979 of 36912 net_unittest targets crash.  Most of them at base/threading/thread_task_runner_handle.cc:99 (most of these seem to be called from EmbeddedTestServer::PostTaskToIOThreadAndWait) or base/message_loop/message_loop_current.cc:184 or net/cert_net/nss_ocsp.cc:75.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71838bd71e97e880b5554086ccfd5b84f07fbcf

commit b71838bd71e97e880b5554086ccfd5b84f07fbcf
Author: Bence Béky <bnc@chromium.org>
Date: Thu Apr 19 18:23:38 2018

Do not use ScopedMockTimeMessageLoopTaskRunner in //net.

Remove all uses of deprecated ScopedMockTimeMessageLoopTaskRunner in
//net in favor of ScopedTaskEnvironment.  Also add
GetMockTimeTaskRunner() method to ScopedTaskEnvironment so that
HasPendingTask(), GetPendingTaskCount(), and NextPendingTaskDelay()
methods can be called just like before.

The relation to  https://crbug.com/829429  is that because of presubmit
rules, this is blocking the rename of
net/http/http_stream_factory_job_controller_unittest.cc at
https://crrev.com/c/1000487.

Bug:  829429 ,  791831 
Change-Id: I445dca6ef8d91e1088c14b0f52d2358950b7e50f
Reviewed-on: https://chromium-review.googlesource.com/1005109
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552088}
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/base/test/scoped_task_environment.cc
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/base/test/scoped_task_environment.h
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/net/http/http_stream_factory_impl_job_controller_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0161f2d0428c1205895ea47f7aa4689506718ee4

commit 0161f2d0428c1205895ea47f7aa4689506718ee4
Author: Bence Béky <bnc@chromium.org>
Date: Wed May 02 12:41:24 2018

Refactor DNS transaction tests.

Some DNS transaction tests require ScopedTaskEnvironment(MainThreadType::IO),
some require ScopedTaskEnvironment(MainThreadType::MockTime). Factor out
common stuff to DnsTransactionTestBase and create two derived test classes.

This is prework for https://crrev.com/c/1037405.

Bug:  791831 
Change-Id: I4e8c1b94f41d824a467fc0cee8349c821662721f
Reviewed-on: https://chromium-review.googlesource.com/1037703
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555362}
[modify] https://crrev.com/0161f2d0428c1205895ea47f7aa4689506718ee4/net/dns/dns_transaction_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28c9ed244b6052bc5b870e9d1b8a25d7804ebf76

commit 28c9ed244b6052bc5b870e9d1b8a25d7804ebf76
Author: Bence Béky <bnc@chromium.org>
Date: Fri May 04 11:58:20 2018

Use mock proxy client socket in some tests.

This is necessary to avoid creating a DefaultClientSocketFactory, which
is a leaky singleton and therefore would hold a reference to
ScopedTaskEnvironment's reference counted MockTimeTaskRunner forever,
thus preventing the creating of another ScopedTaskEnvironment.

This is prework for https://crrev.com/c/1037405.

Bug:  791831 
Change-Id: Iba9e17cc51d7002318f3a27d694b3d9230f36d4e
Reviewed-on: https://chromium-review.googlesource.com/1037324
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556028}
[modify] https://crrev.com/28c9ed244b6052bc5b870e9d1b8a25d7804ebf76/net/http/http_stream_factory_job_controller_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98447b1c64f7e7a6f2be2fb136a12c967007360e

commit 98447b1c64f7e7a6f2be2fb136a12c967007360e
Author: Bence Béky <bnc@chromium.org>
Date: Tue May 08 03:14:01 2018

Remove ScopedTaskEnvironment from NetTestSuite.

Remove global ScopedTaskEnvironment instance that lives across all of
net_unittests.  Add a local variable or test fixture member to whichever
test would crash/fail without that.  Change type from default to IO
for whichever test would crash/fail without that.

In some cases, like HttpServerPropertiesManagerTest, make member private
and add protected accessors.  In most other cases make member protected
and access directly from tests.  I was mostly doing this by occurrence,
and I'm happy to change any test in either direction.

I made scoped_task_environment_ the last member unless it was necessary
to construct it before the constructor of some other members.  I
generally made it a private member, unless it is manipulated from a test
and I was too lazy to write an accessor, or unless it needed to be
created before other, non-private members, because I did not feel like
the ugliness of multiple alternating private and protected sections is
justified.  I'm happy to change this is necessary.

Bug:  791831 
Change-Id: I578690820c07264372cff9dbd8bd9c944c243ba8
Reviewed-on: https://chromium-review.googlesource.com/1037405
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556667}
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/BUILD.gn
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/android/http_auth_negotiate_android_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/android/network_change_notifier_android_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/android/traffic_stats_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/address_tracker_linux_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/directory_lister_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/elements_upload_data_stream_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/file_stream_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/layered_network_delegate_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/network_change_notifier_win_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/test_completion_callback_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/base/upload_file_element_reader_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/cert/multi_threaded_cert_verifier_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/cert/nss_cert_database_chromeos_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/cert/nss_cert_database_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/cert_net/cert_net_fetcher_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/cert_net/nss_ocsp_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/backend_cleanup_tracker_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/disk_cache_perftest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/disk_cache_test_base.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/disk_cache_test_base.h
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/simple/simple_index_file_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/disk_cache/simple/simple_index_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/address_sorter_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/dns_config_service_posix_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/dns_config_service_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/dns_transaction_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/host_resolver_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/host_resolver_mojo_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/mapped_host_resolver_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/mdns_client_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/mojo_host_resolver_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/dns/serial_worker_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/extras/sqlite/sqlite_channel_id_store_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ftp/ftp_network_transaction_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_auth_controller_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_auth_handler_negotiate_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_auth_handler_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_cache_lookup_manager_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_cache_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_cache_writers_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_network_layer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_network_transaction_ssl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_response_body_drainer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_server_properties_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_stream_parser_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/http/transport_security_persister_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/log/file_net_log_observer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/log/net_log_util_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/log/trace_net_log_observer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/network_error_logging/network_error_logging_end_to_end_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/nqe/network_qualities_prefs_manager_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/nqe/network_quality_estimator_util_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/nqe/socket_watcher_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/nqe/throughput_analyzer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/dhcp_pac_file_adapter_fetcher_win_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/dhcp_pac_file_fetcher_factory_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/dhcp_pac_file_fetcher_win_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/multi_threaded_proxy_resolver_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/network_delegate_error_observer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/pac_file_decider_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/proxy_config_service_android_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/proxy_config_service_linux_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/proxy_resolution_service_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/proxy_resolver_v8_tracing_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/proxy_resolver_v8_tracing_wrapper_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/proxy_resolution/proxy_resolver_v8_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/network_connection_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_chromium_client_session_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_chromium_client_stream_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/reporting/reporting_service_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/reporting/reporting_test_util.h
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/reporting/reporting_uploader_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/server/http_server_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/sequenced_socket_data_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/socket_bio_adapter_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/socks5_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/socks_client_socket_pool_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/socks_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/tcp_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/tcp_server_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/transport_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/udp_socket_perftest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/udp_socket_posix_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/unix_domain_client_socket_posix_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/unix_domain_server_socket_posix_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/websocket_endpoint_lock_manager_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/socket/websocket_transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/spdy_http_stream_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/spdy_session_pool_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/spdy_session_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/spdy/chromium/spdy_stream_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/channel_id_service_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/client_cert_store_nss_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/client_cert_store_unittest-inl.h
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/default_channel_id_store_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/ssl_client_session_cache_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/ssl_platform_key_android_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/ssl_platform_key_mac_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/ssl_platform_key_nss_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/ssl/ssl_platform_key_win_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/test/embedded_test_server/embedded_test_server_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/test/net_test_suite.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/test/net_test_suite.h
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/test/tcp_socket_proxy_unittest.cc
[add] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/test/test_with_scoped_task_environment.h
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/tools/quic/end_to_end_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/tools/quic/quic_simple_client_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/report_sender_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_fetcher_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_fetcher_response_writer_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_context_builder_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_context_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_file_dir_job_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_file_job_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_filter_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_job_factory_impl_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_job_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_quic_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_simple_job_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_throttler_simulation_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_throttler_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/url_request/view_cache_helper_unittest.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/websockets/websocket_basic_stream_adapters_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/websockets/websocket_basic_stream_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/websockets/websocket_channel_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/websockets/websocket_handshake_stream_create_helper_test.cc
[modify] https://crrev.com/98447b1c64f7e7a6f2be2fb136a12c967007360e/net/websockets/websocket_stream_create_test_base.h

Comment 12 by b...@chromium.org, May 8 2018

Cc: -b...@chromium.org
Owner: b...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment