Issue metadata
Sign in to add a comment
|
Lock screen tablet mode: On screen keyboard overlaps with user pod, completely hiding password input field |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 64.0.3280.5 (Official Build) dev (64-bit) Revision 0 Platform 10176.3.0 (Official Build) dev-channel eve What steps will reproduce the problem? (1) Device in tablet mode (2) Lock the screen (3) Touch on password input field What happens ? On screen keyboard overlaps with user pod, completely hiding password input field.
,
Dec 5 2017
,
Dec 7 2017
M64 beta is targeted for next Tuesday (12-Dec); anything we can do to close this out and/or retag as stable block is appreciated. I'll ping the owner as well. Thanks!
,
Dec 8 2017
,
Dec 8 2017
This is a regression and a pretty serious one. This should remain ReleaseBlock-Beta. Aga, let me know if you need some help to get this fixed earlier.
,
Dec 8 2017
K. I will get it done.
,
Dec 11 2017
Thanks Aga. Plus a reminder to please re-evaluate today (Monday, 11-Dec). We're targeting Beta for tomorrow, so please update if a) this isn't blocking, b) the impacted boards can be identified, c) this is resolved / not reproducible, d) a merge / fix can be submitted today. Thanks!
,
Dec 11 2017
Thank you for reminder! Fix is in review[*] and I asked reviewer to prioritize reviewing it. The patch is short and I am aiming at submitting it today (ASAP). [*] https://chromium-review.googlesource.com/c/chromium/src/+/818628
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af940d2be24a4a57b9aa946e7d55a5f1c8aed3b2 commit af940d2be24a4a57b9aa946e7d55a5f1c8aed3b2 Author: Aga Wronska <agawronska@chromium.org> Date: Mon Dec 11 19:26:16 2017 Fix overlapping of the virtual keyboard on lock screen. Override virtual keyboard overscrolling for view based lock and login screens. Virtual keyboard overscrolling is interfering with resizing window properly. The override is used in web based lock and login screens. See crbug.com/363635 for context. Bug: 791817 Change-Id: Ic04b0823db1ffc2f4e96983f0ac9606ee6dadbb2 Reviewed-on: https://chromium-review.googlesource.com/818628 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#523167} [modify] https://crrev.com/af940d2be24a4a57b9aa946e7d55a5f1c8aed3b2/ash/login/ui/lock_window.cc
,
Dec 11 2017
,
Dec 11 2017
Approving merge to M64 Chrome OS.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5a2055949ed4485a2a2f026b22141e37a2b37b3 commit d5a2055949ed4485a2a2f026b22141e37a2b37b3 Author: Jacob Dufault <jdufault@google.com> Date: Mon Dec 11 22:45:01 2017 Fix overlapping of the virtual keyboard on lock screen. Override virtual keyboard overscrolling for view based lock and login screens. Virtual keyboard overscrolling is interfering with resizing window properly. The override is used in web based lock and login screens. See crbug.com/363635 for context. TBR=agawronska@chromium.org (cherry picked from commit af940d2be24a4a57b9aa946e7d55a5f1c8aed3b2) Bug: 791817 Change-Id: Ic04b0823db1ffc2f4e96983f0ac9606ee6dadbb2 Reviewed-on: https://chromium-review.googlesource.com/818628 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523167} Reviewed-on: https://chromium-review.googlesource.com/820591 Cr-Commit-Position: refs/branch-heads/3282@{#154} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/d5a2055949ed4485a2a2f026b22141e37a2b37b3/ash/login/ui/lock_window.cc
,
Dec 12 2017
The PIN keyboard is also partially blocked by the virtual keyboard. Do we want to hide the PIN keyboard while virtual keyboard is shown? (I once tried to use animation to hide PIN but it's not trivial. Can we directly hide PIN for M64?)
,
Dec 12 2017
I believe hiding PIN is the existing behavior for webui lock when virtual keyboard is active? +elizabethchiu@ to confirm desired behavior.
,
Dec 12 2017
Is it still obscured after last cl?
,
Dec 12 2017
I see there is just not enough space on the screen. That needs a separate bug.
,
Dec 12 2017
Please mark this as fixed for TE verification and open separate bug as per #16
,
Dec 12 2017
,
Dec 12 2017
PIN bug: crbug.com/794223
,
Dec 12 2017
Copied issue chromium:791817 to issue chromium:794224
,
Dec 12 2017
Issue 794224 has been merged into this issue.
,
Dec 28 2017
10176.30.0, 64.0.3282.57
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92740fc4137bf725b50727b32b6462bca61d672d commit 92740fc4137bf725b50727b32b6462bca61d672d Author: Aga Wronska <agawronska@chromium.org> Date: Thu Jan 04 00:42:12 2018 Remove keyboard overscroll override from WebUIScreenLocker. The override is set in LockWindow now. Test that keyboard does not overlap with lock screen UI. Bug: 791817 Change-Id: Ic789efd897fcfd60f3c6bfe6189e22f6140bbda2 Reviewed-on: https://chromium-review.googlesource.com/828027 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#526873} [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/BUILD.gn [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/login/ui/lock_debug_view.h [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/login/ui/lock_screen.cc [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/login/ui/lock_screen.h [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/login/ui/lock_window.cc [add] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/login/ui/lock_window_unittest.cc [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/ash/login/ui/login_test_base.h [modify] https://crrev.com/92740fc4137bf725b50727b32b6462bca61d672d/chrome/browser/chromeos/login/lock/webui_screen_locker.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jdufault@chromium.org
, Dec 5 2017Status: Assigned (was: Untriaged)