New issue
Advanced search Search tips

Issue 791815 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR

Blocking:
issue 773882



Sign in to add a comment

VRDisplay image copy path doesn't handle null gpu_memory_buffer

Project Member Reported by billorr@chromium.org, Dec 5 2017

Issue description

We may fail to get GpuMemoryBuffers, and the code doesn't handle this gracefully.
 

Comment 1 by bshe@chromium.org, Dec 7 2017

Status: Assigned (was: Untriaged)
Given this is windows specific and you add yourself as owner. I am going to assign it to you. :) 
Components: Internals>XR
Labels: VR-Desktop
Components: -Internals>XR Internals>XR>VR
Owner: klausw@chromium.org
Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR
Blocking: 773882
Blocking: -773882
Blocking: 773882
Labels: -Pri-3 Pri-2
Marking as blocking - make sure webxr handles this so we don't crash or cause other issues.
In xr_frame_transport.cc, we do check for null, but we should call SubmitFrameMissing if we fail to submit to unblock future frames.
Issue 808225 has been merged into this issue.
Owner: billorr@chromium.org
Status: Started (was: Assigned)
in review
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bda46d1781d56eaa90b099702714ae3681dd6cf

commit 5bda46d1781d56eaa90b099702714ae3681dd6cf
Author: Bill Orr <billorr@chromium.org>
Date: Thu Dec 13 21:12:47 2018

Handle null GpuMemoryBuffer for WebXR

We may get null GpuMemoryBuffers in some cases, so we should
handle them without crashing or hanging presentation.

BUG= 791815 

Change-Id: Ic219bb678a4b1b852a7b299ac0083a5b10ee7a97
Reviewed-on: https://chromium-review.googlesource.com/c/1372475
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616432}
[modify] https://crrev.com/5bda46d1781d56eaa90b099702714ae3681dd6cf/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc

Status: Fixed (was: Started)

Sign in to add a comment