Download API Design doc: https://docs.google.com/document/d/1rfbN4RhKWthdbjs8HhQtc1tDj3letzVub0-BOZeCR1c/edit?ts=59fb575f#heading=h.9oniznq2oar
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a09531974aafd0595082828386cd87d2c52520 commit 87a09531974aafd0595082828386cd87d2c52520 Author: Eugene But <eugenebut@chromium.org> Date: Fri Dec 08 20:02:05 2017 Renamed DownloadManagerController to LegacyDownloadManagerController. DownloadManagerController will be removed from codebase after switching to the new Download UI. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If8fd86f97e7422bd05904995a3695b4ffc6fc231 Reviewed-on: https://chromium-review.googlesource.com/814494 Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#522853} [modify] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/app/main_controller.mm [modify] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/browser/ui/download/BUILD.gn [rename] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/browser/ui/download/legacy_download_manager_controller.h [rename] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/browser/ui/download/legacy_download_manager_controller.mm [rename] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/browser/ui/download/legacy_download_manager_controller_unittest.mm [modify] https://crrev.com/87a09531974aafd0595082828386cd87d2c52520/ios/chrome/browser/ui/download/resources/DownloadManagerController.xib
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ffe277e6d2e7543685d0431da2377a06881b01d commit 3ffe277e6d2e7543685d0431da2377a06881b01d Author: Eugene But <eugenebut@chromium.org> Date: Tue Dec 19 02:30:15 2017 Added DownloadTask::GetState() API. Download Manager UI needs to distinguish between NotStarted and InProgress states. DownloadTask::IsDone() will be unnecessary after this change and I'm still thinking if I should keep or remove IsDone(). Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6eacd77a9ba3343b0cd3fbe5778662fe57bb23e1 Reviewed-on: https://chromium-review.googlesource.com/833380 Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#524921} [modify] https://crrev.com/3ffe277e6d2e7543685d0431da2377a06881b01d/ios/web/download/download_task_impl.h [modify] https://crrev.com/3ffe277e6d2e7543685d0431da2377a06881b01d/ios/web/download/download_task_impl.mm [modify] https://crrev.com/3ffe277e6d2e7543685d0431da2377a06881b01d/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/3ffe277e6d2e7543685d0431da2377a06881b01d/ios/web/public/download/download_task.h [modify] https://crrev.com/3ffe277e6d2e7543685d0431da2377a06881b01d/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/3ffe277e6d2e7543685d0431da2377a06881b01d/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/410df8b18f6621ac3dc62b23ed26ab935ee28474 commit 410df8b18f6621ac3dc62b23ed26ab935ee28474 Author: Eugene But <eugenebut@chromium.org> Date: Tue Dec 19 16:05:54 2017 Added DownloadTask::Cancel() API Download Manager will use this API to cancel the download. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f555dfbd64cad6beeceb3bb27f8880900787eea Reviewed-on: https://chromium-review.googlesource.com/833237 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#525046} [modify] https://crrev.com/410df8b18f6621ac3dc62b23ed26ab935ee28474/ios/web/download/download_task_impl.h [modify] https://crrev.com/410df8b18f6621ac3dc62b23ed26ab935ee28474/ios/web/download/download_task_impl.mm [modify] https://crrev.com/410df8b18f6621ac3dc62b23ed26ab935ee28474/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/410df8b18f6621ac3dc62b23ed26ab935ee28474/ios/web/public/download/download_task.h [modify] https://crrev.com/410df8b18f6621ac3dc62b23ed26ab935ee28474/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/410df8b18f6621ac3dc62b23ed26ab935ee28474/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8cc902fbdeb075c3a5e59021f6f4004f90dde84a commit 8cc902fbdeb075c3a5e59021f6f4004f90dde84a Author: Eugene But <eugenebut@google.com> Date: Thu Jan 04 07:48:29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c88f3e861cad101e42378b80f745362ca878f82 commit 6c88f3e861cad101e42378b80f745362ca878f82 Author: Eugene But <eugenebut@google.com> Date: Thu Jan 04 16:45:04 2018 Allow restarting DownloadTask. Download Manager UI will have the button to restart the failed download. This change makes it possible to call DownloadTask::Start as long as the download is not in progress. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I01265069cd9cf839449be4390e7235b72679a977 Reviewed-on: https://chromium-review.googlesource.com/847635 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#527009} [modify] https://crrev.com/6c88f3e861cad101e42378b80f745362ca878f82/ios/web/download/download_task_impl.mm [modify] https://crrev.com/6c88f3e861cad101e42378b80f745362ca878f82/ios/web/download/download_task_impl_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47cad529403cf8483a616d6f24cc8d3ae287b277 commit 47cad529403cf8483a616d6f24cc8d3ae287b277 Author: Eugene But <eugenebut@google.com> Date: Sat Jan 06 00:19:39 2018 Moved download directory related code to a separate util file. This will allow code reuse for both Old and New Download Manager implementations. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5d7d44716c7ebe70af71c9d54c5437afdbea08d7 Reviewed-on: https://chromium-review.googlesource.com/851260 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#527448} [modify] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/app/BUILD.gn [modify] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/app/main_controller.mm [modify] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/browser/download/BUILD.gn [add] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/browser/download/download_directory_util.cc [add] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/browser/download/download_directory_util.h [add] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/browser/download/download_directory_util_unittest.mm [modify] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/browser/ui/download/legacy_download_manager_controller.h [modify] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/ios/chrome/browser/ui/download/legacy_download_manager_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/918e109076889387925b15e113762c1a74af4839 commit 918e109076889387925b15e113762c1a74af4839 Author: Eugene But <eugenebut@google.com> Date: Mon Jan 08 17:09:17 2018 Gracefully handle the case when expected download size is unknown. Per API contract DownloadTask::GetPercentComplete() should return -1. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I149dd72750d784bc6020bc8c8e5b79374f5ebb62 Reviewed-on: https://chromium-review.googlesource.com/852800 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#527654} [modify] https://crrev.com/918e109076889387925b15e113762c1a74af4839/ios/web/download/download_task_impl.mm [modify] https://crrev.com/918e109076889387925b15e113762c1a74af4839/ios/web/download/download_task_impl_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4deeb17d7dd6ec89ca86751dc20ec62734efd827 commit 4deeb17d7dd6ec89ca86751dc20ec62734efd827 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 09 16:48:48 2018 Added DownloadTask::GetReceivedBytes() methods. This method is needed because it's not possible to calculate received bytes from already existing GetTotalBytes() and GetPercentComplete(). This is because GetReceivedBytes() and GetPercentComplete() return -1 if the final download size is unknown. Received bytes info is needed for New Download Manager UI. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab4d5aa8d1dc7f49a9bc9d60889baf693af0d4f0 Reviewed-on: https://chromium-review.googlesource.com/853282 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#528019} [modify] https://crrev.com/4deeb17d7dd6ec89ca86751dc20ec62734efd827/ios/web/download/download_task_impl.h [modify] https://crrev.com/4deeb17d7dd6ec89ca86751dc20ec62734efd827/ios/web/download/download_task_impl.mm [modify] https://crrev.com/4deeb17d7dd6ec89ca86751dc20ec62734efd827/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/4deeb17d7dd6ec89ca86751dc20ec62734efd827/ios/web/public/download/download_task.h [modify] https://crrev.com/4deeb17d7dd6ec89ca86751dc20ec62734efd827/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/4deeb17d7dd6ec89ca86751dc20ec62734efd827/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f90eabc34a0a255fd70a0df5b3c16d522215c858 commit f90eabc34a0a255fd70a0df5b3c16d522215c858 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 09 17:29:14 2018 Correctly use net::URLFetcherResponseWriter::Write API. net::URLFetcherFileWriter requires callers of Write to wait for completion callback until the next Write call. NSURLSessionDataDelegate didReceiveData: callback on the other hand provides only synchronous way to write the data. This CL moves NSURLSessionDataDelegate callbacks to a background serial queue so URLSession:dataTask:didReceiveData: callback can wait until data is written on every enumerateByteRangesUsingBlock iteration. GCD semaphore is used for synchronization, because WaitableEvent::Wait can only be used in tests, and it is really necessary to block enumerateByteRangesUsingBlock loop and wait for data being written. Unit tests now have to wait until OnDownloadUpdated callback because NSURLSessionDataDelegate are now asynchronous. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf6056433601930171b919a76cd08caf42b6fbb7 Reviewed-on: https://chromium-review.googlesource.com/848029 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#528027} [modify] https://crrev.com/f90eabc34a0a255fd70a0df5b3c16d522215c858/ios/web/download/download_task_impl.mm [modify] https://crrev.com/f90eabc34a0a255fd70a0df5b3c16d522215c858/ios/web/download/download_task_impl_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4429ca2590d6988c0745c24c8858745aaaec01ef commit 4429ca2590d6988c0745c24c8858745aaaec01ef Author: Eugene But <eugenebut@google.com> Date: Tue Jan 09 23:08:58 2018 Implement DownloadManagerTabHelper. The new download design will use standard patterns from New Architecture to manage the in-progress download per tab: - KeyedService - TabHelper - Coordinator - ViewController This CL creates a TabHelper which will be used by KeyedService and will delegate UI functionality to Coordinator via TabHelperDelegate. Design doc: https://goto.google.com/ios-chrome-download Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieb7357acb86e8a93826c00040df961e363568af2 Reviewed-on: https://chromium-review.googlesource.com/854727 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#528157} [modify] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/browser/download/BUILD.gn [add] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/browser/download/download_manager_tab_helper.h [add] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/browser/download/download_manager_tab_helper.mm [add] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/browser/download/download_manager_tab_helper_delegate.h [add] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm [modify] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/test/fakes/BUILD.gn [add] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.h [add] https://crrev.com/4429ca2590d6988c0745c24c8858745aaaec01ef/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/249a7f8c9ee1d0b025e3204ef4f122d24ec4195f commit 249a7f8c9ee1d0b025e3204ef4f122d24ec4195f Author: Eugene But <eugenebut@google.com> Date: Wed Jan 10 22:35:32 2018 Ignore nil value from countOfBytesExpectedToReceive. NSURLSessionTask.countOfBytesExpectedToReceive property is 0 when the device is offline. If that's the case there is no need to update DownloadTasks's total_bytes_ ivar, because old value could be correct. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I941e6d5cf829d7dde3a93eb875f29d61afbd06fb Reviewed-on: https://chromium-review.googlesource.com/855531 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#528449} [modify] https://crrev.com/249a7f8c9ee1d0b025e3204ef4f122d24ec4195f/ios/web/download/download_task_impl.mm [modify] https://crrev.com/249a7f8c9ee1d0b025e3204ef4f122d24ec4195f/ios/web/download/download_task_impl_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ccd7c58c7685706e29ea1913eae7b4107feac90 commit 5ccd7c58c7685706e29ea1913eae7b4107feac90 Author: Eugene But <eugenebut@google.com> Date: Wed Jan 10 22:37:37 2018 Added DownloadTask::GetPageTransition method. Download Manager will support only one active download per page. When the second download is requested, the following logic will apply: - if download is initiated by the user, then download manager will ask if new download should replace the old one - if download is not user initiated then new download will be dropped silently DownloadTask::GetPageTransition will be used to decide whether or not the download should be dropped silently. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5b1b18f47ee9dd0e514497297e48bfdab2b51558 Reviewed-on: https://chromium-review.googlesource.com/855239 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#528450} [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/BUILD.gn [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_controller_impl.h [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_controller_impl.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_controller_impl_unittest.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_inttest.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_task_impl.h [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_task_impl.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/public/download/BUILD.gn [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/public/download/download_controller.h [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/public/download/download_task.h [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/public/test/fakes/fake_download_task.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/5ccd7c58c7685706e29ea1913eae7b4107feac90/ios/web/web_state/ui/crw_web_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5c21ef9929488d771eaab6fcd0a2ef69cafa3e2 commit d5c21ef9929488d771eaab6fcd0a2ef69cafa3e2 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 16 16:15:02 2018 Use DownloadManagerTabHelper in BrowserDownloadService. The new download design will use standard patterns from New Architecture to manage the in-progress download per tab: - KeyedService - TabHelper - Coordinator - ViewController This CL extends BrowserDownloadService to use DownloadManagerTabHelper for downloads other than pkpass files. Design doc: https://goto.google.com/ios-chrome-download Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a72582f35a45e64af2bc05f9c4e350956d6af95 Reviewed-on: https://chromium-review.googlesource.com/865937 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#529436} [modify] https://crrev.com/d5c21ef9929488d771eaab6fcd0a2ef69cafa3e2/ios/chrome/browser/download/browser_download_service.mm [modify] https://crrev.com/d5c21ef9929488d771eaab6fcd0a2ef69cafa3e2/ios/chrome/browser/download/browser_download_service_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fd76c719d897cd8b4cbc47129652853982bb71e commit 3fd76c719d897cd8b4cbc47129652853982bb71e Author: Eugene But <eugenebut@google.com> Date: Fri Jan 19 16:11:34 2018 Start and stop network activity indicator in DownloadManagerTabHelper. This allow to show system's network activity indicator for new download manager UI. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6e30096a7f023c95b5d4a1e215f5e6fde3c41580 Reviewed-on: https://chromium-review.googlesource.com/872031 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#530526} [modify] https://crrev.com/3fd76c719d897cd8b4cbc47129652853982bb71e/ios/chrome/browser/download/BUILD.gn [modify] https://crrev.com/3fd76c719d897cd8b4cbc47129652853982bb71e/ios/chrome/browser/download/download_manager_tab_helper.h [modify] https://crrev.com/3fd76c719d897cd8b4cbc47129652853982bb71e/ios/chrome/browser/download/download_manager_tab_helper.mm [modify] https://crrev.com/3fd76c719d897cd8b4cbc47129652853982bb71e/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm [modify] https://crrev.com/3fd76c719d897cd8b4cbc47129652853982bb71e/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3fd76c719d897cd8b4cbc47129652853982bb71e/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e173942fcdf74c98f99f90255df5272465aff66c commit e173942fcdf74c98f99f90255df5272465aff66c Author: Eugene But <eugenebut@google.com> Date: Wed Jan 24 18:44:02 2018 Implement DownloadManagerViewController. The new download design will use standard patterns from New Architecture to manage the in-progress download per tab: - KeyedService - TabHelper - Coordinator - ViewController This CL creates a ViewController which will be used by Coordinator to present download infobar UI. This is only basic UI implementation which does not have progress bar, localizations, and download icon yet. Design doc: https://goto.google.com/ios-chrome-download UI mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit?ts=5a59396d#slide=id.g2b7a689b42_0_211 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9ba110ed3fc2cb2ac6d48dc9a697d34c84342340 Reviewed-on: https://chromium-review.googlesource.com/865827 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#531623} [modify] https://crrev.com/e173942fcdf74c98f99f90255df5272465aff66c/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/e173942fcdf74c98f99f90255df5272465aff66c/ios/chrome/browser/ui/download/download_manager_view_controller.h [add] https://crrev.com/e173942fcdf74c98f99f90255df5272465aff66c/ios/chrome/browser/ui/download/download_manager_view_controller.mm [add] https://crrev.com/e173942fcdf74c98f99f90255df5272465aff66c/ios/chrome/browser/ui/download/download_manager_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ed4d1357683d92f70a5f3956b76998957f31bd5 commit 4ed4d1357683d92f70a5f3956b76998957f31bd5 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 30 02:08:28 2018 Extend downloadManagerTabHelper:didCreateDownload: callback with "webStateIsVisible" flag. This API will be used by DownloadManagerCoordinator to ignore callbacks from hidden tabs. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I453db842ba93c50bcbb9a9987cf614a29e963d21 Reviewed-on: https://chromium-review.googlesource.com/884363 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#532732} [modify] https://crrev.com/4ed4d1357683d92f70a5f3956b76998957f31bd5/ios/chrome/browser/download/download_manager_tab_helper.mm [modify] https://crrev.com/4ed4d1357683d92f70a5f3956b76998957f31bd5/ios/chrome/browser/download/download_manager_tab_helper_delegate.h [modify] https://crrev.com/4ed4d1357683d92f70a5f3956b76998957f31bd5/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm [modify] https://crrev.com/4ed4d1357683d92f70a5f3956b76998957f31bd5/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/069fc4a2db2f6a2ea1f65703b66815457e5634f5 commit 069fc4a2db2f6a2ea1f65703b66815457e5634f5 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 30 17:01:48 2018 Add and integrate DownloadManagerCoordinator class. This is the final CL for New Download Manager UI skeleton. This adds coordinator class and creates DownloadManagerTabHelper object in BVC. New Download Manager feature is still not enabled in flags. Design doc: https://goto.google.com/ios-chrome-download Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8fcd0646762ef90465aa722622102a5e2b23c413 Reviewed-on: https://chromium-review.googlesource.com/889399 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#532923} [modify] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/browser/download/download_manager_tab_helper_delegate.h [modify] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/browser/ui/download/download_manager_coordinator.h [add] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/browser/ui/download/download_manager_coordinator.mm [add] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/test/fakes/BUILD.gn [add] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/test/fakes/fake_contained_presenter.h [add] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/test/fakes/fake_contained_presenter.mm [modify] https://crrev.com/069fc4a2db2f6a2ea1f65703b66815457e5634f5/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88083f4e9894ef461690d1b240717451aafbd5a7 commit 88083f4e9894ef461690d1b240717451aafbd5a7 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 30 17:51:37 2018 Add New Download Manager feature to chrome://flags. The flag is still disabled by default. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc438f98e359e7f4c1c86ce10c175e5b94344cef Reviewed-on: https://chromium-review.googlesource.com/889642 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#532937} [modify] https://crrev.com/88083f4e9894ef461690d1b240717451aafbd5a7/ios/chrome/browser/about_flags.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e38fa19bbe0c967e4574383bc9954b530954804 commit 8e38fa19bbe0c967e4574383bc9954b530954804 Author: Eugene But <eugenebut@google.com> Date: Tue Feb 06 02:29:11 2018 Add DownloadManagerMediator and DownloadManagerConsumer. Model code was moved from DownloadManagerCoordinator to DownloadManagerMediator. This removes the need for downloadManagerTabHelper:didUpdateDownload: callback, because mediator can observe download task updates. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29928c864429be63ef44f1894ac9a368cf87f296 Reviewed-on: https://chromium-review.googlesource.com/894637 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534596} [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/download/download_manager_tab_helper.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/download/download_manager_tab_helper_delegate.h [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_consumer.h [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [add] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_mediator.h [add] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_mediator.mm [add] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_mediator_unittest.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_view_controller.h [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_view_controller.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/browser/ui/download/download_manager_view_controller_unittest.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/test/fakes/BUILD.gn [add] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/test/fakes/fake_download_manager_consumer.h [add] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/test/fakes/fake_download_manager_consumer.mm [modify] https://crrev.com/8e38fa19bbe0c967e4574383bc9954b530954804/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c9af76f10cebc163c331020c02cb211a3f6ea3d commit 4c9af76f10cebc163c331020c02cb211a3f6ea3d Author: Eugene But <eugenebut@google.com> Date: Fri Feb 16 18:33:15 2018 Run confirmation dialog before cancelling in progress download. There is no unit test for tapping OK and Cancel buttons, because it's something that is very hard to test in unit test (buttons are not tappable unless the UI got synchronized). UI mock: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic291ef5db83eaea4220ff1ed3f9501020de7389f Reviewed-on: https://chromium-review.googlesource.com/919492 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537357} [modify] https://crrev.com/4c9af76f10cebc163c331020c02cb211a3f6ea3d/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/4c9af76f10cebc163c331020c02cb211a3f6ea3d/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3fe4f47ab33d6ca1e24712492e25f2f0e997695 commit d3fe4f47ab33d6ca1e24712492e25f2f0e997695 Author: Eugene But <eugenebut@google.com> Date: Tue Feb 20 17:46:39 2018 Run confirmation dialog before replacing in progress download. There is no unit test for tapping OK and Cancel buttons, because it's something that is very hard to test in unit test (buttons are not tappable unless the UI got synchronized). This CL adds "Start New Download?" dialog when user attemps to create a download while another download is in progress. UI mock: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icde65bf68d4ee0ff4181165a4d812f9e16e8de9e Reviewed-on: https://chromium-review.googlesource.com/924750 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#537811} [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/browser/download/download_manager_tab_helper.h [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/browser/download/download_manager_tab_helper.mm [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/browser/download/download_manager_tab_helper_delegate.h [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.h [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/chrome/test/fakes/fake_download_manager_tab_helper_delegate.mm [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/d3fe4f47ab33d6ca1e24712492e25f2f0e997695/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2be1f61d07c5f6c6e885dd0748a29e74cd545a77 commit 2be1f61d07c5f6c6e885dd0748a29e74cd545a77 Author: Eugene But <eugenebut@google.com> Date: Fri Feb 23 02:15:50 2018 Add Install Google Drive button to new Download Manager UI. If Google Drive app is not installed then Download Manager shows "Install Google Drive" button after the download is complete. This CL adds new API to DownloadManagerViewController which allows to show Install button. The changes which call this new API will be made in separate CLs. UI Mock: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2eee39b982_0_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d949f5b8a12646bcebb86e9035dee9edb8027cf Reviewed-on: https://chromium-review.googlesource.com/932643 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#538667} [modify] https://crrev.com/2be1f61d07c5f6c6e885dd0748a29e74cd545a77/ios/chrome/browser/ui/download/download_manager_consumer.h [modify] https://crrev.com/2be1f61d07c5f6c6e885dd0748a29e74cd545a77/ios/chrome/browser/ui/download/download_manager_view_controller.h [modify] https://crrev.com/2be1f61d07c5f6c6e885dd0748a29e74cd545a77/ios/chrome/browser/ui/download/download_manager_view_controller.mm [modify] https://crrev.com/2be1f61d07c5f6c6e885dd0748a29e74cd545a77/ios/chrome/browser/ui/download/download_manager_view_controller_unittest.mm [modify] https://crrev.com/2be1f61d07c5f6c6e885dd0748a29e74cd545a77/ios/chrome/test/fakes/fake_download_manager_consumer.h [modify] https://crrev.com/2be1f61d07c5f6c6e885dd0748a29e74cd545a77/ios/chrome/test/fakes/fake_download_manager_consumer.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef7dd40de4b3a72cb13dfb0b187bb386c238ae15 commit ef7dd40de4b3a72cb13dfb0b187bb386c238ae15 Author: Eugene But <eugenebut@chromium.org> Date: Fri Feb 23 19:47:36 2018 Extract StoreKitCoordinator class from BVC. This removes code from BVC and allows reusing Store Kit code in DownloadManagerCoordinator. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5d33de9666a0bdc35fb3d451158b33a8636bf4d Reviewed-on: https://chromium-review.googlesource.com/934315 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#538867} [modify] https://crrev.com/ef7dd40de4b3a72cb13dfb0b187bb386c238ae15/ios/chrome/browser/store_kit/BUILD.gn [add] https://crrev.com/ef7dd40de4b3a72cb13dfb0b187bb386c238ae15/ios/chrome/browser/store_kit/store_kit_coordinator.h [add] https://crrev.com/ef7dd40de4b3a72cb13dfb0b187bb386c238ae15/ios/chrome/browser/store_kit/store_kit_coordinator.mm [add] https://crrev.com/ef7dd40de4b3a72cb13dfb0b187bb386c238ae15/ios/chrome/browser/store_kit/store_kit_coordinator_unittest.mm [modify] https://crrev.com/ef7dd40de4b3a72cb13dfb0b187bb386c238ae15/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4594fb5e5fb8d13146ee4d059bdaf636d247f82f commit 4594fb5e5fb8d13146ee4d059bdaf636d247f82f Author: Eugene But <eugenebut@chromium.org> Date: Tue Feb 27 02:17:00 2018 Add image sets for New Download Manager UI. These images are not used yet, just added to the application bundle. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd0779785e537b14c5bbbf53cefb6069d778f666 Reviewed-on: https://chromium-review.googlesource.com/935026 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539375} [modify] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/BUILD.gn [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_done.imageset/Contents.json [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_done.imageset/download_done.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_done.imageset/download_done@2x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_done.imageset/download_done@3x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_error.imageset/Contents.json [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_error.imageset/download_error.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_error.imageset/download_error@2x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_error.imageset/download_error@3x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_file.imageset/Contents.json [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_file.imageset/download_file.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_file.imageset/download_file@2x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_file.imageset/download_file@3x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_progress.imageset/Contents.json [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_progress.imageset/download_progress.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_progress.imageset/download_progress@2x.png [add] https://crrev.com/4594fb5e5fb8d13146ee4d059bdaf636d247f82f/ios/chrome/browser/ui/download/resources/download_progress.imageset/download_progress@3x.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/393789f0813df32c91ea4031bb40e18ced952706 commit 393789f0813df32c91ea4031bb40e18ced952706 Author: Eugene But <eugenebut@google.com> Date: Tue Feb 27 22:52:49 2018 Add Install Google Drive button tap handler. When the button is tapped, DownloadManagerCoordinator does the following: - starts StoreKitCoordinator (which presents StoreKit dialog) - hides Install Google Drive Button UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2eee39b982_0_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2bcc400e9fafbde54f251fc05e8b607cc70e463b Reviewed-on: https://chromium-review.googlesource.com/937995 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#539570} [modify] https://crrev.com/393789f0813df32c91ea4031bb40e18ced952706/ios/chrome/browser/download/BUILD.gn [add] https://crrev.com/393789f0813df32c91ea4031bb40e18ced952706/ios/chrome/browser/download/google_drive_app_constants.h [add] https://crrev.com/393789f0813df32c91ea4031bb40e18ced952706/ios/chrome/browser/download/google_drive_app_constants.mm [modify] https://crrev.com/393789f0813df32c91ea4031bb40e18ced952706/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/393789f0813df32c91ea4031bb40e18ced952706/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72533a4640bd3adc83cb180c5d04021a9d813361 commit 72533a4640bd3adc83cb180c5d04021a9d813361 Author: Eugene But <eugenebut@google.com> Date: Wed Feb 28 01:22:14 2018 Add EG tests for New Download Manager UI. This CL adds only one test for a sucessfull download flow. Other tests will be added in separate CLs. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I81a37ab02b1c5c2f4551477810e9e3f61575952f Reviewed-on: https://chromium-review.googlesource.com/939041 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539618} [modify] https://crrev.com/72533a4640bd3adc83cb180c5d04021a9d813361/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/72533a4640bd3adc83cb180c5d04021a9d813361/ios/chrome/browser/ui/download/download_manager_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db40e58728ba10a47b152e6b7bec87c05d038966 commit db40e58728ba10a47b152e6b7bec87c05d038966 Author: Eugene But <eugenebut@google.com> Date: Sat Mar 03 00:57:20 2018 Show Install Google Drive button on New Download Manager UI. Install button is shown if download is sucessfully completed and Google Drive app is not installed. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2eee39b982_0_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib884a37a54ac77e22ff30c8c22a3cfaa530343f0 Reviewed-on: https://chromium-review.googlesource.com/938497 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#540701} [modify] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/app/resources/Info.plist [modify] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/download/BUILD.gn [delete] https://crrev.com/21f3ea1fe1b1c08444019304cddba45c7c56755d/ios/chrome/browser/download/google_drive_app_constants.h [delete] https://crrev.com/21f3ea1fe1b1c08444019304cddba45c7c56755d/ios/chrome/browser/download/google_drive_app_constants.mm [add] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/download/google_drive_app_util.h [add] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/download/google_drive_app_util.mm [add] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/download/google_drive_app_util_unittest.mm [modify] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/ui/download/download_manager_mediator.mm [modify] https://crrev.com/db40e58728ba10a47b152e6b7bec87c05d038966/ios/chrome/browser/ui/download/download_manager_mediator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b34e047cde4b8b0b1cd1c47379b158189f61803b commit b34e047cde4b8b0b1cd1c47379b158189f61803b Author: Eugene But <eugenebut@google.com> Date: Mon Mar 05 16:31:50 2018 Add EG test for cancelling Download Manager UI. The test taps on Download link, verifies that download UI appears, taps close button and verifies that download UI is dismissed. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I131e319cd230ce6820956f52d310a487285756d4 Reviewed-on: https://chromium-review.googlesource.com/947706 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#540837} [modify] https://crrev.com/b34e047cde4b8b0b1cd1c47379b158189f61803b/ios/chrome/browser/translate/translate_egtest.mm [modify] https://crrev.com/b34e047cde4b8b0b1cd1c47379b158189f61803b/ios/chrome/browser/ui/download/download_manager_egtest.mm [modify] https://crrev.com/b34e047cde4b8b0b1cd1c47379b158189f61803b/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/b34e047cde4b8b0b1cd1c47379b158189f61803b/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab04d6a8726e1e65ab9baba28e70ee43d1f9d8bd commit ab04d6a8726e1e65ab9baba28e70ee43d1f9d8bd Author: Eugene But <eugenebut@google.com> Date: Mon Mar 05 16:32:58 2018 Add horizontal grey line to split download and install drive controlls. This also changes layout constraints, to make sure that grey line is streatched across all download toolbar. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2f6fee2339_3_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I32f79dba26efe618ac9ac20012c94a01466a06b6 Reviewed-on: https://chromium-review.googlesource.com/947702 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#540839} [modify] https://crrev.com/ab04d6a8726e1e65ab9baba28e70ee43d1f9d8bd/ios/chrome/browser/ui/download/download_manager_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/543ccb1374118038cd97f1f75f86946d652a5e90 commit 543ccb1374118038cd97f1f75f86946d652a5e90 Author: Eugene But <eugenebut@google.com> Date: Mon Mar 05 17:33:54 2018 Download assets and buttons with correct blue color (MDC Blue 600). This CL updates download images and button font colors with correct blue color. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I809bab595b570b7e93a7df7950d9dc95dd10f1a0 Reviewed-on: https://chromium-review.googlesource.com/947395 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#540857} [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/download_manager_view_controller.mm [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/resources/download_done.imageset/download_done.png [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/resources/download_done.imageset/download_done@2x.png [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/resources/download_done.imageset/download_done@3x.png [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/resources/download_file.imageset/download_file.png [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/resources/download_file.imageset/download_file@2x.png [modify] https://crrev.com/543ccb1374118038cd97f1f75f86946d652a5e90/ios/chrome/browser/ui/download/resources/download_file.imageset/download_file@3x.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b171b0afccc72785f46fa9b554fcdb4c2dfe1909 commit b171b0afccc72785f46fa9b554fcdb4c2dfe1909 Author: Eugene But <eugenebut@google.com> Date: Tue Mar 06 19:24:27 2018 Add RadialProgressView to use in New Download Manager UI. This CL only adds UIView. The view will be integrated into Download Manager UI in a separate CL. There are no tests as testing view drawing is hard and not worth the effort. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9dba8b92726a9da6865866a49020f9bb0bc51c74 Reviewed-on: https://chromium-review.googlesource.com/949882 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541171} [modify] https://crrev.com/b171b0afccc72785f46fa9b554fcdb4c2dfe1909/ios/chrome/browser/ui/download/BUILD.gn [add] https://crrev.com/b171b0afccc72785f46fa9b554fcdb4c2dfe1909/ios/chrome/browser/ui/download/radial_progress_view.h [add] https://crrev.com/b171b0afccc72785f46fa9b554fcdb4c2dfe1909/ios/chrome/browser/ui/download/radial_progress_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0989941421d5a097f660d807be6f3a25a73641aa commit 0989941421d5a097f660d807be6f3a25a73641aa Author: Eugene But <eugenebut@google.com> Date: Wed Mar 07 01:24:10 2018 Integrate RadialProgressView into New Download Manager UI. This CL adds RadialProgressView as a subview for DownloadManagerController's view and updates this view according to the download progress. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id1e3ebebcaba1ee41ae350973c246ceb7339154d Reviewed-on: https://chromium-review.googlesource.com/950124 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#541251} [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_consumer.h [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_mediator.h [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_mediator.mm [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_mediator_unittest.mm [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_view_controller.h [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_view_controller.mm [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/browser/ui/download/download_manager_view_controller_unittest.mm [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/test/fakes/fake_download_manager_consumer.h [modify] https://crrev.com/0989941421d5a097f660d807be6f3a25a73641aa/ios/chrome/test/fakes/fake_download_manager_consumer.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a8c55cf2760b99948efff8670e4b867242b7d27 commit 2a8c55cf2760b99948efff8670e4b867242b7d27 Author: Eugene But <eugenebut@google.com> Date: Wed Mar 07 22:57:39 2018 Added Google Drive icon accessible via BrandedImageProvider. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia98dcc56f5681e033d0ec02dd9714d16ca6f40a6 Reviewed-on: https://chromium-review.googlesource.com/947093 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#541623} [modify] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/BUILD.gn [modify] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/chromium_branded_image_provider.h [modify] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/chromium_branded_image_provider.mm [add] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/resources/BUILD.gn [add] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/resources/download_drivium.imageset/Contents.json [add] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/resources/download_drivium.imageset/download_drivium.png [add] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/resources/download_drivium.imageset/download_drivium@2x.png [add] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/chrome/browser/providers/images/resources/download_drivium.imageset/download_drivium@3x.png [modify] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/public/provider/chrome/browser/images/branded_image_provider.h [modify] https://crrev.com/2a8c55cf2760b99948efff8670e4b867242b7d27/ios/public/provider/chrome/browser/images/branded_image_provider.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f4810567d7cede191e544c4bf57013bce92fa9b8 commit f4810567d7cede191e544c4bf57013bce92fa9b8 Author: Eugene But <eugenebut@google.com> Date: Fri Mar 09 15:38:36 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98c33f635308a47061a9bc35f6a638f9f78eac16 commit 98c33f635308a47061a9bc35f6a638f9f78eac16 Author: Eugene But <eugenebut@google.com> Date: Tue Mar 13 15:02:22 2018 Add DownloadTaskObserver::OnDownloadDestroyed. This simplifies DownloadManagerCoordinator code, which does not have to clear download task for mediator anymore. Also adding OnDownloadDestroyed to Download ManagerMediator will help with future changes related to UMA logging. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id7aaab8ddbcce5be6a9d1c408c464df0f69c54b9 Reviewed-on: https://chromium-review.googlesource.com/959707 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#542798} [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/chrome/browser/ui/download/download_manager_mediator.h [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/chrome/browser/ui/download/download_manager_mediator.mm [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/chrome/browser/ui/download/download_manager_mediator_unittest.mm [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/web/download/download_task_impl.mm [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/web/public/download/download_task_observer.h [modify] https://crrev.com/98c33f635308a47061a9bc35f6a638f9f78eac16/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b28c33982ab8968708f3ac525b52613358603743 commit b28c33982ab8968708f3ac525b52613358603743 Author: Eugene But <eugenebut@google.com> Date: Tue Mar 13 15:42:26 2018 Integrate Drive icon into New Download Manager UI. This adds Drive icon below "Download state" icon. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2f6fee2339_3_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id0405502a338aacfe4c2de331adbca89f1fe747e Reviewed-on: https://chromium-review.googlesource.com/956700 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542811} [modify] https://crrev.com/b28c33982ab8968708f3ac525b52613358603743/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/b28c33982ab8968708f3ac525b52613358603743/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/b28c33982ab8968708f3ac525b52613358603743/ios/chrome/browser/ui/download/download_manager_view_controller.h [modify] https://crrev.com/b28c33982ab8968708f3ac525b52613358603743/ios/chrome/browser/ui/download/download_manager_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b33f6fd17c856350a29050056aba22dd436d382 commit 7b33f6fd17c856350a29050056aba22dd436d382 Author: Eugene But <eugenebut@google.com> Date: Tue Mar 13 18:17:56 2018 Compact/regular width support for New Download Manager. This CL has the following changes: - VerticalAnimationContainer does not set width constraint anymore - LanguageSelectionController anchors its width to superview width - DownloadManagerController uses different width constrait depending on user interface size (compact vs. regular and superview width). Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0bb8a72a1f70f8d3ce2d1216407a30f86f9a68c9 Reviewed-on: https://chromium-review.googlesource.com/957593 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#542856} [modify] https://crrev.com/7b33f6fd17c856350a29050056aba22dd436d382/ios/chrome/browser/ui/download/download_manager_view_controller.mm [modify] https://crrev.com/7b33f6fd17c856350a29050056aba22dd436d382/ios/chrome/browser/ui/presenters/vertical_animation_container.mm [modify] https://crrev.com/7b33f6fd17c856350a29050056aba22dd436d382/ios/chrome/browser/ui/presenters/vertical_animation_container_unittest.mm [modify] https://crrev.com/7b33f6fd17c856350a29050056aba22dd436d382/ios/chrome/browser/ui/translate/language_selection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b693bb9f8abd1bf0274a6647d7d918656c4c31fa commit b693bb9f8abd1bf0274a6647d7d918656c4c31fa Author: Eugene But <eugenebut@google.com> Date: Wed Mar 14 15:29:03 2018 Add DownloadManagerCoordinatorTest.OpenIn test. This test verifies UIDocumentInteractionController presentation. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f97d54edc3d6d18597b6278993957fe866c636e Reviewed-on: https://chromium-review.googlesource.com/960965 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#543090} [modify] https://crrev.com/b693bb9f8abd1bf0274a6647d7d918656c4c31fa/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/b693bb9f8abd1bf0274a6647d7d918656c4c31fa/ios/chrome/test/fakes/BUILD.gn [add] https://crrev.com/b693bb9f8abd1bf0274a6647d7d918656c4c31fa/ios/chrome/test/fakes/fake_document_interaction_controller.h [add] https://crrev.com/b693bb9f8abd1bf0274a6647d7d918656c4c31fa/ios/chrome/test/fakes/fake_document_interaction_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/247dee23823419311b2176a697d669aa001f5e74 commit 247dee23823419311b2176a697d669aa001f5e74 Author: Eugene But <eugenebut@google.com> Date: Thu Mar 15 22:15:16 2018 Log MobileDownloadFileUIInstallGoogleDrive in New Download Manager. This CL also changes InstallationNotifier class to be compatible with OCMock (UIApplication shared instance is not stored in ivar anymore) and adds resetDispatcher method to allow restoring InstallationNotifier to its default state. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaee0d80938639d23862b254732eb49c97ddd4e86 Reviewed-on: https://chromium-review.googlesource.com/958123 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#543515} [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/download/BUILD.gn [add] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/download/download_manager_metric_names.cc [add] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/installation_notifier.mm [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/installation_notifier_unittest.mm [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/247dee23823419311b2176a697d669aa001f5e74/ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84b7b568fbd2bf99a036ee26c7090d75d02972f8 commit 84b7b568fbd2bf99a036ee26c7090d75d02972f8 Author: Eugene But <eugenebut@chromium.org> Date: Fri Mar 16 16:21:33 2018 Revert "Log MobileDownloadFileUIInstallGoogleDrive in New Download Manager." This reverts commit 247dee23823419311b2176a697d669aa001f5e74. Reason for revert: Failing on iOS 10 32-bit builder. Original change's description: > Log MobileDownloadFileUIInstallGoogleDrive in New Download Manager. > > This CL also changes InstallationNotifier class to be compatible > with OCMock (UIApplication shared instance is not stored in ivar anymore) > and adds resetDispatcher method to allow restoring InstallationNotifier > to its default state. > > Bug: 791806 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Iaee0d80938639d23862b254732eb49c97ddd4e86 > Reviewed-on: https://chromium-review.googlesource.com/958123 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543515} TBR=eugenebut@chromium.org,pkl@chromium.org Change-Id: I4c90614507c14322c6ab946ac4f8caeedc214cc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/966682 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#543721} [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/download/BUILD.gn [delete] https://crrev.com/31afadd2e5e8d2d43490c82d31202bafda974762/ios/chrome/browser/download/download_manager_metric_names.cc [delete] https://crrev.com/31afadd2e5e8d2d43490c82d31202bafda974762/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/installation_notifier.mm [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/installation_notifier_unittest.mm [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/84b7b568fbd2bf99a036ee26c7090d75d02972f8/ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23b0169f01209f08f6cd0843f779a36dd780236a commit 23b0169f01209f08f6cd0843f779a36dd780236a Author: Eugene But <eugenebut@google.com> Date: Mon Mar 19 19:23:39 2018 Add DownloadTask::HasPerformedBackgroundDownload. This accessor will be used for UMA to understand how many downloads were performed in the background. New Download manager supports background downloads, so the metric will help to measure the success of the feature. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3933a73d71946da363255e1d173bc414fa76ab0b Reviewed-on: https://chromium-review.googlesource.com/965117 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544111} [modify] https://crrev.com/23b0169f01209f08f6cd0843f779a36dd780236a/ios/web/download/download_task_impl.h [modify] https://crrev.com/23b0169f01209f08f6cd0843f779a36dd780236a/ios/web/download/download_task_impl.mm [modify] https://crrev.com/23b0169f01209f08f6cd0843f779a36dd780236a/ios/web/public/download/download_task.h [modify] https://crrev.com/23b0169f01209f08f6cd0843f779a36dd780236a/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/23b0169f01209f08f6cd0843f779a36dd780236a/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4450e677e147f5d05d205be2f21653a1f9154951 commit 4450e677e147f5d05d205be2f21653a1f9154951 Author: Eugene But <eugenebut@google.com> Date: Mon Mar 19 21:19:02 2018 Relanding: Log MobileDownloadFileUIInstallGoogleDrive in New Download Manager. Original description: This CL also changes InstallationNotifier class to be compatible with OCMock (UIApplication shared instance is not stored in ivar anymore) and adds resetDispatcher method to allow restoring InstallationNotifier to its default state. Change in "Fix" patch: Wrapped coordinator's stop calls into autorelease pools. Coordinator's dealloc calls API which uses thread checker. So thread bundle has to outlive coordinator. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I59b6aba677934c6abb43da36a9f94e00c4ca361b Reviewed-on: https://chromium-review.googlesource.com/966969 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#544161} [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/download/BUILD.gn [add] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/download/download_manager_metric_names.cc [add] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/installation_notifier.mm [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/installation_notifier_unittest.mm [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/4450e677e147f5d05d205be2f21653a1f9154951/ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7a8a0080811cdc2cb263ea76789456e095759ee commit d7a8a0080811cdc2cb263ea76789456e095759ee Author: Eugene But <eugenebut@google.com> Date: Tue Mar 20 20:57:47 2018 Log MobileDownloadRetryDownload for New Download Manager. This is an existing action logged for the Old Download Manager which is already defined in a private repository. This CL adds action to actions.xml. MobileDownloadRetryDownload will be removed from private repository in a separate CL. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I279d088a1996f79e9d21af04f51b1e03a08be162 Reviewed-on: https://chromium-review.googlesource.com/965167 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544515} [modify] https://crrev.com/d7a8a0080811cdc2cb263ea76789456e095759ee/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/d7a8a0080811cdc2cb263ea76789456e095759ee/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/d7a8a0080811cdc2cb263ea76789456e095759ee/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e730be12cf3b77a9ac3d8e84ae13421b76d1188f commit e730be12cf3b77a9ac3d8e84ae13421b76d1188f Author: Eugene But <eugenebut@google.com> Date: Wed Mar 21 02:49:11 2018 Add MobileDownloadFileUIShown UMA to New Download Manager. This is an existing action logged for the Old Download Manager which is already defined in a private repository. This CL adds action to actions.xml. MobileDownloadRetryDownload will be removed from private repository in a separate CL. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5e4d8d057e245bd8c89471a46e0db4f0c4c93614 Reviewed-on: https://chromium-review.googlesource.com/965241 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544626} [modify] https://crrev.com/e730be12cf3b77a9ac3d8e84ae13421b76d1188f/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/e730be12cf3b77a9ac3d8e84ae13421b76d1188f/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/e730be12cf3b77a9ac3d8e84ae13421b76d1188f/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e commit 6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e Author: Eugene But <eugenebut@google.com> Date: Wed Mar 21 17:18:40 2018 Add Download.IOSDownloadedFileAction UMA to New Download Manager. This is an existing histogram logged for the Old Download Manager. The histogram is already a part of histograms.xml file. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I13a650e612384d9ba3c026fd7e80d3275c2525ae Reviewed-on: https://chromium-review.googlesource.com/971805 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544749} [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/browser/download/google_drive_app_util.h [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/browser/download/google_drive_app_util.mm [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/test/fakes/fake_document_interaction_controller.h [modify] https://crrev.com/6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e/ios/chrome/test/fakes/fake_document_interaction_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7450bde66f02522b12947fb7181a8d5e5e7883df commit 7450bde66f02522b12947fb7181a8d5e5e7883df Author: Eugene But <eugenebut@google.com> Date: Thu Mar 22 00:09:54 2018 Correctly respond to size class changes in Download Manager. Old code used IsCompactWidth() function inside viewWillTransitionToSize: callback to check the current size class. This is incorrect and would return previous size class instead of new size class. New code uses willTransitionToTraitCollection: instead, which provides correct new size class. Also download bar width for regular size class is now anchored to superview width with 0.6 multiplier. This is because anchoring to constant (what old code tried to do) would require more complex logic and is not really much better than anchoring to multiplier. Bug: 823698, 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ide994e3d76b773d20d462d782f370a0491009916 Reviewed-on: https://chromium-review.googlesource.com/973464 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544914} [modify] https://crrev.com/7450bde66f02522b12947fb7181a8d5e5e7883df/ios/chrome/browser/ui/download/download_manager_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/162c484a91d6fb5f59e0e4d2f6a8f9cea4e3c856 commit 162c484a91d6fb5f59e0e4d2f6a8f9cea4e3c856 Author: Eugene But <eugenebut@google.com> Date: Thu Mar 22 14:43:12 2018 Add Download.IOSDownloadFileResult UMA to New Download Manager. This is an existing histogram logged for the Old Download Manager. The histogram is already a part of histograms.xml file. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I93c0d84e91622654245b7dca88f06c5771e42b65 Reviewed-on: https://chromium-review.googlesource.com/973945 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545071} [modify] https://crrev.com/162c484a91d6fb5f59e0e4d2f6a8f9cea4e3c856/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/162c484a91d6fb5f59e0e4d2f6a8f9cea4e3c856/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/162c484a91d6fb5f59e0e4d2f6a8f9cea4e3c856/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f363f54c3067435d1d10e1ea22cad5e887a7a28a commit f363f54c3067435d1d10e1ea22cad5e887a7a28a Author: Eugene But <eugenebut@chromium.org> Date: Mon Mar 26 02:07:51 2018 Add Download.IOSDownloadedFileNetError to New Download Manager. This is an existing histogram logged for the Old Download Manager. The histogram is already a part of histograms.xml file. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I720221f6a5b395d947a96a99ce7e4d6fe7bee09e Reviewed-on: https://chromium-review.googlesource.com/979267 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545722} [modify] https://crrev.com/f363f54c3067435d1d10e1ea22cad5e887a7a28a/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/f363f54c3067435d1d10e1ea22cad5e887a7a28a/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10f365560ec726662c46816995b73ef2ecb340ac commit 10f365560ec726662c46816995b73ef2ecb340ac Author: Eugene But <eugenebut@google.com> Date: Tue Mar 27 16:08:39 2018 Added 'Not Started' to DownloadFileResult histogram. This histogram is logged when the user closes Download Manager UI without starting the download. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e7912e312b1eccbb839207160ed82cbb3d95577 Reviewed-on: https://chromium-review.googlesource.com/981461 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#546124} [modify] https://crrev.com/10f365560ec726662c46816995b73ef2ecb340ac/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/10f365560ec726662c46816995b73ef2ecb340ac/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/10f365560ec726662c46816995b73ef2ecb340ac/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/10f365560ec726662c46816995b73ef2ecb340ac/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/047dd9ffffb66677b21f28e0a864062321f38531 commit 047dd9ffffb66677b21f28e0a864062321f38531 Author: Eugene But <eugenebut@google.com> Date: Tue Mar 27 23:46:48 2018 Updated MobileDownloadFileUIInstallGoogleDrive metric usage. 1.) Removed constant to allow presubmit warnings for missing metrics 2.) Added metric to actions.xml (this is existing metric but it was defined in close source internal repository). Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3a35962cbde10d12b260c7575b1a3bf97af9c76c Reviewed-on: https://chromium-review.googlesource.com/981329 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#546320} [modify] https://crrev.com/047dd9ffffb66677b21f28e0a864062321f38531/ios/chrome/browser/download/BUILD.gn [delete] https://crrev.com/bfd138a0d51fe3582b3e127561cc791c01460546/ios/chrome/browser/download/download_manager_metric_names.cc [modify] https://crrev.com/047dd9ffffb66677b21f28e0a864062321f38531/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/047dd9ffffb66677b21f28e0a864062321f38531/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/047dd9ffffb66677b21f28e0a864062321f38531/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/047dd9ffffb66677b21f28e0a864062321f38531/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c21e8ad00aa5dc1e48d5beca81cf0c21c9d5b35 commit 5c21e8ad00aa5dc1e48d5beca81cf0c21c9d5b35 Author: Eugene But <eugenebut@google.com> Date: Wed Mar 28 14:50:39 2018 Use Roboto 14 font for New Download Manager UI. This font matches Download Manager specs: https://goto.google.com/ios-chrome-download-manager-specs Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I51bea1e369f670ae6d4045c6716efad012e1d41d Reviewed-on: https://chromium-review.googlesource.com/982571 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#546484} [modify] https://crrev.com/5c21e8ad00aa5dc1e48d5beca81cf0c21c9d5b35/ios/chrome/browser/ui/download/download_manager_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/717f5bac923b2766e42fb736758d67930914e2e5 commit 717f5bac923b2766e42fb736758d67930914e2e5 Author: Eugene But <eugenebut@google.com> Date: Wed Mar 28 19:21:57 2018 Add Download.IOSDownloadReplaced UMA to New Download Manager. This histogram is the result of user's response to "Start New Download?" prompt where the user can replace existing download with a new one. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id25e87787bbeaea7b529d7c24df290b4eb4d5a11 Reviewed-on: https://chromium-review.googlesource.com/981452 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#546559} [modify] https://crrev.com/717f5bac923b2766e42fb736758d67930914e2e5/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/717f5bac923b2766e42fb736758d67930914e2e5/tools/metrics/histograms/enums.xml [modify] https://crrev.com/717f5bac923b2766e42fb736758d67930914e2e5/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9185fdf5daccc41080acf8a10876349359e027f commit d9185fdf5daccc41080acf8a10876349359e027f Author: Eugene But <eugenebut@google.com> Date: Thu Mar 29 18:56:31 2018 Layout install google drive controls with main download controls. Drive icon x center is anchored to status icon center x. Drive label leading is anchored to status label leading. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0ba004c83d59f34c80fcbc6c11757e313a7c3945 Reviewed-on: https://chromium-review.googlesource.com/985233 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546908} [modify] https://crrev.com/d9185fdf5daccc41080acf8a10876349359e027f/ios/chrome/browser/ui/download/download_manager_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f52470bf3ee6cbe7f657d241b26209588797a7e5 commit f52470bf3ee6cbe7f657d241b26209588797a7e5 Author: Eugene But <eugenebut@google.com> Date: Mon Apr 02 21:36:52 2018 Updated Download.IOSDownloadedFileAction histogram value name and comments. iOS apps are not notified if the user opened a file in Extension via Open In.. menu. So the old metric name (No action) was not correct, because this value was reported if the user discarded download or opened in extension. This CL renames the enum and histogram values to "No action or opened via extension". Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6eea112f9016a46a3a91d094e4dd1b1364b20c2e Reviewed-on: https://chromium-review.googlesource.com/986714 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547523} [modify] https://crrev.com/f52470bf3ee6cbe7f657d241b26209588797a7e5/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/f52470bf3ee6cbe7f657d241b26209588797a7e5/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/f52470bf3ee6cbe7f657d241b26209588797a7e5/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/f52470bf3ee6cbe7f657d241b26209588797a7e5/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21163e5d5d12a56b70b6fb3c6b4534aca85330a5 commit 21163e5d5d12a56b70b6fb3c6b4534aca85330a5 Author: Eugene But <eugenebut@google.com> Date: Wed Apr 04 02:03:27 2018 Add Download.IOSDownloadFileInBackground UMA. This histogram will help to understand how many downloads are failed because the user quit the app as well as how many downloads were performed while the app was inactive. CanceledAfterAppQuit metric will be logged in a separate CL (crrev.com/987200). Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8d2d07159a178373038479a3189feaf7a93cf57f Reviewed-on: https://chromium-review.googlesource.com/981327 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547947} [modify] https://crrev.com/21163e5d5d12a56b70b6fb3c6b4534aca85330a5/ios/chrome/browser/download/download_manager_metric_names.h [modify] https://crrev.com/21163e5d5d12a56b70b6fb3c6b4534aca85330a5/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/21163e5d5d12a56b70b6fb3c6b4534aca85330a5/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm [modify] https://crrev.com/21163e5d5d12a56b70b6fb3c6b4534aca85330a5/tools/metrics/histograms/enums.xml [modify] https://crrev.com/21163e5d5d12a56b70b6fb3c6b4534aca85330a5/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a20aba046d9ec4249af811c2795b5262a0f25c8 commit 2a20aba046d9ec4249af811c2795b5262a0f25c8 Author: Eugene But <eugenebut@google.com> Date: Mon Apr 09 17:26:30 2018 Pixel perfect UI according to Download Manager specs. This CL changes the distance between controls and UI edges. Specs: https://goto.google.com/ios-chrome-download-manager-specs Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibabcc6f7b0626814ce15e8e3da67e3f630feb3c8 Reviewed-on: https://chromium-review.googlesource.com/999046 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549211} [modify] https://crrev.com/2a20aba046d9ec4249af811c2795b5262a0f25c8/ios/chrome/browser/ui/download/download_manager_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea6e1be5006363d639c37ee16a7bae7ad49d1517 commit ea6e1be5006363d639c37ee16a7bae7ad49d1517 Author: Eugene But <eugenebut@chromium.org> Date: Fri Aug 10 18:44:48 2018 Clean up Legacy Download Manager code. New Download Manager was shipped to 100% users in M68 and enabled by default. Bug: 791806 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccbc05ba0aeb90449518cea1ddb4422fff8eab3c Reviewed-on: https://chromium-review.googlesource.com/1170128 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582265} [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/app/main_controller.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/download/browser_download_service.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/download/browser_download_service_unittest.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/prerender/preload_controller.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/ui/download/BUILD.gn [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/ui/download/download_manager_egtest.mm [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/legacy_download_manager_controller.h [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/legacy_download_manager_controller.mm [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/legacy_download_manager_controller_unittest.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/chrome/browser/ui/download/resources/BUILD.gn [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/DownloadManagerController.xib [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/error_icon.imageset/Contents.json [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/error_icon.imageset/error_icon.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/error_icon.imageset/error_icon@2x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/error_icon.imageset/error_icon@3x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_body.imageset/Contents.json [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_body.imageset/file_icon_body.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_body.imageset/file_icon_body@2x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_body.imageset/file_icon_body@3x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/Contents.json [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/file_icon_fold.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/file_icon_fold@2x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/file_icon_fold@3x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/Contents.json [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/file_icon_fold_complete.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/file_icon_fold_complete@2x.png [delete] https://crrev.com/43cfa30f7b03a216265f767dc281afca4eb36e7e/ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/file_icon_fold_complete@3x.png [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/web/features.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/web/public/features.h [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/web/public/test/fakes/test_native_content_provider.mm [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/web/public/web_state/ui/crw_native_content_provider.h [modify] https://crrev.com/ea6e1be5006363d639c37ee16a7bae7ad49d1517/ios/web/web_state/ui/crw_web_controller.mm
Comment 1 by eugene...@chromium.org
, Dec 5 2017Status: Assigned (was: Available)