New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791803 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ xunji...@chromium.org
eroman@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove use of jstemplate from net_internals

Project Member Reported by eroman@chromium.org, Dec 5 2017 
There are two copies of NetInternals:
  * NetLog viewer in Catapult repo
  * net_internals in Chromium repo

Merges from Chromium --> Catapult cannot be done simply, as most edits happening in the Chromium copy are to quic_view.html, which makes use of jstemplate. The Catapult version however has removed the dependency on jstemplate.

As long as there are multiple copies of the net log viewer, it would be an advantage to keep them in sync.

Comment 1 by mmenke@chromium.org, Dec 6 2017 

I assume there was a reason not to have the catapult code use jstemplate?  While it's not perfect, I think it made updating tables much simpler than what we had before.

Comment 2 by eroman@chromium.org, Dec 6 2017 

Catapult OWNERS didn't want jstemplate in the repo.

The accepted hotness in Catapult is Polymer, which has its own templating system.

Comment 3 by dpa...@chromium.org, Jun 6 2018 

Note that depending on jstemplate is also forcing to relax the CSP to allow eval/Function, which is yet another reason to move away from it. This is a larger problem with various WebUI pages.

Comment 4 by eroman@chromium.org, Jun 6 2018

Status: Available (was: Untriaged)
►

Sign in to add a comment