New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791802 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Left Chrome team
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Record Swap data for Android

Project Member Reported by mariakho...@chromium.org, Dec 4 2017

Issue description

For memory ablation we want to evaluate whether we're pushing more data (and the amount of data) into swap. Add a UMA/UKM metric to report the current swap value.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7499f4f995258b30930956a02855bcaf88a34c09

commit 7499f4f995258b30930956a02855bcaf88a34c09
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Dec 06 23:45:00 2017

Add a metric to record private swap size.

The new metric is called PrivateSwapFootprint. It records the value
of VmSwap from /proc/<pid>/status and is available only on Linux and
Android. This metric is useful for evaluating changes in swap use with
memory ablation.

BUG= 791802 

Change-Id: Ica436198fd00d85cd5f5896ce994547a73aea27f
Reviewed-on: https://chromium-review.googlesource.com/807358
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522256}
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/7499f4f995258b30930956a02855bcaf88a34c09/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Assigned)
Labels: ReleaseBlock-Stable Merge-Request-64
Status: Assigned (was: Fixed)
Asking for merge into 64. We need this metric to evaluate memory experiments and it just missed the branch.
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 9 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd374b448018eeaba1644136c09d0f25dd3fa208

commit dd374b448018eeaba1644136c09d0f25dd3fa208
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Dec 13 18:35:46 2017

Add a metric to record private swap size.

The new metric is called PrivateSwapFootprint. It records the value
of VmSwap from /proc/<pid>/status and is available only on Linux and
Android. This metric is useful for evaluating changes in swap use with
memory ablation.

BUG= 791802 

Change-Id: Ica436198fd00d85cd5f5896ce994547a73aea27f
Reviewed-on: https://chromium-review.googlesource.com/807358
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522256}(cherry picked from commit 7499f4f995258b30930956a02855bcaf88a34c09)
Reviewed-on: https://chromium-review.googlesource.com/825283
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#208}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/dd374b448018eeaba1644136c09d0f25dd3fa208/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Assigned)

Sign in to add a comment