Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 79180 [css-grid] Implement CSS Grid Layout
Starred by 92 users Reported by priyaj...@gmail.com, Apr 12 2011 Back to list
Status: Fixed
Owner:
Closed: Feb 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on: View detail
issue 229568
issue 234199
issue 234206
issue 273898
issue 511177
issue 555027
issue 599042
issue 613289
issue 614667
issue 618969
issue 622915
issue 666940
issue 666961
issue 667785
issue 685609
issue 687494
issue 688640
issue 161565
issue 225778
issue 225892
issue 226263
issue 229713
issue 231695
issue 231867
issue 234183
issue 234189
issue 234191
issue 234192
issue 234195
issue 234197
issue 234200
issue 234203
issue 234204
issue 234205
issue 234207
issue 234208
issue 234209
issue 234210
issue 234211
issue 234212
issue 234213
issue 235258
issue 240317
issue 240319
issue 243132
issue 245878
issue 251446
issue 252106
issue 257078
issue 258092
issue 258258
issue 266745
issue 271525
issue 275111
issue 276490
issue 277819
issue 282452
issue 297158
issue 297689
issue 313215
issue 313293
issue 317742
issue 331531
issue 337626
issue 337779
issue 338478
issue 353789
issue 357419
issue 384099
issue 391482
issue 392200
issue 395788
issue 401463
issue 401471
issue 401477
issue 401479
issue 402757
issue 407086
issue 407089
issue 408989
issue 409085
issue 410275
issue 412715
issue 418614
issue 422980
issue 423743
issue 425001
issue 426778
issue 426898
issue 427481
issue 430099
issue 430100
issue 433156
issue 435028
issue 436445
issue 437354
issue 442954
issue 443042
issue 444011
issue 444056
issue 448371
issue 449130
issue 452135
issue 455724
issue 457849
issue 458573
issue 463079
issue 463847
issue 464287
issue 482894
issue 483473
issue 485085
issue 485984
issue 487995
issue 490043
issue 490088
issue 505846
issue 510061
issue 520477
issue 521407
issue 528609
issue 529203
issue 530476
issue 530504
issue 532032
issue 538513
issue 539811
issue 544112
issue 544539
issue 547762
issue 550434
issue 556155
issue 556171
issue 557256
issue 558789
issue 560771
issue 560872
issue 561999
issue 562167
issue 562458
issue 562985
issue 563400
issue 566265
issue 568882
issue 570322
issue 575182
issue 578787
issue 579104
issue 582230
issue 583215
issue 583344
issue 583743
issue 585150
issue 587641
issue 588065
issue 589460
issue 592975
issue 596672
issue 600680
issue 602670
issue 603160
issue 603854
issue 611407
issue 611410
issue 612755
issue 613354
issue 614314
issue 615248
issue 616716
issue 617876
issue 618664
issue 618970
issue 618971
issue 618972
issue 619567
issue 619629
issue 619930
issue 624301
issue 624716
issue 627812
issue 628155
issue 628565
issue 633474
issue 641982
issue 643359
issue 648814
issue 653433
issue 654712
issue 654737
issue 654739
issue 654904
issue 655390
issue 656371
issue 660675
issue 660690
issue 666688
issue 667057
issue 681046
issue 681381
issue 687184
issue 692754



Sign in to add a comment
Implement CSS Grid Alignment
http://ie.microsoft.com/testdrive/HTML5/GridSystem/Default.html
http://www.interoperabilitybridges.com/css3-grid-align/

I couldn't find a bug/feature associated with this: https://bugs.webkit.org/show_bug.cgi?id=58349
Please close/merge if it's being tracked somewhere else or intentions are not to implement.

 
Comment 1 by kareng@google.com, May 5 2011
Owner: mikelawther@chromium.org
Status: Assigned
Comment 2 by kareng@google.com, May 5 2011
Labels: Mstone-X
I think this is mstone X but please feel free to move up if u see fit.
There is a new version of the spec:
http://www.w3.org/TR/css3-grid-layout/
It will probably replace css3-layout and css3-grid.
Cc: ojan@chromium.org tony@chromium.org mikelawther@chromium.org
Labels: -WebKit-Core -Mstone-X WebKit-Rendering WebKit-ID-60731
Owner: jchaffraix@chromium.org
Summary: Implement CSS Grid Layout (was: NULL)
An early implementation started in WebKit early this year but stalled due to the specification being ironed out. We have reached a point where it should be safe to resume the effort.

Umbrella bug for the feature in WebKit: https://bugs.webkit.org/show_bug.cgi?id=60731
Blockedon: chromium:161565
Project Member Comment 8 by bugdroid1@chromium.org, Nov 19 2012
Labels: WebKit-Rev-135164
http://trac.webkit.org/changeset/135164
Project Member Comment 9 by bugdroid1@chromium.org, Nov 28 2012
Labels: WebKit-Rev-135965
http://trac.webkit.org/changeset/135965
Project Member Comment 10 by bugdroid1@chromium.org, Dec 4 2012
Labels: WebKit-Rev-136465
http://trac.webkit.org/changeset/136465
Project Member Comment 11 by bugdroid1@chromium.org, Dec 13 2012
Labels: WebKit-Rev-137560
http://trac.webkit.org/changeset/137560
Project Member Comment 12 by bugdroid1@chromium.org, Jan 17 2013
Labels: WebKit-Rev-140045
http://trac.webkit.org/changeset/140045
Project Member Comment 13 by bugdroid1@chromium.org, Jan 22 2013
Labels: WebKit-Rev-140480
http://trac.webkit.org/changeset/140480
Labels: -WebKit-Rev-120984 -WebKit-Rev-100389 -WebKit-Rev-101288 -WebKit-Rev-100546 -WebKit-Rev-117613 -WebKit-Rev-122747 -WebKit-Rev-124671 -WebKit-Rev-134935 -WebKit-Rev-135164 -WebKit-Rev-135965 -WebKit-Rev-136465 -WebKit-Rev-137560 -WebKit-Rev-140045 -WebKit-Rev-140480 webkitbot-statusonly
Adding a label to avoid the webkit-bot spam and removing the revisions. If you want to follow these updates, you can always CC yourself to https://bugs.webkit.org/show_bug.cgi?id=60731. Sorry for the noise.
Project Member Comment 15 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-WebKit -WebKit-Rendering Cr-Content-Rendering Cr-Content
Project Member Comment 16 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content Cr-Blink
Project Member Comment 17 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Rendering Cr-Blink-Rendering
Blockedon: chromium:235258
Blockedon: chromium:240317 chromium:240319
Blockedon: chromium:245878
Blockedon: chromium:249451 chromium:249453
Blockedon: chromium:251446
Comment 26 by svil...@igalia.com, Jun 20 2013
Blockedon: chromium:252106
Blockedon: chromium:257078
Blockedon: chromium:258092
Blockedon: chromium:271525
Blockedon: chromium:273898
Blocking: chromium:266745
Blocking: chromium:275111
Blocking: chromium:276490
Blockedon: chromium:276490
Blockedon: chromium:266745 chromium:275111
Blocking: -chromium:276490
Blocking: -chromium:275111
Blocking: -chromium:266745
Comment 40 by svil...@igalia.com, Aug 30 2013
Blockedon: chromium:282452
Blockedon: chromium:297158
Comment 42 by svil...@igalia.com, Sep 24 2013
Blockedon: chromium:297689
Comment 43 by svil...@igalia.com, Oct 30 2013
Blockedon: chromium:313215
Project Member Comment 44 by bugdroid1@chromium.org, Nov 13 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=161876

------------------------------------------------------------------------
r161876 | jchaffraix@chromium.org | 2013-11-13T06:54:56.909336Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-min-max-height-expected.txt?r1=161876&r2=161875&pathrev=161876
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderGrid.cpp?r1=161876&r2=161875&pathrev=161876
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-min-max-height.html?r1=161876&r2=161875&pathrev=161876

Handle min-height / max-height on the grid element

This was already working so removed a FIXME
about it and added some testing.

BUG= 79180 

Review URL: https://codereview.chromium.org/66033012
------------------------------------------------------------------------
Blockedon: chromium:331531
Comment 46 by tony@chromium.org, Jan 6 2014
Cc: -tony@chromium.org
Comment 47 by svil...@igalia.com, Jan 24 2014
Blockedon: chromium:337779
Blockedon: chromium:243132 chromium:338478
Comment 49 by svil...@igalia.com, Jan 30 2014
Blockedon: chromium:337626
Project Member Comment 50 by bugdroid1@chromium.org, Mar 6 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168573

------------------------------------------------------------------------
r168573 | jfernandez@igalia.com | 2014-03-06T04:25:06.516111Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit-expected.txt?r1=168573&r2=168572&pathrev=168573
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderGrid.cpp?r1=168573&r2=168572&pathrev=168573
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html?r1=168573&r2=168572&pathrev=168573
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderGrid.h?r1=168573&r2=168572&pathrev=168573

[CSS Grid Layout] Use Render methods, rather than style, to
 determine shrink-to-fit behavior

In order to determine whether the RemainingSpace is 
undetermined or not (shrink-to-fit) the current algorithm 
is checking out the style for clarifying if the Render object 
is float or absolute positioned.

It's better to use the Render functions instead, since the 
style might be applied or not, depending on several factors, 
like CSS properties inheritance.

BUG= 79180 ,  234204 

Review URL: https://codereview.chromium.org/181333003
------------------------------------------------------------------------
Project Member Comment 51 by bugdroid1@chromium.org, Mar 10 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168832

------------------------------------------------------------------------
r168832 | jfernandez@igalia.com | 2014-03-10T11:58:39.102024Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-position-changed-dynamic.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/should-not-collapse-anonymous-blocks.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/implicit-columns-auto-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/auto-content-resolution-columns.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/whitespace-in-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-change-order-auto-flow.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/flex-content-resolution-rows.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-strict-ordering-crash.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-addition-track-breadth-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-min-content-column-resolution-rows.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-change-row-repaint.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/auto-content-resolution-rows.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-indexes.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-display.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/containing-block-grids.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-width-only.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-empty-row-column.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/implicit-rows-auto-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-order-paint-order.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-min-content-column-resolution-columns.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-rows.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-min-max-width.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-change-column-repaint.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/floating-empty-grids.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-order-auto-flow-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-border-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-get-set.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-border-padding-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-removal-track-breadth-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/whitespace-in-grid-item-expected.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/place-cell-by-index.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/percent-resolution-grid-item.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-update.html?r1=168832&r2=168831&pathrev=168832
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html?r1=168832&r2=168831&pathrev=168832

[CSS Grid Layout] Remove legacy WebKitCSSGridLayoutEnabled 
flag from the Layout Tests.

Most of the layout tests come form WebKit codebase before
the fork, so they still have many legacy and unneeded bits.

This patch removes the WebKitCSSGridLayoutEnabled flag 
setting by the testRunner.

BUG= 79180 

Review URL: https://codereview.chromium.org/180523004
------------------------------------------------------------------------
Comment 52 by svil...@igalia.com, Mar 19 2014
Blockedon: chromium:353789
Comment 53 by svil...@igalia.com, Mar 28 2014
Blockedon: chromium:357419
Project Member Comment 54 by bugdroid1@chromium.org, Mar 28 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=170318

------------------------------------------------------------------
r170318 | jfernandez@igalia.com | 2014-03-28T12:14:56.519557Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout.html?r1=170318&r2=170317&pathrev=170318
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout-expected.txt?r1=170318&r2=170317&pathrev=170318
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=170318&r2=170317&pathrev=170318

[CSS Grid Layout] the "grid-template-areas" is not identified as computable property.

The "grid-template-areas" property is a computable area, defined in the
CSSComputedStyleDeclaration class with an specific computed value. However,
it's not shown by the Web Inspector in the corresponding Computed tab.

It seems that the root cause of this issue is that the property is not
present in the CSSComputedStyleDeclaration::staticComputableProperties.


BUG= 79180 

Review URL: https://codereview.chromium.org/200263003
-----------------------------------------------------------------
Project Member Comment 55 by bugdroid1@chromium.org, Apr 1 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=170552

------------------------------------------------------------------
r170552 | jfernandez@igalia.com | 2014-04-01T11:48:54.554324Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleBuilderCustom.cpp?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPropertyNames.in?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.cpp?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuntimeCSSEnabled.cpp?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSShorthands.in?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.h?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=170552&r2=170551&pathrev=170552
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParserValues.h?r1=170552&r2=170551&pathrev=170552
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt?r1=170552&r2=170551&pathrev=170552
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/resources/grid-template-shorthand-parsing-utils.js?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperty.cpp?r1=170552&r2=170551&pathrev=170552
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.cpp?r1=170552&r2=170551&pathrev=170552

[CSS Grid Layout] Implementation of the grid-template shorthand.

This shorthand sets the values for the grid-template-columns, 
grid-template-rows and grid-template-areas, so the 
implementation tries to reuse as much available parsing 
functions as possible.

The "parsingGridTrackList" was refactored to return a 
CSSValue and let the "parseValue" function to assign the 
property value. The "forwardSlash" operator is now valid 
when the track-list clause is part of a shorthand. The  
"parseValue" function checkouts that only additional 
clauses are allowed when processing shorthands; the 
grid-columns-rows-get-set.html tests was modified to verify 
this.

The "parseGridTemplateAreas" was refactored too, in order 
to process single areas's rows. This is very useful for the 
gris-template secondary syntax, which mixes areas and rows 
values.


Finally, the "parseGirdLineNames" function was modified as 
well by defining an new argument to concatenate head/tail 
custom-ident elements and ensure the identList is at the 
heading index, since it's now possible the parseList was 
rewound.

The implementation of the grid-template shorthand tries 
first to match the <grid-template-columns> / <grid-template-rows> 
syntax, failing back to the secondary syntax if needed. 
This approach requires to rewind the parseList but it 
produces a clearer code.
 
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

BUG= 79180 

Review URL: https://codereview.chromium.org/149373004
-----------------------------------------------------------------
Project Member Comment 56 by bugdroid1@chromium.org, Apr 9 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171143

------------------------------------------------------------------
r171143 | jfernandez@igalia.com | 2014-04-09T13:59:58.261913Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSShorthands.in?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.h?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperty.cpp?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.cpp?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=171143&r2=171142&pathrev=171143
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt?r1=171143&r2=171142&pathrev=171143
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/resources/grid-shorthand-parsing-utils.js?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleBuilderCustom.cpp?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPropertyNames.in?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.cpp?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuntimeCSSEnabled.cpp?r1=171143&r2=171142&pathrev=171143
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html?r1=171143&r2=171142&pathrev=171143
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt?r1=171143&r2=171142&pathrev=171143

[CSS Grid Layout] Implementation of the grid shorthand.

The grid property is a shorthand that sets all of the explicit
grid properties (grid-template-rows, grid-template-columns, and 
grid-template-areas) as well as all the implicit grid properties
(grid-auto-rows, grid-auto-columns, and grid-auto-flow) in a
single declaration

Notice that either explicit or implicit grid can be specified,
assigning the initial values to the omitted properties.

BUG= 79180 

Review URL: https://codereview.chromium.org/176853007
-----------------------------------------------------------------
Project Member Comment 57 by bugdroid1@chromium.org, Apr 30 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173031

------------------------------------------------------------------
r173031 | jfernandez@igalia.com | 2014-04-30T21:25:37.954322Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions-expected.txt?r1=173031&r2=173030&pathrev=173031
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html?r1=173031&r2=173030&pathrev=173031
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.cpp?r1=173031&r2=173030&pathrev=173031

Clamping the number of repetitions when using the repeat() function.

The ED suggests now to be able to clamp the number of repetitions when
using the repeat() function, taking precautions about excessive memory
usage.

BUG= 79180 

Review URL: https://codereview.chromium.org/251643002
-----------------------------------------------------------------
Project Member Comment 58 by bugdroid1@chromium.org, May 22 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174600

------------------------------------------------------------------
r174600 | jfernandez@igalia.com | 2014-05-22T22:04:24.105648Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt?r1=174600&r2=174599&pathrev=174600
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html?r1=174600&r2=174599&pathrev=174600
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/resources/display-grid-set-get.js?r1=174600&r2=174599&pathrev=174600

New test cases for the display-grid-set-get.html test.

If an element’s specified display is inline-grid and the
element is floated or absolutely positioned, the computed
value of display is grid.

BUG= 79180 

Review URL: https://codereview.chromium.org/264373005
-----------------------------------------------------------------
Project Member Comment 59 by bugdroid1@chromium.org, May 23 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174607

------------------------------------------------------------------
r174607 | jfernandez@igalia.com | 2014-05-23T00:17:46.838556Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution-expected.txt?r1=174607&r2=174606&pathrev=174607
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html?r1=174607&r2=174606&pathrev=174607

New tests case for verifying not sized template-areas use auto-{columns,rows}.

Any rows/columns defined by grid-template-areas but not sized by 
grid-template-rows/grid-template-columns take their size from the 
grid-auto-rows/grid-auto-columns properties.

BUG= 79180 

Review URL: https://codereview.chromium.org/278543003
-----------------------------------------------------------------
Project Member Comment 60 by bugdroid1@chromium.org, May 23 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174620

------------------------------------------------------------------
r174620 | jfernandez@igalia.com | 2014-05-23T00:44:10.955409Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse-expected.html?r1=174620&r2=174619&pathrev=174620
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html?r1=174620&r2=174619&pathrev=174620

New Layout Tests to verify grid container's margin don't collapse.

BUG= 79180 

Review URL: https://codereview.chromium.org/273643008
-----------------------------------------------------------------
Project Member Comment 61 by bugdroid1@chromium.org, May 28 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174931

------------------------------------------------------------------
r174931 | jfernandez@igalia.com | 2014-05-28T05:22:34.223296Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt?r1=174931&r2=174930&pathrev=174931
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html?r1=174931&r2=174930&pathrev=174931

New Layout Test to verify 'float' and 'cleat' don't affect grid's items.

BUG= 79180 

Review URL: https://codereview.chromium.org/273893002
-----------------------------------------------------------------
Comment 62 by r...@igalia.com, Jun 12 2014
Blockedon: chromium:384099
Comment 63 by r...@igalia.com, Jul 4 2014
Blockedon: chromium:391482
Comment 64 by r...@igalia.com, Jul 14 2014
Blockedon: chromium:392200
Comment 65 by r...@igalia.com, Aug 6 2014
Blockedon: chromium:395788
Labels: Cr-Blink-Rendering-Grid
Comment 68 by ojan@chromium.org, Oct 16 2014
Cc: -ojan@chromium.org
Comment 69 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:418614
Cc: r...@igalia.com svil...@igalia.com jfernan...@igalia.com
Comment 70 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:317742
Comment 71 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:313293
Please consider blocking on bug 423743
Comment 73 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:231867
Comment 74 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:407089
Comment 75 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:423743
Comment 76 by r...@igalia.com, Oct 16 2014
Blockedon: chromium:407086
Comment 77 by r...@igalia.com, Oct 20 2014
Blockedon: chromium:425001
Comment 78 by svil...@igalia.com, Oct 24 2014
Blockedon: chromium:426778
Comment 79 by r...@igalia.com, Oct 27 2014
Blockedon: chromium:427481
Comment 80 by r...@igalia.com, Nov 4 2014
Blockedon: chromium:430099
Blockedon: chromium:430100
Comment 82 by r...@igalia.com, Nov 27 2014
Blockedon: chromium:433156
Comment 83 by r...@igalia.com, Nov 27 2014
Blockedon: chromium:437354
Comment 84 by r...@igalia.com, Dec 16 2014
Blockedon: chromium:442954
Comment 85 by r...@igalia.com, Dec 19 2014
Blockedon: chromium:443042
Comment 86 by r...@igalia.com, Dec 19 2014
Blockedon: chromium:444011
Comment 87 by r...@igalia.com, Dec 22 2014
Blockedon: chromium:444056
Blockedon: -chromium:234194
Comment 89 by r...@igalia.com, Jan 9 2015
Blockedon: chromium:436445
Labels: -Cr-Blink-Rendering-Grid Cr-Blink-Layout-Grid
Migrate from Cr-Blink-Rendering-Grid to Cr-Blink-Layout-Grid
Labels: -Cr-Blink-Rendering Cr-Blink-Layout
Migrate from Cr-Blink-Rendering to Cr-Blink-Layout
Blockedon: chromium:448371
Comment 93 by svil...@igalia.com, Jan 15 2015
Blockedon: chromium:449130
Comment 94 by r...@igalia.com, Jan 27 2015
Blockedon: chromium:452135
Blockedon: chromium:455724
Comment 96 by r...@igalia.com, Feb 12 2015
Blockedon: chromium:457849
Please consider blocking on bug 458573
Comment 98 by r...@igalia.com, Feb 16 2015
Blockedon: chromium:458573
Project Member Comment 99 by bugdroid1@chromium.org, Feb 26 2015
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190936

------------------------------------------------------------------
r190936 | shivamidow@gmail.com | 2015-02-26T17:34:37.437826Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutGrid.cpp?r1=190936&r2=190935&pathrev=190936
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFlexibleBox.cpp?r1=190936&r2=190935&pathrev=190936
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Position.cpp?r1=190936&r2=190935&pathrev=190936
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt?r1=190936&r2=190935&pathrev=190936
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBox.h?r1=190936&r2=190935&pathrev=190936
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/key-events-in-editable-gridbox.html?r1=190936&r2=190935&pathrev=190936

Div having contentEditable and display:grid cannot be edited if it is empty.

This bug is quite similar to https://codereview.chromium.org/897633002/.
RenderGrid should be also treated as a candidate for visible position
as like RenderFlexibleBox. The only different situation between them is
that RenderGrid has a bug setting "0px" for logicalHeight when it is empty.
RenderGrid should also have a minimum height of a single line if it is editable
as well as RenderFlexibleBox does.
This is the same patch applied to webkit. http://webkit.org/b/141465

BUG= 79180 

Review URL: https://codereview.chromium.org/870013003
-----------------------------------------------------------------
Comment 100 by r...@igalia.com, Mar 4 2015
Blockedon: chromium:463847
Comment 101 by r...@igalia.com, Mar 4 2015
Blockedon: chromium:426898
Blockedon: chromium:463079
Blockedon: chromium:464287
Comment 104 by r...@igalia.com, Apr 30 2015
Blockedon: chromium:482894
Please review issue 483473 which appears to be a regression.
Comment 106 by r...@igalia.com, May 4 2015
Blockedon: chromium:483473
Comment 107 by r...@igalia.com, May 6 2015
Blockedon: chromium:485085
Comment 108 by r...@igalia.com, May 8 2015
Blockedon: chromium:485984
Blockedon: chromium:487995
Comment 110 by r...@igalia.com, May 20 2015
Blockedon: chromium:490043
Comment 111 by r...@igalia.com, May 20 2015
Blockedon: chromium:490088
Project Member Comment 112 by bugdroid1@chromium.org, Jun 12 2015
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=196983

------------------------------------------------------------------
r196983 | jfernandez@igalia.com | 2015-06-12T00:18:20.392519Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutGrid.cpp?r1=196983&r2=196982&pathrev=196983
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutGrid.h?r1=196983&r2=196982&pathrev=196983

[CSS Grid Layout] Refactoring of grid's alignment logic

After so many patches related to Box Alignment spec implmementation for
Grid Layout, it seems the code and logic ended up a bit complex and
confusing, overall when dealing with differetn writing modes and
directions.

This patch tries to simplify the codebase for implementing the alignment
logic in Grid Layout.

BUG= 79180 

Review URL: https://codereview.chromium.org/1125703002
-----------------------------------------------------------------
Blockedon: chromium:505846
Comment 114 by r...@igalia.com, Jul 14 2015
Blockedon: chromium:510061
Comment 115 by r...@igalia.com, Jul 17 2015
Blockedon: chromium:511177
Labels: Pri-2
Adding default Pri-2
Comment 117 by r...@igalia.com, Sep 1 2015
Blockedon: chromium:521407
Comment 118 by r...@igalia.com, Sep 1 2015
Blockedon: chromium:520477
Comment 119 by r...@igalia.com, Sep 7 2015
Blockedon: chromium:528609
Comment 120 by r...@igalia.com, Sep 8 2015
Blockedon: chromium:529203
Comment 121 by r...@igalia.com, Sep 11 2015
Blockedon: chromium:530476
Comment 122 by r...@igalia.com, Sep 11 2015
Blockedon: chromium:530504
Comment 123 by r...@igalia.com, Sep 15 2015
Blockedon: chromium:532032
Project Member Comment 124 by bugdroid1@chromium.org, Oct 1 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68a823dcd4e9c63a0d324bc96695fd010d734d87

commit 68a823dcd4e9c63a0d324bc96695fd010d734d87
Author: jfernandez <jfernandez@igalia.com>
Date: Thu Oct 01 14:37:28 2015

[CSS Grid Layout] Implement auto-margins alignment of grid items

The Grid Layout spec states that we must center items with auto margins,
so it will absorb any positive free space, both horiontal and vertical.

https://drafts.csswg.org/css-grid/#auto-margins

Besides, auto-margins imply that any alignment property in the same axis
will have no effect

BUG= 79180 , 249451, 376823

Review URL: https://codereview.chromium.org/1298623002

Cr-Commit-Position: refs/heads/master@{#351796}

[add] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-expected.txt
[add] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr-expected.txt
[add] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html
[add] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl-expected.txt
[add] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl.html
[add] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment.html
[modify] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-and-stretch.html
[modify] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] http://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87/third_party/WebKit/Source/core/layout/LayoutGrid.h

Comment 125 by r...@igalia.com, Oct 2 2015
Blockedon: chromium:538513
Comment 126 by r...@igalia.com, Oct 6 2015
Blockedon: chromium:539811
Blockedon: chromium:544112
Blockedon: chromium:547762
Comment 129 by r...@igalia.com, Nov 4 2015
Blockedon: chromium:544539
Labels: -Cr-Blink -Cr-Blink-Layout
Owner: r...@igalia.com
Comment 131 by r...@igalia.com, Nov 9 2015
Blockedon: chromium:435028
Comment 133 by r...@igalia.com, Nov 18 2015
Blockedon: chromium:557256
Comment 134 by r...@igalia.com, Nov 18 2015
Blockedon: chromium:557254
Comment 135 by r...@igalia.com, Nov 24 2015
Blockedon: chromium:560771
Comment 136 by r...@igalia.com, Nov 24 2015
Blockedon: chromium:558789
Comment 137 by r...@igalia.com, Nov 24 2015
Blockedon: chromium:560872
Comment 138 by r...@igalia.com, Nov 26 2015
Blockedon: chromium:561999
Comment 139 by r...@igalia.com, Nov 26 2015
Blockedon: chromium:562167
Comment 140 by r...@igalia.com, Nov 27 2015
Blockedon: chromium:562458
Comment 141 by r...@igalia.com, Nov 27 2015
Blockedon: chromium:229568
Blockedon: chromium:563400
Comment 143 by r...@igalia.com, Nov 30 2015
Blocking: chromium:562985
Comment 144 by r...@igalia.com, Dec 1 2015
Blockedon: chromium:277819
Comment 145 by r...@igalia.com, Dec 7 2015
Blockedon: chromium:566265
Are there any plans to release it without a flag?

We are using it for more than a year and a half now, and basic functionality works quite stable. We would be really happy to be able to give it to our clients, but we cannot demand them to set the flags.
Well, we are about to send the intent-to-ship request, so that Blink's community can decide then what to do. We are just verifying some browsers interoperability issues, mainly with Mozilla's Firefox, but I don't think it will take too long.
Comment 148 by r...@igalia.com, Dec 16 2015
Blockedon: chromium:570322
Comment 149 by r...@igalia.com, Dec 16 2015
Blockedon: chromium:568882
Blockedon: chromium:575182
Blockedon: -chromium:557254
Removed a bug that is actually a tables' bug
Comment 152 by r...@igalia.com, Jan 18 2016
Blockedon: chromium:578787
Comment 153 by r...@igalia.com, Jan 19 2016
Blockedon: chromium:579104
Blockedon: chromium:583344
Comment 155 by r...@igalia.com, Feb 4 2016
Blockedon: chromium:583743
Comment 156 by r...@igalia.com, Feb 8 2016
Blockedon: chromium:585150
Comment 157 by r...@igalia.com, Feb 16 2016
Blockedon: chromium:583215
Blockedon: chromium:582230
Blockedon: chromium:587641
Comment 160 by r...@igalia.com, Mar 30 2016
Blockedon: 599042
Comment 161 by r...@igalia.com, Apr 5 2016
Blockedon: 600680
Comment 162 by r...@igalia.com, Apr 12 2016
Blockedon: 602670
Comment 163 by r...@igalia.com, Apr 13 2016
Blockedon: 603160
Comment 164 by r...@igalia.com, Apr 15 2016
Blockedon: 603854
Comment 165 by r...@igalia.com, May 12 2016
Blockedon: 611407
Comment 166 by r...@igalia.com, May 12 2016
Blockedon: 611410
Comment 167 by r...@igalia.com, May 18 2016
Blockedon: 612755
Comment 168 by r...@igalia.com, May 24 2016
Blockedon: 614314
Comment 169 by r...@igalia.com, May 25 2016
Blockedon: 614667
Comment 170 by a...@scirra.com, May 25 2016
Recently CSS grid layout performance has become extremely poor in Canary - even just 40-50 elements can take 500ms to layout. Is this a known issue due to current work being done or should I file a new bug for it?
Comment 171 by r...@igalia.com, May 25 2016
Blockedon: 613354
ash@scirra.com

* could you clarify "recently" ? a week, one month, 6 months...
* which release are you using ?
* do you have a test case demonstrating the issue ?

And yes, opening a new bug will be nice.
Comment 173 by r...@igalia.com, May 30 2016
Blockedon: 615248
Comment 174 by r...@igalia.com, Jun 2 2016
Blockedon: 616716
Comment 175 by r...@igalia.com, Jun 7 2016
Blockedon: 617876
Comment 176 by r...@igalia.com, Jun 9 2016
Blockedon: 618664
Comment 177 by r...@igalia.com, Jun 10 2016
Blockedon: 618969
Comment 178 by r...@igalia.com, Jun 10 2016
Blockedon: 616228
Comment 179 by r...@igalia.com, Jun 10 2016
Blockedon: 618970
Comment 180 by r...@igalia.com, Jun 10 2016
Blockedon: 618971
Comment 181 by r...@igalia.com, Jun 10 2016
Blockedon: 618972
Comment 182 by r...@igalia.com, Jun 10 2016
Blockedon: -616228
Comment 183 by a...@scirra.com, Jun 13 2016
@svil... (comment 172): took a while to nail it down but filed bug 619629 which includes a test case demonstrating very poor performance, which seems to be related to nested grids.
Comment 184 by r...@igalia.com, Jun 14 2016
Blockedon: 619567
Comment 185 by r...@igalia.com, Jun 14 2016
Blockedon: 619629
Comment 186 by r...@igalia.com, Jun 14 2016
Blockedon: 619930
Comment 187 by r...@igalia.com, Jun 27 2016
Blockedon: 622915
Comment 188 by r...@igalia.com, Jun 29 2016
Blockedon: 624301
Comment 189 by r...@igalia.com, Jun 30 2016
Blockedon: 624716
Comment 190 by r...@igalia.com, Jul 1 2016
Blockedon: 625102
Comment 191 by r...@igalia.com, Jul 1 2016
Blockedon: -625102
Comment 192 by r...@igalia.com, Jul 13 2016
Blockedon: 627812
Comment 193 by r...@igalia.com, Jul 14 2016
Blockedon: 628155
Comment 194 by r...@igalia.com, Jul 15 2016
Blockedon: 628565
Blockedon: 633474
Blockedon: 639620
Blockedon: -639620
Blockedon: 643359
Blockedon: 641982
Blockedon: 613289
Blockedon: 653433
Blockedon: 654712
Blockedon: 654737
Blockedon: 648814
Blockedon: 654739
Blockedon: 655390
Blockedon: 654904
Blockedon: 656371
Blockedon: 660690
Blockedon: 660675
Summary: [css-grid] Implement CSS Grid Layout (was: Implement CSS Grid Layout)
Blockedon: 562985
Blocking: -562985
Blockedon: 666688
Blockedon: 662016
Blockedon: 666940
Blockedon: 666961
Blockedon: 667057
Blockedon: 667785
Blockedon: 670241
Blockedon: 670614
The chromestatus.com entry should be updated to reflect that this is now shipping: https://www.chromestatus.com/features/4589636412243968
@alancutter I've just updated it. I'm not completely sure about the "Android Webview" version if it matches Chromium version or not.
Please let me know if it's wrong. Thanks! :-)
Blockedon: 681381
Blockedon: 681046
Blockedon: 685609
Blockedon: 687184
Blockedon: 687494
Blockedon: 688640
rego@, what's the status/plan for this work? Predictability program has set an OKR to gain traction on the top 50 starred bugs this quarter: either by closing them, stating what milestone the fix will ship, or setting a NextAction date so that we know when to check back in.
#230 - it is shipping in Chrome 57. I am not sure why it is not marked as fixed, though.
I don't know what's the usual process, but as @phistuck says
this is shipping in Chromium 57 (check the intent-to-ship thread [1]
and the chromestatus entry [2]).

We haven't market it as fixed as there are some remaining work to do
like fixing different bugs, finishing some features, etc.

Should we mark it as fixed? Then I guess we should report a different bug
to track all the related tasks. What's usually done in these scenarios?

[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/hBx1ffTS9CQ/TMTigaDIAgAJ
[2] https://www.chromestatus.com/feature/4589636412243968
I think there are usually separate bugs without a meta bug to hold them together (the component serves as the meta bug).
However, if it is more convenient for you to have a meta bug to hold them together, this is also fine.
Regardless, this is fixed because you did ship CSS Grid Layout. It makes sense to mark it as fixed, yes.
Blockedon: 692754
Comment 235 by r...@igalia.com, Feb 24 (3 days ago)
Status: Fixed
Ok, so let's mark it as fixed to avoid confusion.
Sign in to add a comment