Replace TBR= with automatic To-Be-Reviewed-By: trailers |
|||||
Issue descriptionIt would be awesome, if emails listed in TBR field were added to the reviewers automatically.
,
Dec 4 2017
If you list emails in the TBR field and upload the change (or a subsequent patchset) with "git cl upload", they will be added to the list of reviewers. I don't want to make this a plugin, because I would much rather change the TBR mechanism entirely. I have plans for a gerrit plugin which will watch for changes that are only self-approved, block them from being submitted if there are no other reviewers assigned, and otherwise allow them but automatically add "TBRed-To: name <email@domain>" trailers for every reviewer just like the "Reviewed-By: name <email@domain>" trailers that we get today. Then folks won't have to manually manage TBRs, they just have to self-approve their own CLs. It also makes TBRs easier to audit, since the trailer is in an easily parseable format. It looks like I don't yet have a bug assigned to myself for that work, so I'll repurpose this one now that I've written it out here :)
,
Dec 4 2017
,
Dec 4 2017
,
Jan 2 2018
,
Jan 3 2018
This is mentioned in my Q1 OKRs, so making Pri-1, but removing from Assigned to make the triage status more clear since I haven't actually begun work on it.
,
Jan 3 2018
,
Apr 2 2018
Issue gerrit:8663 has been merged into this issue.
,
Apr 2 2018
,
Aug 10
Unassigning from myself and dropping to P2 because I'm on sabbatical. I'd love to come back to this eventually. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by beckysiegel@google.com
, Dec 4 2017