New issue
Advanced search Search tips

Issue 791781 link

Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Previous locations:
gerrit:7892


Sign in to add a comment

Replace TBR= with automatic To-Be-Reviewed-By: trailers

Project Member Reported by mmoroz@chromium.org, Dec 1 2017

Issue description

It would be awesome, if emails listed in TBR field were added to the reviewers automatically.
 
Cc: vikt...@google.com aga...@chromium.org
This sounds like a great candidate for a plugin, similar to the LGTM plugin.
If you list emails in the TBR field and upload the change (or a subsequent patchset) with "git cl upload", they will be added to the list of reviewers.

I don't want to make this a plugin, because I would much rather change the TBR mechanism entirely. I have plans for a gerrit plugin which will watch for changes that are only self-approved, block them from being submitted if there are no other reviewers assigned, and otherwise allow them but automatically add "TBRed-To: name <email@domain>" trailers for every reviewer just like the "Reviewed-By: name <email@domain>" trailers that we get today.

Then folks won't have to manually manage TBRs, they just have to self-approve their own CLs. It also makes TBRs easier to audit, since the trailer is in an easily parseable format.

It looks like I don't yet have a bug assigned to myself for that work, so I'll repurpose this one now that I've written it out here :)
Project: chromium
Moved issue gerrit:7892 to now be issue chromium:791781.
Cc: -aga...@chromium.org
Components: Infra>Codereview>Gerrit
Owner: aga...@chromium.org
Status: Assigned (was: New)
Summary: Replace TBR= with automatic To-Be-Reviewed-By: trailers (was: Adding TBR= doesn't add a reviewer)
Cc: aga...@chromium.org
 Issue gerrit:5078  has been merged into this issue.
Labels: Pri-1
Owner: ----
Status: Available (was: Assigned)
This is mentioned in my Q1 OKRs, so making Pri-1, but removing from Assigned to make the triage status more clear since I haven't actually begun work on it.
Cc: tandrii@chromium.org
 Issue 624416  has been merged into this issue.
 Issue gerrit:8663  has been merged into this issue.
Owner: aga...@chromium.org
Status: Assigned (was: Available)
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Unassigning from myself and dropping to P2 because I'm on sabbatical. I'd love to come back to this eventually.

Sign in to add a comment