"Copy link address" icon in context menu is missing
Reported by
ltian@chromium.org,
Dec 4 2017
|
||||
Issue descriptionNew Chrome context menu does not display the icons for all copy related items. Steps to reproduce: 1. Enable "Enable custom context menu" from chrome://flags 2. Long press the text link 3. "Copy link address" item does not show icon.
,
Dec 4 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/880920be98a53351d297f9319c4499550e998bf1 commit 880920be98a53351d297f9319c4499550e998bf1 Author: Lei Tian <ltian@chromium.org> Date: Tue Dec 05 19:23:46 2017 Fix copy items' icon not shown in Chrome context menu. Recently all copy related items' change from png to vector drawable, this makes TintedDrawable.constructTintedDrawable fail to render the icon because VectorDrawable does not extend TintedDrawable. Also since ApiCompatibilityUtils.getDrawable cannot render vector drawable on pre-L devices, change to use AppCompatResources.getDrawable to render icon for context menu. Bug: 791780 Change-Id: I35dead93f8ab5d89da49ef32180bebb644effc78 Reviewed-on: https://chromium-review.googlesource.com/807344 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521778} [modify] https://crrev.com/880920be98a53351d297f9319c4499550e998bf1/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java [modify] https://crrev.com/880920be98a53351d297f9319c4499550e998bf1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
,
Dec 7 2017
,
Dec 19 2017
Works as per expected behavior, "Copy link address" item shows icon. Verified in 65.0.3299.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by ltian@chromium.org
, Dec 4 2017287 KB
287 KB View Download