New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Group navigation logs together with decision logs on chrome://interventions-internals.

Project Member Reported by thanhdle@chromium.org, Dec 4 2017

Issue description

Group navigation logs with the corresponding decisions message of the navigation.

Since navigation logs could be called called much later compared to decision logs, the message group need to float to the top of the table when new messages are added to the group.
 
Labels: -Pri-3 Pri-2

Comment 2 Deleted

Labels: -Type-Bug Type-Task
Cc: -thanhdle@chromium.org

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bda568a48de22bc805e4440218edcda5bd6ed14

commit 8bda568a48de22bc805e4440218edcda5bd6ed14
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Dec 06 22:34:24 2017

Group preview navigation log with decision logs.

Group navigation logs with the corresponding decisions message of the
navigation.

Push the group message to the top of the table when there's a new message in
that group. Since navigation logs could be called called much later compared to
decision logs, the message group need to float to the top of the table when new
messages are added to the group.

Bug:  791778 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic872fd155ca25a35286bafaaffde41c2b65a01d4
Reviewed-on: https://chromium-review.googlesource.com/809936
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522230}
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/chrome/test/data/webui/interventions_internals_browsertest.js
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/content/previews_io_data.h
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/core/previews_logger.cc
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/core/previews_logger.h
[modify] https://crrev.com/8bda568a48de22bc805e4440218edcda5bd6ed14/components/previews/core/previews_logger_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment