Load balancing

Load balancing

I've attached a screenshot of the current look.

Proposed new strings:
Body text, remove the first sentence: "Do you want to cancel the download and exit Chromium?"
Cancel button: "Exit immediately" (or maybe "Cancel and exit"?)
OK button: "Finish download"

How are those, Alan?

Deleted: download-in-progress.PNG 13.7 KB

	download-in-progress.PNG 13.7 KB View Download

New proposal for the buttons, after consulting with pkasting:
Cancel button: "Stop download" (or maybe "Abort download")
OK button: "Continue download" (unchanged from current)

Shimi, could you look at this?

I agree that we should remove the first body text sentence, which is redundant. 

Changing the cancel button to "Cancel and exit" also SG. re "Stop download", does this action pause the download or cancel it? I do not like abort for user-facing language.

I prefer the default button to remain "Continue download" rather than "Finish" since we don't know that finishing will occur and it also makes me question whether chrome will automatically close after finishing. But that's just my opinion. :)

It cancels the download. Peter and I went back and forth on that button, since he thought "Stop" sounds like a pause too.

For additional context, I wanted to change the buttons because when I get this dialog I have to pause to figure out which option I want, which is bad.

The proposed text for both buttons is a little long. Here's an alternative proposal that uses less text and I think is still clear:

Download is in progress

Quit Chrome anyway?

Quit | Continue downloading

[Quit is Mac. Is it Exit on Win? I'm not sure and don't have a Win machine handy to check] 

If we use this proposal, it's pretty important that the message descriptions are, well, descriptive enough for translators. Here they are, too:

Title <desc>="Title of a dialog shown when a user tries to quit/exit Chrome while a download is in progress."

Body <desc>="Body text of a dialog shown when a user tries to quit/exit Chrome while a download is in progress."

Button 1 <desc>="Button text for a dialog shown when a user tries to quit/exit Chrome while a download is in progress. 'Continue download' will continue the download without quitting Chrome."

Button 2 <desc>="Button text for a dialog shown when a user tries to quit/exit Chrome while a download is in progress. 'Quit' will abandon the download and immediately quit Chrome."

Thanks Shimi! That looks good to me. It does look like we use "Exit" on non-Mac, but I'll make the string platform-dependent.

I found an alternate version of the dialog that shows if you're downloading something in incognito mode and you close all incognito windows (attached screenshot). Should I use the same strings?

Download is in progress
Exit incognito mode anyway?
Exit | Continue downloading

Also, there's alternate language if you have more than one download in progress. I think the only change would need to be to the title: "Downloads are in progress". Sounds okay?

Deleted: download-in-progress-incognito.PNG 8.1 KB

	download-in-progress-incognito.PNG 8.1 KB View Download

Screenshots for https://chromium-review.googlesource.com/c/chromium/src/+/897736

Deleted: download-in-progress-2.PNG 5.7 KB

	download-in-progress-2.PNG 5.7 KB View Download

Deleted: download-in-progress-incognito-2.PNG 5.0 KB

	download-in-progress-incognito-2.PNG 5.0 KB View Download

And the multiple downloads version.

Deleted: download-in-progress-3.PNG 5.1 KB

	download-in-progress-3.PNG 5.1 KB View Download

Screenshot with a smaller dialog

Deleted: download-in-progress-4.PNG 5.1 KB

	download-in-progress-4.PNG 5.1 KB View Download

The 448 screenshots LGTM. In context of the window, we should keep them larger. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331f10a07ba3cf04e0d3947697dc00eaec9f8e33

commit 331f10a07ba3cf04e0d3947697dc00eaec9f8e33
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Feb 13 22:37:42 2018

Harmonize Download in Progress dialog.

* Removed the close-x.
* Changed all dialog strings. Made usages of "Exit" vs. "Quit" dependent
  on the OS.
* Did some minor cleanup on the dialog code.

Bug:  791775 
Change-Id: I78744493573231f3b4d7b883142b5bad19339dd7
Reviewed-on: https://chromium-review.googlesource.com/897736
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536522}
[modify] https://crrev.com/331f10a07ba3cf04e0d3947697dc00eaec9f8e33/chrome/app/chromium_strings.grd
[modify] https://crrev.com/331f10a07ba3cf04e0d3947697dc00eaec9f8e33/chrome/app/generated_resources.grd
[modify] https://crrev.com/331f10a07ba3cf04e0d3947697dc00eaec9f8e33/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/331f10a07ba3cf04e0d3947697dc00eaec9f8e33/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/331f10a07ba3cf04e0d3947697dc00eaec9f8e33/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc
[modify] https://crrev.com/331f10a07ba3cf04e0d3947697dc00eaec9f8e33/chrome/browser/ui/views/download/download_in_progress_dialog_view.h

Verified the fix on M66 66.0.3347.0 on Mac 10.13.1,Windows 10 and Ubuntu 14.04 and fix is working as intended. i.e., We are able to see the Pop up while exiting the chrome at the time of downloading any file as shown in comments#10,11 and 12
Attaching the screenshot for reference.

Note: In older version we able to see a behaviour similar to that of attachments shown in comment#1 
As the fix is working as intended adding Verified labels.

Thanks!

Deleted: CL verif Downloading.png 19.7 KB

	CL verif Downloading.png 19.7 KB View Download

This is as much work as we'll do for Harmony specifically. File a new bug for further improvements.