New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791774 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Clear log messages and buffer on chrome://interventions-internals when history is cleared

Project Member Reported by thanhdle@chromium.org, Dec 4 2017

Issue description

Logs messages of navigation are retained in PreviewsLogger bufffer, and on chrome://interventions-internals until the end of that session even when user history is cleared.

Since ClearBlacklist event is triggered whenever history is cleared, removing all log message on the page, and all buffer messages in PreviewsLogger seems like a reasonable solution.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44e2e5f8caf153b0ad01425665ec17bbc419a76b

commit 44e2e5f8caf153b0ad01425665ec17bbc419a76b
Author: Thanh Le <thanhdle@chromium.org>
Date: Tue Dec 05 18:18:15 2017

Clear log messages and buffer on chrome://interventions when history is cleared.

Logs messages of navigation are retained in PreviewsLogger bufffer, and
on chrome://interventions-internals until the end of that session even
when user history is cleared.

Since ClearBlacklist event is triggered whenever history is cleared,
removing all log message on the page, and all buffer messages in
PreviewsLogger seems like a reasonable solution.

Bug:  791774 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0f69f5ec89679826557cdd23bbd1f316957711ec
Reviewed-on: https://chromium-review.googlesource.com/807397
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521747}
[modify] https://crrev.com/44e2e5f8caf153b0ad01425665ec17bbc419a76b/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/44e2e5f8caf153b0ad01425665ec17bbc419a76b/chrome/test/data/webui/interventions_internals_browsertest.js
[modify] https://crrev.com/44e2e5f8caf153b0ad01425665ec17bbc419a76b/components/previews/core/previews_logger.cc
[modify] https://crrev.com/44e2e5f8caf153b0ad01425665ec17bbc419a76b/components/previews/core/previews_logger_unittest.cc

Comment 2 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews
Hey Ryan, could you merge the CL in comment #1 to 64. Thanks!

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Labels: M-64 Merge-Request-64 OS-Android OS-Chrome OS-Linux OS-Windows
Requesting merge, as there is a concern here that this can expose part of user's recent history after clearing their browsing history.
Owner: ryansturm@chromium.org
Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f346ef69d5eec846794d8d20f94372f3bc41a0fa

commit f346ef69d5eec846794d8d20f94372f3bc41a0fa
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Dec 06 18:27:50 2017

Clear log messages and buffer on chrome://interventions when history is cleared.

Logs messages of navigation are retained in PreviewsLogger bufffer, and
on chrome://interventions-internals until the end of that session even
when user history is cleared.

Since ClearBlacklist event is triggered whenever history is cleared,
removing all log message on the page, and all buffer messages in
PreviewsLogger seems like a reasonable solution.

Bug:  791774 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0f69f5ec89679826557cdd23bbd1f316957711ec
Reviewed-on: https://chromium-review.googlesource.com/807397
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521747}(cherry picked from commit 44e2e5f8caf153b0ad01425665ec17bbc419a76b)
Reviewed-on: https://chromium-review.googlesource.com/811605
Cr-Commit-Position: refs/branch-heads/3282@{#60}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/chrome/test/data/webui/interventions_internals_browsertest.js
[modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/components/previews/core/previews_logger.cc
[modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/components/previews/core/previews_logger_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment