Clear log messages and buffer on chrome://interventions-internals when history is cleared |
||||||||
Issue descriptionLogs messages of navigation are retained in PreviewsLogger bufffer, and on chrome://interventions-internals until the end of that session even when user history is cleared. Since ClearBlacklist event is triggered whenever history is cleared, removing all log message on the page, and all buffer messages in PreviewsLogger seems like a reasonable solution.
,
Dec 5 2017
,
Dec 5 2017
Hey Ryan, could you merge the CL in comment #1 to 64. Thanks!
,
Dec 5 2017
,
Dec 5 2017
Requesting merge, as there is a concern here that this can expose part of user's recent history after clearing their browsing history.
,
Dec 5 2017
,
Dec 6 2017
Approving merge to M64 Chrome OS.
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f346ef69d5eec846794d8d20f94372f3bc41a0fa commit f346ef69d5eec846794d8d20f94372f3bc41a0fa Author: Thanh Le <thanhdle@chromium.org> Date: Wed Dec 06 18:27:50 2017 Clear log messages and buffer on chrome://interventions when history is cleared. Logs messages of navigation are retained in PreviewsLogger bufffer, and on chrome://interventions-internals until the end of that session even when user history is cleared. Since ClearBlacklist event is triggered whenever history is cleared, removing all log message on the page, and all buffer messages in PreviewsLogger seems like a reasonable solution. Bug: 791774 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0f69f5ec89679826557cdd23bbd1f316957711ec Reviewed-on: https://chromium-review.googlesource.com/807397 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521747}(cherry picked from commit 44e2e5f8caf153b0ad01425665ec17bbc419a76b) Reviewed-on: https://chromium-review.googlesource.com/811605 Cr-Commit-Position: refs/branch-heads/3282@{#60} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/chrome/browser/resources/interventions_internals/index.js [modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/chrome/test/data/webui/interventions_internals_browsertest.js [modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/components/previews/core/previews_logger.cc [modify] https://crrev.com/f346ef69d5eec846794d8d20f94372f3bc41a0fa/components/previews/core/previews_logger_unittest.cc
,
Dec 6 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 5 2017