New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791770 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

config-updater build is broken.

Project Member Reported by bhthompson@google.com, Dec 4 2017

Issue description

With 64 it looks like we are missing all unified builds (coral, reef, fizz, at minimum).

https://uberchromegw.corp.google.com/i/chromeos_release/waterfall

We may need to do some tweaking on Chromite or GE to have it instantiate properly, we need to fix this ASAP if we are to have unified build support on 64. 
 
Cc: leecy@chromium.org
Labels: M-64 ReleaseBlock-Dev
It looks like there are some smarts somewhere in GE that control how the ge_build_config.json file are generated on the branch only, so we ended up with:

https://chromium.googlesource.com/chromiumos/chromite/+/ef92ed65c58500cbf81cc0e1f525057aa4ebf8ab

Which removed Coral on the branch.
Looking at Coral, I think GE is listing as a board to be included.

https://cros-goldeneye.corp.google.com/chromeos/console/viewBoard?name=coral


Summary: config-updater build is broken. (was: Unified builds do not instantiate on the release waterfall)
Oh..... 

ge exports it's settings as a json file. 

This builder is responsible for importing that data into the ChromeOS config (and updating our settings as needed).

https://uberchromegw.corp.google.com/i/chromeos.infra/builders/config-updater

We need to fix that builder, then do a release waterfall restart. Until then, the list of builders included is.... random.
Root caused the error in GE.  Fix in flight.

Will need a GE push before anything to get the fix started.
The config-updater is failing, but it had succeeded in updating the waterfall configuration for the release branch before it stopped passing (looks like a GSUtil failure we are also seeing on other builders).

First build with the 64 release branch in it was https://uberchromegw.corp.google.com/i/chromeos.infra/builders/config-updater/builds/12126

So while we do need to get the config-updater green again, I think we also have to work out the communication between GE and Chromite here.
Owner: shapiroc@chromium.org
Thanks Charles!

I will pass the bug to you then, once we have your CL in and GE restarted we can check back on if the config-updater is still failing, once that is done let me know or pass the bug over and I can go through the motions to reinstantiate the release waterfall.
fix at cr/177886981
Labels: -ReleaseBlock-Dev
This was merged and pushed to Goldeneye.  Waterfalls restarted last night to pick up builders.  Images are present for latest DEV build.  Removing as a Dev blocker.
Cc: bhthompson@chromium.org pbe...@chromium.org keta...@chromium.org pyeh@chromium.org
 Issue 792465  has been merged into this issue.
Status: Verified (was: Untriaged)
I see builds, looks verified to me, thanks for the quick fix!
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment