New issue
Advanced search Search tips

Issue 791767 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Harmony-Ready-For-Review


Sign in to add a comment

Restore Pages dialogue - Harmony

Project Member Reported by abdulsyed@chromium.org, Dec 4 2017

Issue description

Comment 1 by bsep@chromium.org, Dec 14 2017

Owner: pkasting@chromium.org
Status: Assigned (was: Untriaged)
Load balancing

That doesn't look like a Harmony mock... but this dialog should be pretty straightforward anyway.

Comment 2 by bsep@chromium.org, Feb 8 2018

Cc: -bsep@chromium.org
Owner: bsep@chromium.org
Load balancing
Cc: bsep@chromium.org
Owner: kylixrd@chromium.org
More load balancing.
Does Harmony still use the footnote area? This looks a little out of place.
RestorePagesWithUmaOffer.png
5.2 KB View Download
Moved the footnote into the content area.
RestorePagesWithUmaOffer_NoFootnote.png
5.2 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f8ce251f2fd6386cc735daa4a97874542e90ca2

commit 3f8ce251f2fd6386cc735daa4a97874542e90ca2
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Feb 13 22:09:21 2018

Harmonize the Restore pages dialog.

Added extra browser test to invoke the Offer Uma version of the dialog.

Bug:  791767 
Change-Id: I10650d4681a997907e8125dad702dad4a6e5cc63
Reviewed-on: https://chromium-review.googlesource.com/913722
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536502}
[modify] https://crrev.com/3f8ce251f2fd6386cc735daa4a97874542e90ca2/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/3f8ce251f2fd6386cc735daa4a97874542e90ca2/chrome/browser/ui/views/session_crashed_bubble_view.h
[modify] https://crrev.com/3f8ce251f2fd6386cc735daa4a97874542e90ca2/chrome/browser/ui/views/session_crashed_bubble_view_browsertest.cc

Comment 7 by bettes@chromium.org, Feb 20 2018

I presume this is anchored off the menu? I don't see an active state on the icon, but otherwise, the contents of this dialog LGTM
Those screen-shots are done using the dialog/ui test harness, so some things like the icon state may not be reflected. The actual browser invocation of the bubble should present as expected.
Cc: kylixrd@chromium.org
Owner: bettes@chromium.org
Reassigned for UX review.
Status: Fixed (was: Assigned)

Sign in to add a comment