New issue
Advanced search Search tips

Issue 791762 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Bob: Add a charging_ports pref for powerd to identify the position of the two Type-C ports

Project Member Reported by bleung@chromium.org, Dec 4 2017

Issue description

What steps will reproduce the problem?
1. Plug in a dual-role device ie. Pixel C tablet to Bob's Type-C port using a C-to-C cable 
2. go to "Manage power source..." settings 
3. Click on the drop down menu for Power Source 

What is the expected output?
The dropdown menu should help identify which port to optionally charge from (ie, "USB-C device (right back port)" ) 


What do you see instead?
"USB-C device" 

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always 

What is the impact to the user, and is there a workaround? If so, what is
it?
Minor inconvenience. In the event that multiple USB-C dual role power devices are attached, it becomes hard for the user to figure out which one to select to charge the laptop. 

Please provide any additional information below.
 
Status: Started (was: Assigned)
For my own reference:

right back, port 0.
right front, port 1.


Cc: philipchen@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a7e45a118e3f0997a69ca2970dcfd29596693977

commit a7e45a118e3f0997a69ca2970dcfd29596693977
Author: Benson Leung <bleung@chromium.org>
Date: Tue Dec 05 04:02:59 2017

chromeos-bsp-bob : set USB-C port locations.

Signed-off-by: Benson Leung <bleung@chromium.org>

BUG= chromium:791762 
TEST=Plug in a dual-role power device (other chromebook) into Bob's
Right back and right front ports. Check in the power source settings drop
down that the position is correctly identified.

Change-Id: Ie221ab9e147e53557fb4d5f907d3a9cfc11a8e79
Reviewed-on: https://chromium-review.googlesource.com/807167
Commit-Ready: Benson Leung <bleung@google.com>
Tested-by: Benson Leung <bleung@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/a7e45a118e3f0997a69ca2970dcfd29596693977/overlay-bob/chromeos-base/chromeos-bsp-bob/files/powerd_prefs/charging_ports
[rename] https://crrev.com/a7e45a118e3f0997a69ca2970dcfd29596693977/overlay-bob/chromeos-base/chromeos-bsp-bob/chromeos-bsp-bob-0.0.1-r7.ebuild

Status: Fixed (was: Started)
Labels: M-65

Sign in to add a comment