New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791757 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

A11Y: NVDA and JAWS do not read titles when switching tabs

Project Member Reported by dsexton@chromium.org, Dec 4 2017

Issue description

64.0.3282.5 (Official Build) canary (64-bit) (cohort: Clang-64)
NVDA: 2017.3
JAWS: 2018

Steps to repro:
# With NVDA running: open three tabs in Chrome each on a different web page
# Use arrows to move NVDA to any point on each tab
# Cycle between the tabs with CTRL+tab
# NVDA says something similar to:
New Issue - chromium - An open-source project to help move the web forward. - Monorail  window
main  tool bar
Address and search bar  edit
selected https://bugs.chromium.org/p/chromium/issues/entry?labels=Type-Bug,Pri-2,OS-Windows&components=UI>Accessibility
New Issue - chromium - An open-source project to help move the web forward. - Monorail  document
table
Chrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) (2) (3) What is the expected result? What happens instead? Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.   Description:  row 3
Description:  edit  multi line  required
# 
About Version  window
main  tool bar
Address and search bar  edit
selected chrome://version
About Version  document
selected 64.0.3282.5 (Official Build) canary (64-bit) (cohort: Clang-64)
Google  window
main  tool bar
Secure  menu button  View site information
Address and search bar  edit
selected https://www.google.com
Google  document
Search  combo box  editable  has auto complete  Search
# Notice that on each tab focus remains where it was set before changing tabs and at no point does focus move to the omnibox

Expected: NVDA should only announce the page title and focused element

Actual: NVDA announces the page title, information about the omnibox, the omnibox contents, then the focused element

# With JAWS running: open three tabs in Chrome each on a different web page
# Use arrows to move JAWS to any point on each tab
# Cycle between the tabs with CTRL+tab
# JAWS says something similar to:
Description: 
SearchRegion 
Business Link 
column 2 row 3
Description: edit 
Required 
Contains text
Type in text.

Expected: JAWS should announce the title and the focused control

Actual: JAWS announces the focused control and sometimes content from other tabs
 
Cc: rbenz@google.com jlc...@google.com dmazz...@chromium.org lpalmaro@chromium.org
 Issue 678991  has been merged into this issue.
Owner: aleventhal@chromium.org
Status: Started (was: Available)
Possibly related, possible dupe of  bug 777051 
Blocking: 777051
 Issue 777051  has been merged into this issue.
Labels: JAWS-specific tabstrip
I decided to dupe out 777051 since these bugs are similar enough. 

Repro steps for another way of looking at this:
What steps will reproduce the problem?
(1) Enable JAWS, open Chrome
(2) use ctrl + t to create at least one new tab and one
(3) Use ctrl + 1, ctrl + 2, etc. to select tabs 

What is the expected result? Title of the tab is read

What happens instead? Title of the tab is NOT read, just the number is spoken

NVDA reads the title of each tab whereas JAWS does not. 
Blocking: -777051
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3700a46c532af05ed573ee417e2437c398352fcb

commit 3700a46c532af05ed573ee417e2437c398352fcb
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Jan 22 16:30:58 2018

Remove spurious focus event in UI during tab switching

Do not advance focus to the IconLabelBubbleView when switching tabs as
this causes screen readers to read the contents of that view, and in the
case of JAWS, causes it to also not read the new focus within the tab.

The spurious focus event was caused by the following line:
SetFocusBehavior(FocusBehavior::NEVER);
This resulted in a call to View::AdvanceFocusIfNecessary().

This CL cleans up the code path that occurs when we are emptying the
content area prior to attaching new content, including only the
necessary lines of code that would have run, need to run and
are not harmful to accessibility.

Bug:  791757 , 777051 
Change-Id: I81cfd39710e0bb0beaeb8a571ce3b899e9b71d7e
Reviewed-on: https://chromium-review.googlesource.com/868475
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530878}
[modify] https://crrev.com/3700a46c532af05ed573ee417e2437c398352fcb/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/3700a46c532af05ed573ee417e2437c398352fcb/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc

Labels: a11y-testers
Status: Fixed (was: Started)
Hello testing team, please verify with screen readers on all platforms as well as both Ctrl+Tab and Ctrl+digit, Ctrl+W to close, etc.
Status: Available (was: Fixed)
Chrome: 66.0.3349.0 (Official Build) canary (64-bit) (cohort: Clang-64)
NVDA 2017.4
JAWS 2018

# Open two tabs with different content
# Focus the omnibox on one tab
# Press ctrl+tab a few times using NVDA or JAWS
# Notice that NVDA and JAWS don't announce page title on the tab where the omnibox has focus

Expected: Page title should always be announced when tab receives focus

Actual: Omnibox title is announced instead of page title if the omnibox is focused


Labels: -a11y-testers
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dfddc05c6fea9d96313e62a8093d84823bec87c

commit 3dfddc05c6fea9d96313e62a8093d84823bec87c
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Fri Mar 09 16:10:08 2018

Focus event to indicate context if UI focused after tab switch

When switching to a tab that has the Omnibox or other UI focused,
screen readers do not read the title of the document being navigated to.

For the case where a tab is switched, and the UI is about to be focused,
fire an extra focus event on the widget's root view so that the document
title is read before the UI focus.

TBR: tsepez@chromium.org
Bug:  791757 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I19a91eaac1c24dfd04ab3458a41aaa0c512a8739
Reviewed-on: https://chromium-review.googlesource.com/938778
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542131}
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_focus_helper.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_focus_helper.h
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/3dfddc05c6fea9d96313e62a8093d84823bec87c/ui/views/accessibility/native_view_accessibility_base.cc

Labels: a11y-testers
Status: Fixed (was: Started)
@dsexton, all 4 combinations of switching between tabs should be addressed, 2 types of focus in first tab times 2 types of focus in second tab. (tab with focus in content or location bar) then switching to (new tab with focus in content or location bar). 


Labels: -a11y-testers
Status: Verified (was: Fixed)
Great work! 

Sign in to add a comment