New issue
Advanced search Search tips

Issue 791755 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
artyo...@gmail.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 761432


Sign in to add a comment

Cleanup: remove OwnOffscreenSurface WebGL code

Project Member Reported by klausw@chromium.org, Dec 4 2017 
There are still some code paths to support having offscreen WebGL contexts using their own surface with custom context attributes such as depth buffer.

The activation for this ended up being reverted since it's incompatible with virtualized contexts which are required for Qualcomm GPUs (see issue 691102), and the proposed AHardwareBuffer support is intended to replace it ( issue 761432 ).

Remove the leftover code for this once the new drawing path is ready.

See for example WebGLRenderingContextBase::SupportOwnOffscreenSurface, Platform::ContextAttributes, and the !surface_format.IsCompatible(default_surface->GetFormat()) check in GpuCommandBufferStub.

+Artem FYI in case you're still using this for your branch.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/409774e95d22cffc51877e176045a82ef6f65907

commit 409774e95d22cffc51877e176045a82ef6f65907
Author: Klaus Weidner <klausw@chromium.org>
Date: Mon Dec 04 23:57:15 2017

Disable SupportOwnOffscreenSurface for WebGL

The WebVRExperimentalRendering flag is being repurposed for other
rendering optimizations, and activating the own offscreen surface was
causing glitches.

BUG= 761432 ,691102, 791755 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I15ab8ee3c3370968ce5ea2ea6a170f6282858ad1
Reviewed-on: https://chromium-review.googlesource.com/802631
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521535}
[modify] https://crrev.com/409774e95d22cffc51877e176045a82ef6f65907/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Comment 2 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment