New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791750 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MD extensions "Errors" page should clip long messages

Reported by woxxom@gmail.com, Dec 4 2017

Issue description

Google Chrome 64.0.3282.5 (Official Build) canary (64-bit)

========================================

1. open chrome://extensions page
2. enable "Developer mode" in the top-right corner
3. install the attached extension
4. click "Errors" in the extension's card

Expected:
* the page is opened immediately
* the message doesn't overflow viewport bounds
* the trashcan icon is visible to the right of the error message in the viewport

Observed:
* the page is opened after a second or more
* the message overflow the viewport and a scrollbar appears on the bottom
* the trashcan icon is not in the viewport

========================================

Can be fixed by clipping messages to a preset length in JavaScript (e.g. 1000 characters) and specifying CSS overflow:

.error-message {
  width: 440px;
  overflow: hidden;
  text-overflow: ellipsis;
}
 
test-extension.zip
531 bytes Download
bad.png
7.0 KB View Download

Comment 1 by woxxom@gmail.com, Dec 4 2017

Note: the classic extensions page didn't overflow, but it also didn't clip superlong messages so a one-second delay was present on opening.
Labels: Hotlist-MD-Extensions-ErrorConsole
Grouping all error-console related bugs into a hotlist, so that we can better keep track of them.
Status: Untriaged (was: Unconfirmed)
Owner: scottchen@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70df9a14f7b4dc8edbed69be2eeac423f6ecadef

commit 70df9a14f7b4dc8edbed69be2eeac423f6ecadef
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Dec 08 19:43:36 2017

MD Extensions: fix error message styling in error-console.

This CL fixes icon size and text-overflow issues on the error-console page.

Bug:  791750 ,  781316 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia0d91e459c3425e6bdabba16006caf9958dc3433
Reviewed-on: https://chromium-review.googlesource.com/816034
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522845}
[modify] https://crrev.com/70df9a14f7b4dc8edbed69be2eeac423f6ecadef/chrome/browser/resources/md_extensions/error_page.html

Status: Fixed (was: Started)

Sign in to add a comment