New issue
Advanced search Search tips

Issue 791741 link

Starred by 1 user
Status: Fixed
Owner:
huayinz@chromium.org
Closed: Jan 2018
Cc:
edwardjung@chromium.org
srahim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Change omnibox placeholder string to "Search or type web address"

Project Member Reported by k...@chromium.org, Dec 4 2017 
When we experimented with different omnibox placeholder strings, we saw no statistically significant differences based on what string we showed. Therefore, we want to make a one-off change to "Search or type web address" from the current text of "Search or type URL" to be more EM-friendly and understandable.

Comment 1 by huayinz@chromium.org, Dec 4 2017

Cc: -huayinz@chromium.org
Owner: huayinz@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b457d926a263ff8c41f7902897c38e113afe0970

commit b457d926a263ff8c41f7902897c38e113afe0970
Author: Becky Zhou <huayinz@chromium.org>
Date: Tue Dec 19 22:16:34 2017

Clean up omnibox placeholder experiment and change string

+ Change omnibox placeholder string to "Search or type web address"

Bug:  791741 
Change-Id: I1f1c5f2cdd89fb7dcb500afda76234c2031ce72b
Reviewed-on: https://chromium-review.googlesource.com/813034
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525155}
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java/res/layout/url_bar.xml
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[delete] https://crrev.com/a914c7f64c82ba23a53d9a6e703bad25481853b0/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxPlaceholderFieldTrial.java
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/java_sources.gni
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/app/generated_resources.grd
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/test/data/android/render_tests/NewTabPageTest.fakebox.Nexus_5-19.png
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/test/data/android/render_tests/NewTabPageTest.new_tab_page.Nexus_5-19.png
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/chrome/test/data/android/render_tests/NewTabPageTest.new_tab_page_scrolled.Nexus_5-19.png
[modify] https://crrev.com/b457d926a263ff8c41f7902897c38e113afe0970/testing/variations/fieldtrial_testing_config.json

Comment 3 by huayinz@chromium.org, Jan 11 2018

Status: Fixed (was: Assigned)
Also cleaned up code for the experiment.
►

Sign in to add a comment