New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791734 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 774365
issue 787946
issue 791742



Sign in to add a comment

Some webkit_unit_tests always get retried in runs under Linux

Project Member Reported by w...@chromium.org, Dec 4 2017

Issue description

On two consecutive re-runs of webkit_unit_tests Linux/Debug I see:

Retrying 6 tests (retry #1)
[7307/7312] VirtualTimeTest.SetInterval (51 ms)
[7308/7312] ViewportHistogramsTest.TypeNone (80 ms)
[7309/7312] ViewportHistogramsTest.TypeDeviceWidth (81 ms)
[7310/7312] ViewportHistogramsTest.TypeConstant (79 ms)
[7311/7312] AudioWorkletGlobalScopeTest.Basic (112 ms)
[7312/7312] All/ScrollbarAppearanceTest.ThemeEngineDefinesMinimumThumbLength/0 (78 ms)

on both runs.

Re-running the binary with --test-launcher-retry-limit=0 gives:

3 tests failed:
    ViewportHistogramsTest.TypeConstant (../../third_party/WebKit/Source/core/page/ViewportTest.cpp:3316)
    ViewportHistogramsTest.TypeDeviceWidth (../../third_party/WebKit/Source/core/page/ViewportTest.cpp:3310)
    ViewportHistogramsTest.TypeNone (../../third_party/WebKit/Source/core/page/ViewportTest.cpp:3304)
3 tests crashed:
    All/ScrollbarAppearanceTest.ThemeEngineDefinesMinimumThumbLength/0 (../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:1362)
    AudioWorkletGlobalScopeTest.Basic (../../third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp:372)
    VirtualTimeTest.SetInterval (../../third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp:111)
Tests took 51 seconds.

Running with e.g. --gtest_filter=ViewportHistogramsTest* does not report any issues, suggesting that there is some cross-test pollution of global state leading to issues.
 

Comment 1 by w...@chromium.org, Dec 4 2017

Blockedon: 787946 774365
ViewportHistogramsTest.* previously reported as  issue 787946 .
AudioWorkletGlobalScopeTest.Basic reported as  issue 774365 .

Comment 2 by w...@chromium.org, Dec 4 2017

Blockedon: 791742
Filed  issue 791742  for All/ScrollbarAppearanceTest.ThemeEngineDefinesMinimumThumbLength/0.

Comment 3 by w...@chromium.org, Dec 5 2017

Owner: w...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by w...@chromium.org, Dec 5 2017

Owner: ----
Status: Available (was: Assigned)

Comment 5 by w...@chromium.org, Dec 5 2017

Status: Untriaged (was: Available)
Components: -Blink Blink>Infra

Comment 7 by foolip@chromium.org, Dec 15 2017

Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
bokan@ is assigned to both of the blocking issue, so assigning this too for an update some time down the line.
@bokan can you give an update on this?

Comment 9 by bokan@chromium.org, Jan 19 2018

Labels: -Pri-1 Pri-2
It's still on my TODO list but I've been side tracked by other things so I haven't had a chance to take a look yet.

Comment 10 by bokan@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)
Viewport histograms tests no longer repro.

VirtualTimeTest and ScrollbarAppearanceTest were fixed in  issue 791742 .

Sign in to add a comment