New issue
Advanced search Search tips

Issue 791723 link

Starred by 1 user
Status: Fixed
Owner:
bleung@chromium.org
Closed: Dec 2017
Cc:
derat@chromium.org
dnojiri@chromium.org
bleung@google.com
jclinton@chromium.org
sjg@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Snappy: Charging ports reconfigured. When plugging in a USB-C DRP on left port, identifies in UI as right port

Project Member Reported by bleung@chromium.org, Dec 4 2017 
Chrome Version       : 63.0.3239.70
OS Version: 10032.59.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox:
    IE/Edge:

What steps will reproduce the problem?
1. Plug Snappy into another Chromebook on its left port
2. Go to chrome://settings/power and check the power source dropdown
3.

What is the expected result?
USB-C (left port)


What happens instead of that?
USB-C (right port)

Please provide any additional information below. Attach a screenshot if
possible.

I'm pretty sure this happened when Snappy was refactored with a shared baseboard with Reef. 

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 10032.59.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.70 Safari/537.36

Comment 1 by bleung@chromium.org, Dec 4 2017 

Just a bit of context, Snappy is a Reef derived board, but its logic board is flipped upside down compared to other Reef derivatives.

See https://issuetracker.google.com/35586345#comment2

we needed a unique charging_ports file for snappy.

Comment 2 by bleung@chromium.org, Dec 4 2017

Status: Started (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/90cc4a81b316a59c007c508676d8bd47a652087d

commit 90cc4a81b316a59c007c508676d8bd47a652087d
Author: Benson Leung <bleung@chromium.org>
Date: Tue Dec 05 04:02:45 2017

reef/snappy: Move charging_ports to model specific, as Snappy is flipped

Snappy's Port 0 is on the right rather than the left, as is the case with
other Reef derivatives.

Signed-off-by: Benson Leung <bleung@chromium.org>

BUG= chromium:791723 ,b:35586345
TEST=Plug in a dual-role power device (other Chromebook) into Snappy's
right and left ports. Check in the power source settings drop
down that the position is correctly identified.

Change-Id: Ic3525c7fd0c7d8de89a1ba14a23a76bab47e9e19
Reviewed-on: https://chromium-review.googlesource.com/806645
Commit-Ready: Benson Leung <bleung@google.com>
Tested-by: Benson Leung <bleung@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/90cc4a81b316a59c007c508676d8bd47a652087d/baseboard-reef/chromeos-base/chromeos-bsp-baseboard-reef/files/powerd_prefs/model_specific/reef/charging_ports
[add] https://crrev.com/90cc4a81b316a59c007c508676d8bd47a652087d/baseboard-reef/chromeos-base/chromeos-bsp-baseboard-reef/files/powerd_prefs/model_specific/snappy/charging_ports
[rename] https://crrev.com/90cc4a81b316a59c007c508676d8bd47a652087d/baseboard-reef/chromeos-base/chromeos-bsp-baseboard-reef/chromeos-bsp-baseboard-reef-0.0.1-r6.ebuild

Comment 4 by bleung@chromium.org, Dec 5 2017

Labels: M-65
Status: Fixed (was: Started)

Comment 5 by derat@chromium.org, Dec 8 2017

Cc: jclinton@chromium.org
Is this related to https://crrev.com/c/815885?

Comment 6 by jclinton@chromium.org, Dec 8 2017 

Yes, I think so. I don't think the CL here would have worked on a legacy build. I copied it over in the new CL to the legacy location so Benson's fix will apply to legacy builds.
►

Sign in to add a comment