New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791718 link

Starred by 1 user
Status: Fixed
Owner:
█ shuqianz@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
akes...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Find and eliminate post-push service checks for the services we have alerts for

Project Member Reported by pprabhu@chromium.org, Dec 4 2017 
These service checks fail very often and most of the times the response is: Rerun the check manually.

Alerts are better because there is no reason between a service failing and a service failing because of a push as far as monitoring is concerned.

--> akeshet@ to triage.

Comment 1 by akes...@chromium.org, Dec 5 2017

Cc: akes...@chromium.org
Owner: shuqianz@chromium.org
Status: Assigned (was: Untriaged)
-> shuqianz

I think we should skip the service health checks in the prod push. Even if the service is unhealthy, it's already too late, and failing the push doesn't make it any easier to notice.

Maybe we want to keep the service health checks during staging push though.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/87a4d6aeb2668aec498cefeb30c01623a6abc1dc

commit 87a4d6aeb2668aec498cefeb30c01623a6abc1dc
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Wed Dec 06 19:32:03 2017

autotest: skip service check when update servers in prod

BUG= chromium:791718 
TEST=unittest

Change-Id: Ifd7fc7532ac4de347dc8d791d02a4955db7d0594
Reviewed-on: https://chromium-review.googlesource.com/807665
Commit-Ready: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Shuqian Zhao <shuqianz@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/87a4d6aeb2668aec498cefeb30c01623a6abc1dc/site_utils/deploy_server_local.py

Comment 3 by shuqianz@chromium.org, Mar 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment