BrokerProcess.StatFile on android fails unless device is rebooted |
||||
Issue descriptionOn android, tests are tried up to three times. Prior to the last attempt, the devices are rebooted. The BrokerProcess.StatFile test consistently fails the first two attempts and only passes once the devices are rebooted. See the degree of flake: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sandbox_linux_unittests&tests=BrokerProcess.StatFile I'd like to turn off that device reboot, but this test is preventing that: https://chromium-review.googlesource.com/c/chromium/src/+/804914 Assigning to author of the CL that introduced the test: https://chromium-review.googlesource.com/c/chromium/src/+/776128 To reproduce, run sandbox_linux_unittests on android with '--test-launcher-retry-limit 0' to see how it always fails the first attempt.
,
Dec 4 2017
Error is: sandbox/linux/syscall_broker/broker_process_unittest.cc:719: Failure Expected: (0u) != (static_cast<unsigned int>(sb.st_uid)), actual: 0 vs 0 same for gid, but the rest of the info seems OK.
,
Dec 4 2017
CL underway at https://chromium-review.googlesource.com/c/chromium/src/+/807248
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31b37bf783ec838a675960e70ebde13c693bbf30 commit 31b37bf783ec838a675960e70ebde13c693bbf30 Author: Tom Sepez <tsepez@chromium.org> Date: Tue Dec 05 17:53:45 2017 Prevent BrokerProcess.StatFile failing on android. Might fail if run as root as currently written. Make tighter test based on expected ids. Bug: 791696 Change-Id: I55e0febd8de570d4982c369782ce6cf74e2f3f39 Reviewed-on: https://chromium-review.googlesource.com/807248 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521738} [modify] https://crrev.com/31b37bf783ec838a675960e70ebde13c693bbf30/sandbox/linux/syscall_broker/broker_process_unittest.cc
,
Dec 5 2017
(speculative) fix in per c#4. Please re-open if this doesn't resolve your problem. Thanks!
,
Dec 5 2017
Confirmed it passes on 1st try now tyvm! |
||||
►
Sign in to add a comment |
||||
Comment 1 by bpastene@chromium.org
, Dec 4 2017