New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791671 link

Starred by 0 users
Status: Fixed
Owner:
█ catmulli...@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

chrome.contextMenus.update can't uncheck checkbox items

Reported by woxxom@gmail.com, Dec 4 2017 
Google Chrome 64.0.3282.5 (Official Build) canary (64-bit)

========================================

1. install the attached extension
2. click its icon normally
3. right-click its icon to invoke the menu

Expected: "Custom menu item" is unchecked
Observed: "Custom menu item" is checked

========================================

Bisect info: 490661 (good) - 490663 (bad)
https://chromium.googlesource.com/chromium/src/+log/522a1913..d36bea9f?pretty=fuller
Suspecting r490662 = c5c379e5bff7b3cf322feed1611f9eedfbec294f = https://crrev.com/c/576271 by catmullings@chromium.org
"[extensions] Fix context menu radio button update"
Landed in 62.0.3172.0
contextmenu.zip
777 bytes Download

Comment 1 by krajshree@chromium.org, Dec 5 2017

Labels: -Type-Bug -Pri-3 Triaged-ET hasbisect Needs-Triage-M64 M-65 OS-Mac Pri-1 Type-Bug-Regression
Owner: catmulli...@chromium.org
Status: Assigned (was: Unconfirmed)
As per comment #0, the bisect info is as follows:
Bisect info: 490661 (good) - 490663 (bad)

Change Log:
https://chromium.googlesource.com/chromium/src/+log/522a1913..d36bea9f?pretty=fuller

Change-Id: Ic2301a7191efef6a4a712ab400339e897cb6a5cb
Reviewed-on: https://chromium-review.googlesource.com/576271

catmullings@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is seen on OS-Mac and not seen in OS-Win and OS-Linux.

Thanks...!!

Comment 2 by catmulli...@chromium.org, Dec 6 2017 

Thanks woxxom@ for the report and krajshree@ for the confirmation.
I can look into fixing this.

Comment 3 by catmulli...@chromium.org, Dec 9 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f8da47fd27db4ada81be928bcc6eb1d962eb45

commit 07f8da47fd27db4ada81be928bcc6eb1d962eb45
Author: Catherine Mullings <catmullings@chromium.org>
Date: Sat Dec 09 00:41:36 2017

Extensions: Fix chrome.contextMenus.update false to uncheck checkboxes

chrome.contextMenus.update(checkboxId, {checked: false}) no longer
works to uncheck a checkbox. This CL fixes this regression.

Bug:  791671 
Change-Id: Iee0c9b430014324bb27d94cf2c9d1bd47ae8aa19
Reviewed-on: https://chromium-review.googlesource.com/815377
Commit-Queue: catmullings <catmullings@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522939}
[modify] https://crrev.com/07f8da47fd27db4ada81be928bcc6eb1d962eb45/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
[modify] https://crrev.com/07f8da47fd27db4ada81be928bcc6eb1d962eb45/chrome/browser/extensions/extension_context_menu_browsertest.cc
[add] https://crrev.com/07f8da47fd27db4ada81be928bcc6eb1d962eb45/chrome/test/data/extensions/context_menus/checkboxes/manifest.json
[add] https://crrev.com/07f8da47fd27db4ada81be928bcc6eb1d962eb45/chrome/test/data/extensions/context_menus/checkboxes/test.js
►

Sign in to add a comment