New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791662 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Restrict CryptAuth enrollments for enterprise Chromebooks

Project Member Reported by tengs@chromium.org, Dec 4 2017

Issue description

Enterprise Chromebooks (e.g. EDU) are adding a significant amount of enrollments to CryptAuth due to the unique pattern of shared usage of devices. 

We need to stop enrolling these devices unless the domain has explicitly turned on a feature that requires enrollment.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/433001c68d7cf2a8a4c9a83eb28056348d7f5c34

commit 433001c68d7cf2a8a4c9a83eb28056348d7f5c34
Author: Tim Song <tengs@chromium.org>
Date: Tue Dec 05 04:23:58 2017

Restrict CryptAuth enrollments and device syncs for enterprise-enrolled devices.

CryptAuth enrollment should only happen if a dependent feature is enabled (e.g.
EasyUnlock, Instant Tethering) by enterprise policy.

BUG= 791662 

Change-Id: Ie5562033c7b2c22f9b69d209ffed4ad3cbe6be9d
Reviewed-on: https://chromium-review.googlesource.com/798019
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521615}
[modify] https://crrev.com/433001c68d7cf2a8a4c9a83eb28056348d7f5c34/chrome/browser/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/433001c68d7cf2a8a4c9a83eb28056348d7f5c34/chrome/browser/cryptauth/chrome_cryptauth_service.h

Comment 2 by tengs@chromium.org, Dec 5 2017

Labels: M-64 Merge-Request-64
Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0794b3356ddac34f347e8c950b1d4cabfe27b2a

commit a0794b3356ddac34f347e8c950b1d4cabfe27b2a
Author: Tim Song <tengs@chromium.org>
Date: Tue Dec 05 23:07:28 2017

Restrict CryptAuth enrollments and device syncs for enterprise-enrolled devices.

CryptAuth enrollment should only happen if a dependent feature is enabled (e.g.
EasyUnlock, Instant Tethering) by enterprise policy.

BUG= 791662 
TBR=tengs@chromium.org

(cherry picked from commit 433001c68d7cf2a8a4c9a83eb28056348d7f5c34)

Change-Id: Ie5562033c7b2c22f9b69d209ffed4ad3cbe6be9d
Reviewed-on: https://chromium-review.googlesource.com/798019
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521615}
Reviewed-on: https://chromium-review.googlesource.com/809924
Cr-Commit-Position: refs/branch-heads/3282@{#43}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/a0794b3356ddac34f347e8c950b1d4cabfe27b2a/chrome/browser/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/a0794b3356ddac34f347e8c950b1d4cabfe27b2a/chrome/browser/cryptauth/chrome_cryptauth_service.h

Comment 5 by tengs@chromium.org, Dec 5 2017

Status: Fixed (was: Started)

Sign in to add a comment