"fast/webgl/webgl-composite-modes-repaint.html" is flaky |
|||||
Issue description"fast/webgl/webgl-composite-modes-repaint.html" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOAsSBUZsYWtlIi1mYXN0L3dlYmdsL3dlYmdsLWNvbXBvc2l0ZS1tb2Rlcy1yZXBhaW50Lmh0bWwM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Dec 6 2017
Note: I doubt that's related because there are over 1,000 instances (!) of that error message in this log: https://chromium-swarm.appspot.com/task?id=3a3b8c96c9b2cf10&refresh=10&show_raw=1 and only three test failures.
,
Dec 6 2017
Could there be some sort of race condition in the test as it's written? https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/webgl/webgl-composite-modes-repaint.html?q=webgl-composite-modes-repaint.html&sq=package:chromium&l=1 Is it problematic that it uses onload() and only from in there informs the test harness that it calls testRunner.waitUntilDone()? Should it just be rewritten with the new testharness.js
,
Dec 6 2017
To get this out of the sheriff queue, I'm going to assign this; please triage further as needed
,
Dec 6 2017
(Not disabling test since failures look pretty occasional)
,
Dec 6 2017
Justin, I'm not that familiar with Blink's test harnesses any more so please tell me if you want me to take this over. But any help or advice you can offer here would be appreciated. I don't know what's legal and not in these tests.
,
Dec 13 2017
Looking at the flakiness dashboard it seems pretty obvious that this is just a test that takes a long time to run. We should just mark it as slow rather than flaky.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a230ed80863b3fb23f445e7b130fc0c5a9ee321e commit a230ed80863b3fb23f445e7b130fc0c5a9ee321e Author: Justin Novosad <junov@chromium.org> Date: Wed Dec 13 20:56:13 2017 Mark fast/webgl/webgl-composite-modes-repaint.html as slow Slow on linux and win BUG= 791659 TBR=kbr@chromium.org Change-Id: I40014560e5aa3b3825fe236bfab65360fda16e13 Reviewed-on: https://chromium-review.googlesource.com/825170 Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523870} [modify] https://crrev.com/a230ed80863b3fb23f445e7b130fc0c5a9ee321e/third_party/WebKit/LayoutTests/SlowTests
,
Dec 13 2017
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa8b12920e8c2042e47816d004b113c155e81aee commit fa8b12920e8c2042e47816d004b113c155e81aee Author: Alexis Hetu <sugoi@google.com> Date: Fri Jul 06 14:14:32 2018 Attempt to unmark some tests as slow/timeout Now that SwiftShader is on Linux/Windows/MacOS and that a recent performance improvement has been landed in SwiftShader, verify which tests still require the Slow/Timeout markers and which don't. TBR=kbr@chromium.org Bug:chromium:24182 chromium:433711 chromium:763197 chromium:311482 chromium:243871 chromium:664857 chromium:9798 chromium:237270 chromium:241576 chromium:241869 chromium:246749 chromium:535478 chromium:363029 chromium:364225 chromium:552556 chromium:570656 chromium:584807 chromium:614910 chromium:791659 chromium:726075 chromium:808153 chromium:816045 chromium:693568 chromium:626703 chromium:703533 chromium:786641 chromium:799137 chromium:831686 chromium:831230 chromium:818324 chromium:810437 chromium:847205 chromium:848799 chromium:828962 chromium:849284 chromium:855055 Change-Id: I5d36d20bd87b234fefe4da3ea7e4af039c0188cb Reviewed-on: https://chromium-review.googlesource.com/1102341 Reviewed-by: Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572962} [modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/TestExpectations |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kbr@chromium.org
, Dec 6 2017Components: Blink>WebGL Internals>Metrics