New issue
Advanced search Search tips

Issue 791638 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Separate back button from app list button.

Project Member Reported by sammiequon@chromium.org, Dec 4 2017

Issue description

This will fix some ink drop/ accessibility issues.

design doc: https://docs.google.com/document/d/1xVl4owX-lkwbvMawMqtsBEjkizxk9E4j8aZR3z9qKDM/edit

 
Cc: zork@chromium.org
Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b911f2f81d8bde89b659e8a40d7db9748c9e072

commit 9b911f2f81d8bde89b659e8a40d7db9748c9e072
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Dec 15 02:53:15 2017

shelf: Separate back button and app list button.

Seperate the back button and app list button into separate elements.
Draws the background in ShelfView::OnPaint. This fixes issues with ink
drop and accessibility focusing not working correctly. Made changes to
ShelfView focus search to accommodate this.

Add back_button_unittest.
Removed app_list_button/back button ink drop unittest which tested
if different parts of the old app list button's ink drop acted
different if different parts were pressed. Not needed as the two
separate buttons' ink drops should work normally.
Removed app_list_button rtl unittest as the buttons should be flipped
normally by the views rtl handling.

Test: ash_unittests *Shelf* *ApplistButton* *BackButton*
Bug:  791638 ,  758402 
Change-Id: I07bdd0b490ffb2619a13cebacf388e2e08190114
Reviewed-on: https://chromium-review.googlesource.com/761856
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524301}
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/BUILD.gn
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/ash_strings.grd
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/cpp/shelf_model.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/cpp/shelf_model.h
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/cpp/shelf_model_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/cpp/shelf_struct_traits.h
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/cpp/shelf_types.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/cpp/shelf_types.h
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/public/interfaces/shelf.mojom
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/resources/vector_icons/shelf_back.1x.icon
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/resources/vector_icons/shelf_back.icon
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/app_list_button.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/app_list_button.h
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/app_list_button_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/assistant_overlay.cc
[add] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/back_button.cc
[add] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/back_button.h
[add] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/back_button_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_controller.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_controller_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_view.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_view.h
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_view_test_api.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/9b911f2f81d8bde89b659e8a40d7db9748c9e072/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

Status: Fixed (was: Assigned)
Status: Archived (was: Fixed)

Sign in to add a comment