New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791637 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 791778
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Group log messages by page_id on chrome://interventions-internals

Project Member Reported by thanhdle@chromium.org, Dec 4 2017

Issue description

Decision log messages are grouped so that they don't flood the logs table.
                                                                             
Log messages can be grouped by page_id retrieved from PreviewsIOData. The messages that don't need grouping can use 0 as page_id, since the generated IDs start at 1.
 

Comment 1 Deleted

Status: Started (was: Duplicate)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da914a46a617efe83cf0186e40794cc8396d020

commit 6da914a46a617efe83cf0186e40794cc8396d020
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Dec 06 20:59:44 2017

Group log messages by page_id on chrome://interventions-internals.

Decision log messages are grouped so that they don't flood the logs
table.

Log messages can be grouped by page_id retrieved from PreviewsIOData.  The
messages that don't need grouping can use 0 as page_id, since the generated IDs
start at 1.

Screenshot: https://drive.google.com/a/chromium.org/file/d/17mp8fIHWIJjbZp_t711PGLEaWuZoG1v2
Screenshot: https://drive.google.com/a/chromium.org/file/d/1KI_f1XCYVSk2hLqq2LGaTr0g7LZ6oQcd

Bug:  791637 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5eff89d6a8ffc38209819d8787fdac30caaa939a
Reviewed-on: https://chromium-review.googlesource.com/806758
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522187}
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/chrome/test/data/webui/interventions_internals_browsertest.js
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/content/previews_io_data.h
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/core/previews_logger.cc
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/core/previews_logger.h
[modify] https://crrev.com/6da914a46a617efe83cf0186e40794cc8396d020/components/previews/core/previews_logger_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment