Issue metadata
Sign in to add a comment
|
Omnibox query shifts left when trying to scroll the suggestions |
||||||||||||||||||||||
Issue descriptionApp Version: 64.0.3282.7 beta iOS Version: 11.2, 10.3.3 Device: iPhone7Plus, iPhoneX URL: na Steps to reproduce: 1. Launch Google Chrome 2. Tap on omnibox and type the word "test" 3. Scroll the omnibox suggestions page. Observed results: Observe that the word "test" in omnibox is shifted towards left Expected results: Omnibox text should be in alignment with the suggestions Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M62 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M63 NO Link to video/image: https://drive.google.com/file/d/167XRwmxIfFvBA-gRxbOMQ-S1MQPWkZjV/view
,
Dec 11 2017
To Gauthier who's started a CL about this already. Thanks!
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20dbdbbfa6343f1464d5b068a92d5714e05a5e73 commit 20dbdbbfa6343f1464d5b068a92d5714e05a5e73 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Dec 12 17:09:11 2017 Remove leading offset from the omnibox textfield The omnibox textfield moves its text content area to account for the leftView; however the leftView is now replaced with leadingButton in the LocationBarView, so the leading offset should not be adjusted on the textfield level. This CL makes LocationBarView inset the textfield from the leading side as necessary, and makes the textfield always align the text area to the leading edge. Bug: 791630 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I28ccb76eef95d0b50f24ff3ca3b437e03efce8cb Reviewed-on: https://chromium-review.googlesource.com/818342 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523461} [modify] https://crrev.com/20dbdbbfa6343f1464d5b068a92d5714e05a5e73/ios/chrome/browser/ui/omnibox/location_bar_view.mm [modify] https://crrev.com/20dbdbbfa6343f1464d5b068a92d5714e05a5e73/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm [modify] https://crrev.com/20dbdbbfa6343f1464d5b068a92d5714e05a5e73/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
,
Dec 12 2017
,
Dec 13 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2017
Verified on M65.0.3293.0 canary iPhone7 plus, iPhoneX iOS: 10.3.3, 11.2 gambard@ the original bug reported is fixed correctly, but I another minor issue on similar lines. So I will create a new bug for that.
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e59b3199792b9581606100c40b90814fbdcc91d3 commit e59b3199792b9581606100c40b90814fbdcc91d3 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 18 15:52:31 2017 Cherry-pick: Remove leading offset from the omnibox textfield The omnibox textfield moves its text content area to account for the leftView; however the leftView is now replaced with leadingButton in the LocationBarView, so the leading offset should not be adjusted on the textfield level. This CL makes LocationBarView inset the textfield from the leading side as necessary, and makes the textfield always align the text area to the leading edge. Bug: 791630 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I28ccb76eef95d0b50f24ff3ca3b437e03efce8cb Reviewed-on: https://chromium-review.googlesource.com/818342 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523461} Reviewed-on: https://chromium-review.googlesource.com/832432 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#263} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/e59b3199792b9581606100c40b90814fbdcc91d3/ios/chrome/browser/ui/omnibox/location_bar_view.mm [modify] https://crrev.com/e59b3199792b9581606100c40b90814fbdcc91d3/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm [modify] https://crrev.com/e59b3199792b9581606100c40b90814fbdcc91d3/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
,
Dec 20 2017
Verified on M64.0.3282.41 beta iPhone 6 plus, iPhone 8 iOS: 10.3.3, 11.2.1 Verified that omnibox text should is aligned with the suggestions. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by justincohen@chromium.org
, Dec 6 2017Labels: M-64 ReleaseBlock-Stable
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)