New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791604 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chromeos-4.14: Interrupt storm on Cyan and other cherryview chromebooks

Project Member Reported by groeck@chromium.org, Dec 4 2017

Issue description

I get an interrupt storm when running an image based on 4.14 on cyan (more specifically it is a prototype of chromeos-4.14, ie 4.14 with Chrome OS patches on top of it).

[   60.089234] ->handle_irq():  ffffffffbe2f803f, 
[   60.090455] 0xffffffffbf2af380
[   60.090510] handle_bad_irq+0x0/0x2e5
[   60.090522] ->irq_data.chip(): ffffffffbf2af380, 
[   60.090553]    IRQ_NOPROBE set
[   60.090584] ->handle_irq():  ffffffffbe2f803f, 
[   60.090590] handle_bad_irq+0x0/0x2e5
[   60.090596] ->irq_data.chip(): ffffffffbf2af380, 
[   60.090602] 0xffffffffbf2af380
[   60.090608] ->action():           (null)
[   60.090779] handle_bad_irq+0x0/0x2e5

and so on. The output is that messy because there are just too many bad interrupts.

/proc/interrupts shows:

115:      78302      77589      77478      76348  chv-gpio    0
 135:          0          1          0          0  chv-gpio   20  TS3A227E
 171:     196025     196802     196579     197818  chv-gpio    0
 180:          0          0          0          0  chv-gpio    9  ACPI:Event
 182:          3          1          1          5  chv-gpio   11  i8042
 183:          0          0          0          0  chv-gpio   12  ELAN0000:00
 184:          0          0          0          0  chv-gpio   13  ELAN0001:00
 300:          0          0          0          0  chv-gpio   46  max98090_interrupt
 304:          0          0          0          0  chv-gpio   50  INT33BB:01 cd

Notice interrupts 115 and 171; those are the "bad" ones.

Reverting commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/intel/pinctrl-cherryview.c?id=845e405e5e6c9dc9ed10306a4b5bfeaefebc2e84 
fixes the interrupt storm problem, but then the keyboard and touchpad do not work.

The same problem is seen on Celes.

Also submitted as https://bugzilla.kernel.org/show_bug.cgi?id=197953.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b499b5e040ca2cf998bdea56532d96a674b79c0b

commit b499b5e040ca2cf998bdea56532d96a674b79c0b
Author: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Tue Dec 05 04:02:54 2017

FROMLIST: pinctrl: cherryview: Mask all interrupts on Intel_Strago based systems

Guenter Roeck reported an interrupt storm on a prototype system which is
based on Cyan Chromebook. The root cause turned out to be a incorrectly
configured pin that triggers spurious interrupts. This will be fixed in
coreboot but currently we need to prevent the interrupt storm from
happening by masking all interrupts (but not GPEs) on those systems.

BUG= chromium:791604 
TEST=Build and run image on Cyan

Change-Id: I6c43482dedc75a51c21daa9c4bef3e6e0ff5ccb5
Link: https://bugzilla.kernel.org/show_bug.cgi?id=197953
Fixes: bcb48cca23ec ("pinctrl: cherryview: Do not mask all interrupts in probe")
Reported-and-tested-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(am from https://patchwork.ozlabs.org/patch/844155/)
Reviewed-on: https://chromium-review.googlesource.com/791891
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/b499b5e040ca2cf998bdea56532d96a674b79c0b/drivers/pinctrl/intel/pinctrl-cherryview.c

Cc: marc.her...@intel.com
Status: Fixed (was: Started)
This should be fixed by now.

Sign in to add a comment