New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791541 link

Starred by 3 users
Status: Assigned
Owner:
█ tsabolcec@google.com
Last visit > 30 days ago
Cc:
cfroussios@chromium.org
█ rpl@google.com
Components:
EstimatedDays: ----
NextAction: 2018-02-01
OS: Mac
Pri: 3
Type: Bug-Regression

Blocking:
issue 714610



Sign in to add a comment

Sync fails to save password

Reported by varu...@gmail.com, Dec 4 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3278.0 Safari/537.36

Steps to reproduce the problem:
1. Log into Chrome / Sync
2. Wait for sync to complete
3. Try to open a site which has a password saved to sync.

What is the expected behavior?
Should auto fill the password saved in sync.

What went wrong?
Error: FlushToLocal@../../components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc:183, datatype error was encountered: Failed updating WebDatabase	

Did this work before? Yes 

Chrome version: 64.0.3278.0  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

Tried moving from Stable to Dev. Tried deleting and recreating /Users/myusername/Library/Application Support/Google/Chrome
No luck.

Comment 1 by pav...@chromium.org, Dec 5 2017

Owner: pav...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by pav...@chromium.org, Dec 8 2017

Status: Started (was: Assigned)
varun21@: Could you provide some more data?

1. Could you sign out, sign back in, open about:sync and check if the error message appears shortly after you sign in. (Make sure not to open sites with passwords.
If that's the case could you open about:histograms, look for entry "Sqlite.Error.Web" and paste it here if you find one.

Comment 3 by pav...@chromium.org, Dec 8 2017

Labels: Needs-Feedback

Comment 4 by varu...@gmail.com, Dec 9 2017 

@pav: I did a fresh install of Chrome Dev Version 64.0.3282.14 (Official Build) dev (64-bit) on Mac OSX Sierra: 10.12.6 (16G1036) as per the following steps:

1. Deleted all cache / Profile folders as in https://crunchify.com/how-to-purge-all-your-google-chrome-user-data-on-mac-os-x/
2. Installed Dev version
3. Launched Chrome
4. Did not sign in to sync
5. Logged into gmail.
6. Clicked on remember me during login and saved password on the password save prompt.
7. Clicked the key in the URL bar to see if the password was saved. It said no password saved.
8. Relaunched Chrome.
9. Gmail was logged out. No auto fill, no saved password.

Note: Chrome was running on default settings out of the box.
Screen Shot 2017-12-09 at 7.59.29 AMIST.png
33.5 KB View Download

Comment 5 by varu...@gmail.com, Dec 9 2017 

So I apologize. It looks to be as if Google Chrome is not saving any data out of the box and it apparently may not have anything to do with Sync. Mods, can you please move the bug to suitable section? Thanks.

Comment 6 by pav...@chromium.org, Dec 13 2017

Components: -Services>Sync UI>Browser>Passwords
Status: Unconfirmed (was: Started)
Forwarding to Passwords. According to C#4 password to gmail is not being saved.
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 13 2017

Cc: pav...@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "pavely@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by varu...@gmail.com, Dec 13 2017 

@Pavely: No passwords are being saved at all — none of the sites including gmail.

Comment 9 by rpl@google.com, Jan 4 2018

Cc: rpl@google.com

Comment 10 by battre@chromium.org, Jan 5 2018

Cc: cfroussios@chromium.org

Comment 11 by cfroussios@chromium.org, Jan 5 2018 

Could you tell us if Keychain is unlocked while you are performing these steps?

Comment 12 by vabr@chromium.org, Jan 9 2018

Blocking: 714610
Labels: -Pri-2 Needs-Feedback Hotlist-Polish Pri-3
Owner: ----

Comment 13 by battre@chromium.org, Jan 23 2018

NextAction: 2018-02-01
Status: Available (was: Unconfirmed)
Setting reminder to Feb 1, to see whether we get feedback from reporter by then.

Comment 14 by monor...@bugs.chromium.org, Feb 1 2018 

The NextAction date has arrived: 2018-02-01
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ee424a29fc9a44002443eabad70bb19cf35a69f

commit 1ee424a29fc9a44002443eabad70bb19cf35a69f
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Thu Jul 26 17:45:29 2018

[Password Manager] [OSCrypt] Deleting undecryptable logins from database.

This CL include following changes:
- Added method to LoginDatabase that deleted entries which fail decryption process on MacOS.
- Added tests for the above changes.
- Added method SetBackendLocked to OSCryptMocker to test behavior when Keychain on Mac is locked.

Change-Id: I2173467771457d32d2b2d953d4e27d888965e475
Bug: 791541
Reviewed-on: https://chromium-review.googlesource.com/1146642
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578357}
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/os_crypt/os_crypt.h
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/os_crypt/os_crypt_mac.mm
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/os_crypt/os_crypt_mocker.cc
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/os_crypt/os_crypt_mocker.h
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/password_manager/core/browser/login_database.h
[modify] https://crrev.com/1ee424a29fc9a44002443eabad70bb19cf35a69f/components/password_manager/core/browser/login_database_unittest.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/896b595f8810d1e306c561345723d19ec37b6d81

commit 896b595f8810d1e306c561345723d19ec37b6d81
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Mon Aug 06 20:09:32 2018

[Password Manager] Add feature for deleting undecryptable logins.

This CL includes:
- Add new base::Feature: kDeleteUndecryptableLogins.
- Expand metric enum PasswordSyncState with failed decryption & cleanup states.
- Call LoginDatabase::DeleteUndecryptableLogins when merging sync data.
- Add tests for new feature.

Bug: 791541
Change-Id: I5a5f9cea618efdc4b467eee4bb54674be8574b84
Reviewed-on: https://chromium-review.googlesource.com/1160486
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580963}
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/login_database.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/mock_password_store.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/password_store_default.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/password_store_default.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/password_store_sync.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/password_syncable_service.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/browser/test_password_store.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/components/password_manager/core/common/password_manager_features.h
[modify] https://crrev.com/896b595f8810d1e306c561345723d19ec37b6d81/tools/metrics/histograms/enums.xml
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ee2854c8267198a97ee8542480d83552b25456

commit 86ee2854c8267198a97ee8542480d83552b25456
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Mon Aug 13 21:31:51 2018

[Password Manager] Add metrics for deleting undecryptable logins.

The following metrics are collected:
- Return value of LoginDatabase::DeleteUndecryptableLogins.
- Number of deleted logins, if there is at least one deleted login.

Bug: 791541
Change-Id: I899d372fd14771cbdd43b03e0340b4b473d1de4f
Reviewed-on: https://chromium-review.googlesource.com/1165346
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582709}
[modify] https://crrev.com/86ee2854c8267198a97ee8542480d83552b25456/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/86ee2854c8267198a97ee8542480d83552b25456/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/86ee2854c8267198a97ee8542480d83552b25456/components/password_manager/core/browser/password_manager_metrics_util.cc
[modify] https://crrev.com/86ee2854c8267198a97ee8542480d83552b25456/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/86ee2854c8267198a97ee8542480d83552b25456/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/86ee2854c8267198a97ee8542480d83552b25456/tools/metrics/histograms/histograms.xml
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e690c9cd180eb1139be404359691cf01a129b444

commit e690c9cd180eb1139be404359691cf01a129b444
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Fri Aug 17 13:28:38 2018

[Password Manager] Enable DeleteUndecyrptableLogins feature

Bug: 791541
Change-Id: Ibf11c698d40b29299510f73e8a6b308c618d506b
Reviewed-on: https://chromium-review.googlesource.com/1178284
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#584045}
[modify] https://crrev.com/e690c9cd180eb1139be404359691cf01a129b444/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] https://crrev.com/e690c9cd180eb1139be404359691cf01a129b444/components/password_manager/core/common/password_manager_features.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f271d300f12c96004ef68b6f6676ac123849463

commit 6f271d300f12c96004ef68b6f6676ac123849463
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Fri Aug 17 14:35:47 2018

[Password Manager] Add pref to store date when undecryptable logins were deleted on Mac

This CL includes:
- Add a util class which sets the preference on the main thread.
- Use utility class in LoginDatabase to set the date on successul deletion of undecryptable passwords.
- Expand DB tests to make sure that the pref is stored.

Bug: 791541
Change-Id: I32c2afc70c6091175cae09a7120de7622b568448
Reviewed-on: https://chromium-review.googlesource.com/1178052
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584060}
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/login_database.h
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/password_manager.h
[add] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/password_recovery_util_mac.cc
[add] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/browser/password_recovery_util_mac.h
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/common/password_manager_pref_names.cc
[modify] https://crrev.com/6f271d300f12c96004ef68b6f6676ac123849463/components/password_manager/core/common/password_manager_pref_names.h
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e773eca2e4306360d32fa6c93810ee3d86f4c7

commit 60e773eca2e4306360d32fa6c93810ee3d86f4c7
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Thu Aug 23 18:13:07 2018

[Password Manager] Fix negative performance by not reading the database twice when merging passwords with Sync

After enabling the feature which deletes undecryptable logins and recovers Sync users who lost their passwords, there were a significant negative performance impact (the sync association time for passwords has almost doubled).
This fix skips checking if each password could be decrypted (which is currently done for every user) if the first read from database succeeds.
For ~95% of users it's not even required to check which passwords are decryptable, because reading from database immediately succeeds.
For other ~5% of users it's expected that those check would have to be done only once while recovering.

Bug: 791541
Change-Id: I460f3692eef330b82ae18fa9f6d52de834ee06e1
Reviewed-on: https://chromium-review.googlesource.com/1186463
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#585546}
[modify] https://crrev.com/60e773eca2e4306360d32fa6c93810ee3d86f4c7/components/password_manager/core/browser/password_syncable_service.cc
[modify] https://crrev.com/60e773eca2e4306360d32fa6c93810ee3d86f4c7/components/password_manager/core/browser/password_syncable_service_unittest.cc

Comment 21 by pav...@chromium.org, Aug 23

Cc: -pav...@chromium.org
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1

commit 62ea18dab2a9ae33e58200ff4eef805b7aff4ba1
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Fri Aug 24 08:22:41 2018

[OSCrypt] Add utility tool which is used to check if an encryption key was created in the past

This CL includes:
- Add build rule +components/prefs to os_crypt component.
- Add a preference key creation.
- Implement utility tool to get/set the preference.

Bug: 791541
Change-Id: I50835a6edeb62aaef28566d08162accf7789c8eb
Reviewed-on: https://chromium-review.googlesource.com/1183361
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#585760}
[modify] https://crrev.com/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1/components/os_crypt/BUILD.gn
[modify] https://crrev.com/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1/components/os_crypt/DEPS
[add] https://crrev.com/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1/components/os_crypt/key_creation_util_mac.cc
[add] https://crrev.com/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1/components/os_crypt/key_creation_util_mac.h
[add] https://crrev.com/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1/components/os_crypt/os_crypt_pref_names_mac.cc
[add] https://crrev.com/62ea18dab2a9ae33e58200ff4eef805b7aff4ba1/components/os_crypt/os_crypt_pref_names_mac.h

Comment 23 by cfroussios@chromium.org, Aug 28

Owner: tsabolcec@google.com
Status: Assigned (was: Available)
Adding an owner. Tonko is currently working on this.
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca917bd3ebea51bfcf7f8b80e39e217467153d4

commit 3ca917bd3ebea51bfcf7f8b80e39e217467153d4
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Mon Sep 10 13:57:06 2018

[OSCrypt] Add feature for preventing key overwrites in Keychain on Mac

This Cl includes:
- Add a feature flag which is disabled by default.
- Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword().
- Add tests for the above changes.
- Register the local state early from the main thread in os_crypt.

Bug: 791541
Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe
Reviewed-on: https://chromium-review.googlesource.com/1188318
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589898}
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/BUILD.gn
[add] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/encryption_key_creation_util.h
[add] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/encryption_key_creation_util_ios.cc
[add] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/encryption_key_creation_util_ios.h
[rename] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/encryption_key_creation_util_mac.cc
[rename] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/encryption_key_creation_util_mac.h
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/keychain_password_mac.h
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/keychain_password_mac.mm
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/keychain_password_mac_unittest.mm
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/os_crypt.h
[add] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/os_crypt_features_mac.cc
[add] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/os_crypt_features_mac.h
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/os_crypt_mac.mm
[modify] https://crrev.com/3ca917bd3ebea51bfcf7f8b80e39e217467153d4/components/os_crypt/os_crypt_pref_names_mac.h
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e27be9d11b247dc88ed7cfb42af4e4a207f32499

commit e27be9d11b247dc88ed7cfb42af4e4a207f32499
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Tue Sep 11 12:04:48 2018

Revert "[OSCrypt] Add feature for preventing key overwrites in Keychain on Mac"

This reverts commit 3ca917bd3ebea51bfcf7f8b80e39e217467153d4.

Reason for revert: The CL caused crashes on Chrome canary on Mac:  crbug.com/882787 

Original change's description:
> [OSCrypt] Add feature for preventing key overwrites in Keychain on Mac
>
> This Cl includes:
> - Add a feature flag which is disabled by default.
> - Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword().
> - Add tests for the above changes.
> - Register the local state early from the main thread in os_crypt.
>
> Bug: 791541
> Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe
> Reviewed-on: https://chromium-review.googlesource.com/1188318
> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589898}

TBR=battre@chromium.org,vasilii@chromium.org,rsesek@chromium.org,cfroussios@chromium.org,tsabolcec@google.com

Change-Id: I1be5c8294985e81115a8856f4105fbff8a3a28a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 791541
Reviewed-on: https://chromium-review.googlesource.com/1219086
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#590270}
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/BUILD.gn
[delete] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/components/os_crypt/encryption_key_creation_util.h
[delete] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/components/os_crypt/encryption_key_creation_util_ios.cc
[delete] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/components/os_crypt/encryption_key_creation_util_ios.h
[rename] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/key_creation_util_mac.cc
[rename] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/key_creation_util_mac.h
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/keychain_password_mac.h
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/keychain_password_mac.mm
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/keychain_password_mac_unittest.mm
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/os_crypt.h
[delete] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/components/os_crypt/os_crypt_features_mac.cc
[delete] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/components/os_crypt/os_crypt_features_mac.h
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/os_crypt_mac.mm
[modify] https://crrev.com/e27be9d11b247dc88ed7cfb42af4e4a207f32499/components/os_crypt/os_crypt_pref_names_mac.h
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43615a9db0c2690640af16fd8c24cc014c046414

commit 43615a9db0c2690640af16fd8c24cc014c046414
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Wed Sep 12 12:43:41 2018

Reland "[OSCrypt] Add feature for preventing key overwrites in Keychain on Mac"

Original CL caused crashes on Mac canary ( crbug.com/882787 ) because network service which uses OSCrypt was initialized before OSCrypt.
In this CL OSCrypt initialization is done earlier (moved from PreProfileInit to PreMainMessageLoopStart).


This is a reland of 3ca917bd3ebea51bfcf7f8b80e39e217467153d4

Original change's description:
> [OSCrypt] Add feature for preventing key overwrites in Keychain on Mac
>
> This Cl includes:
> - Add a feature flag which is disabled by default.
> - Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword().
> - Add tests for the above changes.
> - Register the local state early from the main thread in os_crypt.
>
> Bug: 791541
> Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe
> Reviewed-on: https://chromium-review.googlesource.com/1188318
> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589898}

Bug: 791541
Change-Id: I2d88375423b70536a5c48f5533991fcf6d097e27
Reviewed-on: https://chromium-review.googlesource.com/1219746
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#590651}
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/BUILD.gn
[add] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/encryption_key_creation_util.h
[add] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/encryption_key_creation_util_ios.cc
[add] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/encryption_key_creation_util_ios.h
[rename] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/encryption_key_creation_util_mac.cc
[rename] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/encryption_key_creation_util_mac.h
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/keychain_password_mac.h
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/keychain_password_mac.mm
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/keychain_password_mac_unittest.mm
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/os_crypt.h
[add] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/os_crypt_features_mac.cc
[add] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/os_crypt_features_mac.h
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/os_crypt_mac.mm
[modify] https://crrev.com/43615a9db0c2690640af16fd8c24cc014c046414/components/os_crypt/os_crypt_pref_names_mac.h
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b32d055643eee955bd89c5b572810e19740727ec

commit b32d055643eee955bd89c5b572810e19740727ec
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Thu Sep 13 14:27:13 2018

[OSCrypt] Add metrics for encryption key creation util

This CL includes:
- Add metric to log action taken when retrieving the encryption key from the Keychain.
- Add preference to count number of times Chrome prevented overwriting the encryption key and a metric to log that number.
- Add tests for the above changes.

Bug: 791541
Change-Id: I09fc3ec49b6e69ddca024a4c1db0ff2f0d90bf53
Reviewed-on: https://chromium-review.googlesource.com/1216823
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591001}
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/encryption_key_creation_util.h
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/encryption_key_creation_util_ios.cc
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/encryption_key_creation_util_ios.h
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/encryption_key_creation_util_mac.cc
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/encryption_key_creation_util_mac.h
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/keychain_password_mac.mm
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/keychain_password_mac_unittest.mm
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/os_crypt_mac.mm
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/os_crypt_pref_names_mac.cc
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/components/os_crypt/os_crypt_pref_names_mac.h
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b32d055643eee955bd89c5b572810e19740727ec/tools/metrics/histograms/histograms.xml
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee950a24301fbf87e1165371342c30b21193f136

commit ee950a24301fbf87e1165371342c30b21193f136
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Mon Sep 17 13:37:24 2018

[Password Manager] Add feature for recovering passwords for non-Sync Mac users.

Note: Recovering Sync Mac users is already done. This change will recover both sync and non-sync users by deleting corrupted passwords internally in LoginDatabase.

Change internal encryption result for encryptin/decrypting passwords in LoginDatabase (SERVICE_FAILURE is used for unavailable encryption key, otherwise use ITEM_FAILURE if encryption process fails).
When converting SQL statement to list of forms, remove all forms that caused ITEM_FAILURE.
All changes are implemented behind feature flag which is disabled by default.
Tests for the changes are also included.

Bug: 791541
Change-Id: Ie7f8664c6b0946775acab24d103f36d4fe82abc7
Reviewed-on: https://chromium-review.googlesource.com/1224374
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591658}
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/login_database.h
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/login_database_mac.cc
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/password_syncable_service.cc
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/password_syncable_service.h
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/ee950a24301fbf87e1165371342c30b21193f136/components/password_manager/core/common/password_manager_features.h
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860a3b33437ad687f972e9a0a5530061da499659

commit 860a3b33437ad687f972e9a0a5530061da499659
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Thu Sep 20 10:41:35 2018

[Password Manager] Add metrics for recovering passwords on Mac

This CL includes:
- Report number of successfully removed corrupted passwords.
- Report cleanup result - success (with or without passwords removed),
  item failure
- Store date of when user is recovered (preference renamed
  SyncUsersPasswordRecovery => PasswordRecovery)
- Update tests

Bug: 791541
Change-Id: Ie981606268b90c5a471a3aa31df8a2585f31d610
Reviewed-on: https://chromium-review.googlesource.com/1228016
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592749}
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/browser/password_manager_metrics_util.cc
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/browser/password_recovery_util_mac.cc
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/common/password_manager_pref_names.cc
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/components/password_manager/core/common/password_manager_pref_names.h
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/860a3b33437ad687f972e9a0a5530061da499659/tools/metrics/histograms/histograms.xml
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b5fd1ae0fea8825645cf93ec0badc205e5f783

commit 80b5fd1ae0fea8825645cf93ec0badc205e5f783
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Tue Sep 25 11:11:50 2018

[Password Manager] [OSCrypt] Reset os_crypt prefs when clearing browsing data

Bug: 791541
Change-Id: I32171853fe16c3bd58998ae2a3d2132b37d02ea9
Reviewed-on: https://chromium-review.googlesource.com/1233574
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593887}
[modify] https://crrev.com/80b5fd1ae0fea8825645cf93ec0badc205e5f783/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/80b5fd1ae0fea8825645cf93ec0badc205e5f783/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87d97bfebc6d079e6f3ce927cb00c62702a79a6

commit b87d97bfebc6d079e6f3ce927cb00c62702a79a6
Author: Tonko Sabolčec <tsabolcec@google.com>
Date: Fri Sep 28 18:58:45 2018

[Password Manager] [OSCrypt] Enable deleting corrupted passwords on mac

This CL includes:
- Enable feature for deleting corrupted passwords
- Enable feature for preventing overwriting the encryption key
- Disable feature that recovers passwords for Sync users (covered
    with the new feature)
- Update tests

Bug: 791541
Change-Id: I1726515dbd74ad2fa64ef1abf419e88c65d48bf0
Reviewed-on: https://chromium-review.googlesource.com/1240300
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595168}
[modify] https://crrev.com/b87d97bfebc6d079e6f3ce927cb00c62702a79a6/components/os_crypt/os_crypt_features_mac.cc
[modify] https://crrev.com/b87d97bfebc6d079e6f3ce927cb00c62702a79a6/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/b87d97bfebc6d079e6f3ce927cb00c62702a79a6/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] https://crrev.com/b87d97bfebc6d079e6f3ce927cb00c62702a79a6/components/password_manager/core/common/password_manager_features.cc
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ab93849fe9436e27b27ad76d59369a6ad40ce9

commit f1ab93849fe9436e27b27ad76d59369a6ad40ce9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Nov 22 15:54:53 2018

Delete kPreventEncryptionKeyOverwrites feature.

The feature is not to be launched and the associated code is removed.
The metrics collection should be running.

Bug: 791541
Change-Id: I76a1a08a6dc8e2509f3f4be68a5c14fa611dc177
Reviewed-on: https://chromium-review.googlesource.com/c/1346406
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610425}
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/BUILD.gn
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/encryption_key_creation_util.h
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/encryption_key_creation_util_ios.cc
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/encryption_key_creation_util_ios.h
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/encryption_key_creation_util_mac.cc
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/encryption_key_creation_util_mac.h
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/keychain_password_mac.mm
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/keychain_password_mac_unittest.mm
[delete] https://crrev.com/f83188f72a0509c8c69e622f7be94254062dec60/components/os_crypt/os_crypt_features_mac.cc
[delete] https://crrev.com/f83188f72a0509c8c69e622f7be94254062dec60/components/os_crypt/os_crypt_features_mac.h
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/os_crypt_mac.mm
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/os_crypt_pref_names_mac.cc
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/components/os_crypt/os_crypt_pref_names_mac.h
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f1ab93849fe9436e27b27ad76d59369a6ad40ce9/tools/metrics/histograms/histograms.xml
Project Member

Comment 33 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39

commit 5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Dec 04 12:00:04 2018

Add additional metrics in case the encryption key isn't found in the Keychain.

- record an error code from SecKeychainFindGenericPassword.
- record result of the second lookup for the case when the encryption key isn't found but had been created.
It may be useful because the second call doesn't actually try to get the password value.

Bug: 791541
Change-Id: I3501c32fcb9b3c4e2719601ff6ea2393516dea41
Reviewed-on: https://chromium-review.googlesource.com/c/1355187
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613514}
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/BUILD.gn
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/encryption_key_creation_util.h
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/encryption_key_creation_util_ios.cc
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/encryption_key_creation_util_ios.h
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/encryption_key_creation_util_mac.cc
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/encryption_key_creation_util_mac.h
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/keychain_password_mac.h
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/components/os_crypt/keychain_password_mac.mm
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5bb3b4684b7531e852b7d3faeaef9bd0fb8d3d39/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment