Remove custom bindings for Window.open method.
Reported by
bhagirat...@samsung.com,
Dec 4 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: Custom bindings may not be required for window open API. What is the expected behavior? What went wrong? Custom bindings may not be required for window open API. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 59.0.3071.115 Channel: n/a OS Version: Flash Version:
,
Dec 4 2017
Hi Yuki Shiino@, Kentaro Hara@, Shall I work on custom bindings removal for Window.open method which seems to be not required.
,
Dec 4 2017
Yes, please. :)
,
Dec 6 2017
This seems to be a feature request from comment #0 and from comment #2, bhagirathi.s@ seems to work on this issue. Hence, marking it as untriaged for further inputs from dev team. Thanks...!!
,
Dec 6 2017
I am working on this issue. Thanks !
,
Dec 7 2017
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d commit 7e1caf7245ca4c0e9e709b4508ead6ac9090c02d Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Date: Sat Dec 09 14:17:58 2017 Remove custom bindings for DOM API Window.open This CL contains 1. Remove custom bindings for Window.open method. 2. Set window.open.length to 0. Bug: 791532 Change-Id: I084555e5394bf3ff8500260aeeb6b7077f7f935a Reviewed-on: https://chromium-review.googlesource.com/808027 Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522986} [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces-expected.txt [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/LayoutTests/fast/dom/Window/open-after-frame-detached-expected.txt [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/LayoutTests/fast/js/function-length-expected.txt [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/LayoutTests/fast/js/function-length.html [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/Source/core/frame/LocalDOMWindow.h [modify] https://crrev.com/7e1caf7245ca4c0e9e709b4508ead6ac9090c02d/third_party/WebKit/Source/core/frame/Window.idl
,
Dec 11 2017
,
Mar 10 2018
r522986 above seems to cause a regression in 'target' parameter handling as reported in issue 820681 . |
||||
►
Sign in to add a comment |
||||
Comment 1 by sriram...@samsung.com
, Dec 4 2017