New issue
Advanced search Search tips

Issue 791525 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 896242



Sign in to add a comment

web-platform-tests: css/css-variables/variable-generated-content-dynamic-001.html passes in all browsers except Chrome

Project Member Reported by foolip@chromium.org, Dec 4 2017

Issue description

https://wpt.fyi/css/css-variables/variable-generated-content-dynamic-001.html

Results currently not up to date, tested manually in Edge 16 to confirm passing in Edge, Firefox and Safari.
 

Comment 1 by shend@chromium.org, Dec 4 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)

Comment 2 by shend@chromium.org, Dec 4 2017

Labels: Hotlist-Interop
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11fdd266675e95c2d436c0133e174e87352521bb

commit 11fdd266675e95c2d436c0133e174e87352521bb
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Dec 05 00:02:59 2017

Import web-platform-tests/css/css-variables/

Imported from wpt@50b32f0d4f2b485a184fdc71aae1f99e9d9806d6 using
wpt-import in Chromium 419d8078283ee3d6f8677c03c18c3e290c7bc2fb.

None of these tests appear to be duplicates of existing tests. All
files (outside of wpt) containing the string 'var(' were deleted in a
temporary commit, and git diff-filter=R did not find anything that
then looked like a rename.

Use [ Skip ] instead of [ Timeout ] for  crbug.com/791529  to not add much
to the total running time, the difference locally is noticeable.

Bug:  791525 ,  791529 
Change-Id: I74611048fe1656a14527f04bd88c0e04b286ad41
No-Export: true
Reviewed-on: https://chromium-review.googlesource.com/805974
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521539}
[modify] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/OWNERS
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/css-vars-custom-property-case-sensitive-001.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/css-vars-custom-property-inheritance.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/reference/css-vars-custom-property-case-sensitive-ref.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/reference/css-vars-custom-property-inheritance-ref.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/reference/variable-reference-without-whitespace-ref.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/reference/vars-background-shorthand-001-ref.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/reference/vars-font-shorthand-001-ref.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/resources/variable-reference-refresh-iframe.css
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/resources/variable-reference-refresh-iframe.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/test_variable_legal_values.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-from-to.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-over-transition.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-substitute-into-keyframe-shorthand.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-substitute-into-keyframe-transform.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-substitute-into-keyframe.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-substitute-within-keyframe-fallback.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-substitute-within-keyframe-multiple.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-substitute-within-keyframe.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-animation-to-only.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-created-document.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-created-element.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-cssText-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-cssText.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-definition-border-shorthand-serialize-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-definition-border-shorthand-serialize.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-definition-cascading.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-definition-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-definition-keywords.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-definition.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-letter-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-letter.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-line-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-line.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-generated-content-dynamic-001-ref.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-generated-content-dynamic-001.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-invalidation-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-invalidation.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-presentation-attribute-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-presentation-attribute.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-pseudo-element.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference-cssom.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference-refresh.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference-shorthands-cssom.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference-shorthands.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference-variable.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference-without-whitespace.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-reference.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-background-properties.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-basic.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-filters.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-plus-box-shadow.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-replaced-size.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-shadow-properties-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-shadow-properties.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-shorthands.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-substitution-variable-declaration.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-transitions-from-no-value.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-transitions-to-no-value.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-transitions-transition-property-all-before-value.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-transitions-transition-property-variable-before-value.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-transitions-value-before-transition-property-all.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-transitions-value-before-transition-property-variable.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/vars-background-shorthand-001.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/vars-border-shorthand-serialize-expected.txt
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/vars-border-shorthand-serialize.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/vars-font-shorthand-001.html
[add] https://crrev.com/11fdd266675e95c2d436c0133e174e87352521bb/third_party/WebKit/LayoutTests/platform/mac/external/wpt/css/css-variables/variable-presentation-attribute-expected.txt

Owner: futhark@chromium.org
Status: Started (was: Available)
Blocking: 896242
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837b006d9d434f886a0f05d5f6ec6aba8196f1f6

commit 837b006d9d434f886a0f05d5f6ec6aba8196f1f6
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Oct 18 16:48:17 2018

Change content:attr() invalidation to work for custom properties.

This simplifies invalidation of attribute changes affecting attr()
content from always invalidating for attributes used in attr() on all
elements, to always invalidating with kLocalStyleChange for attr changes
on elements which have ::before/::after content generated from attr().

This means we don't need to block lazy parsing for ::before/::after and
we will respond correctly to attr() used indirectly via var().

Bug:  791525 
Change-Id: I13878a56ecf11eb3bd9da356128ac0f32dd5b62d
Reviewed-on: https://chromium-review.googlesource.com/c/1288274
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600796}
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/WebKit/LayoutTests/fast/css/invalidation/content-attr-expected.txt
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/WebKit/LayoutTests/fast/css/invalidation/content-attr.html
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/parser/css_lazy_parsing_state.cc
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/parser/css_lazy_parsing_state.h
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/parser/css_lazy_parsing_test.cc
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/parser/css_parser_impl.cc
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/rule_feature_set.cc
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/rule_feature_set.h
[modify] https://crrev.com/837b006d9d434f886a0f05d5f6ec6aba8196f1f6/third_party/blink/renderer/core/css/style_engine.cc

Status: Fixed (was: Started)

Sign in to add a comment