Issue metadata
Sign in to add a comment
|
Regression:Touch selection menu appears to be chopped after changing flag to RTL.
Reported by
vku...@etouch.net,
Dec 4 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:65.0.3284.0 (Official Build) 46c535d207b3648ddefdf3f9a588b69ac5ef31f2-refs/heads/master@{#521227} (32/64-bit) OS:Win(10 Touch device) What steps will reproduce the problem? (1)Launch chrome, navigate to chrome://flags and change 'Force UI direction' to 'Right-to-Left' (2)Relaunch chrome, navigate to chrome://settings/ tap/touch on 'settings' text and observe the touch selection menu. Actual: Touch selection menu appears to be chopped after changing flag to RTL. Expected: Touch selection menu should be properly displayed after changing flag to RTL. This is a regression issue broken in 'M64' and below is the manual regression range Good Build: 64.0.3256.0 Bad Build: 64.0.3257.0
,
Dec 4 2017
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Dec 4 2017
Wow - nice find! This is indeed a problem. The TouchSelectionMenu is a `TouchSelectionMenuRunnerViews::Menu` which inherits from BubbleDialogDelegateView. - https://cs.chromium.org/chromium/src/ui/views/touchui/touch_selection_menu_runner_views.cc?q=TouchSelectionMenuRunnerViews::Menu&l=40 I suspect we want this particular bubble to be `immune` to the MD-anchoring logic and arrow-removal in bubble_border.cc. Maybe we can just set an appropriate existing, or new, arrow enum value. That flag isn't rolling out in m64 (see Issue 789770 ), so bumping the milestone. (and assigning to bsep to triage while I'm still buried in Mac stuff :/)
,
Dec 5 2017
Load balancing
,
Jan 4 2018
pkasting@ Gentle Ping! This issue is marked as RB-Stable for M65, could you please take a look in to this issue. Thanks!
,
Jan 16 2018
Load balancing Allen: I don't have a touch device to verify, but if this doesn't reproduce pre-Harmony it can be untagged as RBS
,
Jan 22 2018
kylixrd@, Friendly ping to get an update as it is marked as M65-stable blocker. Thanks..!
,
Jan 23 2018
,
Jan 27 2018
Only reproduces with Harmony flag on, so not RBS (we'll address it before launching).
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9affa23867a2b2d7c2dd5c984e27c52956dc563 commit d9affa23867a2b2d7c2dd5c984e27c52956dc563 Author: Allen Bauer <kylixrd@chromium.org> Date: Tue Jan 30 15:20:01 2018 Chopped off touch selection menu in RTL after Harmony changes. Fixed Widget::SetBoundsConstrained & ensured TouchSelectionMenuRunnerViews is clamped to the desktop bounds. Bug: 791507 Change-Id: I3386fc2a93bee2c10ce98ffa3b2974ab40b9606a Reviewed-on: https://chromium-review.googlesource.com/888259 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532880} [modify] https://crrev.com/d9affa23867a2b2d7c2dd5c984e27c52956dc563/ui/views/touchui/touch_selection_menu_runner_views.cc [modify] https://crrev.com/d9affa23867a2b2d7c2dd5c984e27c52956dc563/ui/views/widget/widget.cc
,
Jan 30 2018
,
Jan 31 2018
Update : Retested above issue on Windows(10 Touch)OS using latest Canary #66.0.3335.0 and issue is fixed. Now, touch selection menu appears properly and is not chopped. Kindly review the attached screen-cast. Thank You! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Dec 4 2017Labels: hasbisect-per-revision
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)