New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791486 link

Starred by 2 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Dec 2017
Cc:
justincohen@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Tapping the fake omnibox trigger a jump

Project Member Reported by gambard@chromium.org, Dec 4 2017 
What steps will reproduce the problem?
(1) Open the NTP
(2) Scroll so the fake omnibox is pinned to the top
(3) Tap the fake omnibox

What is the expected result?
The omnibox should be focused at the same place as the fake omnibox.

What happens instead?
There is a visible jump, the omnibox is displayed slightly below the fake omnibox previous position.

+justincohen@: it might be related to the changes for iPhone X.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a615d9641164ff4408d4cfea17e8800dcf04c08

commit 9a615d9641164ff4408d4cfea17e8800dcf04c08
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Dec 04 10:22:28 2017

Fix constraints for NTP fake omnibox

This CL fixes the constraints applied to the fake omnibox of the NTP
when it is scrolled up.

Bug:  791486 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iec1ad1069caebcd7c78a78f2ed155be011050374
Reviewed-on: https://chromium-review.googlesource.com/805246
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521300}
[modify] https://crrev.com/9a615d9641164ff4408d4cfea17e8800dcf04c08/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm

Comment 2 by gambard@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)
Unrelated to iPhone X.

Comment 3 by gambard@chromium.org, Dec 4 2017

Labels: Merge-Request-64

Comment 4 by gambard@chromium.org, Dec 4 2017 

Issue 787166 has been merged into this issue.

Comment 5 by cmasso@google.com, Dec 5 2017

Labels: -Merge-Request-64 Merge-Approved-64
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 5 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8437332d55e3bfe10f4287dc4fe03a6eb6b3da

commit fb8437332d55e3bfe10f4287dc4fe03a6eb6b3da
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Dec 05 07:23:10 2017

Fix constraints for NTP fake omnibox

This CL fixes the constraints applied to the fake omnibox of the NTP
when it is scrolled up.

Bug:  791486 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iec1ad1069caebcd7c78a78f2ed155be011050374
Reviewed-on: https://chromium-review.googlesource.com/805246
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521300}(cherry picked from commit 9a615d9641164ff4408d4cfea17e8800dcf04c08)
Reviewed-on: https://chromium-review.googlesource.com/807924
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#25}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/fb8437332d55e3bfe10f4287dc4fe03a6eb6b3da/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm

Comment 7 by vbhatso...@chromium.org, Dec 7 2017

Status: Verified (was: Fixed)
No flicker is seen when focusing on omnibox.
Verified on iPhone 6+ iOS 11.2, iPhone 7+ 10.3.3, iPhoneX 11.1on build 64.0.3282.14 beta
►

Sign in to add a comment