org.chromium.chrome.browser.bookmarks.BookmarkTest#testSearchBookmarks_Delete failing on tablets |
||||
Issue descriptioneg, https://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Tablet%20Tester/builds/10008 Has been failing consistently all weekend. Test is disabled.
,
Dec 4 2017
Oh, and L too: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/10960 Possibly more but I won't keep spamming the bug with them :)
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48a0f05641e1aafea9c98ad26dfdd2a9b40b0917 commit 48a0f05641e1aafea9c98ad26dfdd2a9b40b0917 Author: Matthew Cary <mattcary@chromium.org> Date: Mon Dec 04 10:27:47 2017 Disable testSearchBookmarks_Delete. Failing on KitKat tablet, see bug for details. Bug: 791485 TBR: twellington@chromium.org, mdjones@chromium.org Change-Id: I1fca7a125dbb58bf352d66545ca04e022a4ed564 Reviewed-on: https://chromium-review.googlesource.com/805135 Reviewed-by: Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#521302} [modify] https://crrev.com/48a0f05641e1aafea9c98ad26dfdd2a9b40b0917/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java
,
Dec 4 2017
mattcary@ - in the future, please include the stack trace for the failing test. Trybot logs expire after some time, so leaving a record of the failure is important.
It looks like this is the line that's failing: assertBookmarkItems("Wrong number of items before starting search.", 3, adapter, manager);
java.lang.AssertionError: expected:<3> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at org.chromium.chrome.browser.bookmarks.BookmarkTest.testSearchBookmarks_Delete(BookmarkTest.java:363)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116)
at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184)
at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:99)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/411454440403418aeeb2aaf552149ee18d046c02 commit 411454440403418aeeb2aaf552149ee18d046c02 Author: Theresa Wellington <twellington@google.com> Date: Mon Dec 04 23:45:40 2017 Reenable BookmarkTest#testSearchBookmarks_Delete This reverts commit 48a0f05641e1aafea9c98ad26dfdd2a9b40b0917 and re-enables the #testSearchBookmarks_Delete. In order for this test to pass on tablets, special handling of the search state while updating the native page's URL was added. BUG= 791485 ,789910 Change-Id: I43133858518754fa321e563a81982432eec98b93 Reviewed-on: https://chromium-review.googlesource.com/806932 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521527} [modify] https://crrev.com/411454440403418aeeb2aaf552149ee18d046c02/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java [modify] https://crrev.com/411454440403418aeeb2aaf552149ee18d046c02/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java
,
Dec 5 2017
I'm not seeing any failures since the re-enable, so marking this as "Fixed".
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46e6ce63142a239143743d00270a62fe7d816803 commit 46e6ce63142a239143743d00270a62fe7d816803 Author: Theresa Wellington <twellington@google.com> Date: Wed Dec 06 17:04:41 2017 Reenable BookmarkTest#testSearchBookmarks_Delete This reverts commit 48a0f05641e1aafea9c98ad26dfdd2a9b40b0917 and re-enables the #testSearchBookmarks_Delete. In order for this test to pass on tablets, special handling of the search state while updating the native page's URL was added. BUG= 791485 ,789910 Change-Id: I43133858518754fa321e563a81982432eec98b93 Reviewed-on: https://chromium-review.googlesource.com/806932 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521527}(cherry picked from commit 411454440403418aeeb2aaf552149ee18d046c02) Reviewed-on: https://chromium-review.googlesource.com/810987 Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#58} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/46e6ce63142a239143743d00270a62fe7d816803/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java [modify] https://crrev.com/46e6ce63142a239143743d00270a62fe7d816803/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java |
||||
►
Sign in to add a comment |
||||
Comment 1 by mattcary@chromium.org
, Dec 4 2017