Issue metadata
Sign in to add a comment
|
Grey focus highlight of ‘Cookies’ button disappears after few seconds.
Reported by
avsha...@etouch.net,
Dec 4 2017
|
||||||||||||||||||||||||||
Issue descriptionChrome version : 65.0.3284.0 (Official Build) 46c535d207b3648ddefdf3f9a588b69ac5ef31f2-refs/heads/master@{#521227} 64 bit OS : Mac(10.12.6) (10.13.2) Test URL : https://www.vudu.com/ What steps will reproduce the problem? 1. Launch chrome, navigate above test URL and wait until page loads completely. 2. Click on ‘Secure’ chip in omnibox and place mouse cursor on ‘Cookies’ button. 3. Keep cursor on ‘Cookies’ button for few seconds and observe the grey focus highlight. Actual Result : Grey focus highlight of ‘Cookies’ button disappears after few seconds. Expected Result : Focus highlight should stay on ‘Cookies’ button until user moves mouse pointer somewhere else. This is a non-regression issue seen from ‘M-64' series and the new ‘Cookies’ UI has been introduced in build #64.0.3274.0 Notes : 1. This issue is not observed for rest of the (‘Certificate’ & ‘Site settings’) buttons. 2. Above issue is not observed on Windows(7,8,10) & Linux(14.04 LTS) OS.
,
Dec 4 2017
Patti: could you take a look at this bug with the new page info buttons?
,
Dec 17 2017
,
Jan 4 2018
,
Jan 4 2018
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dcd371031b936bff673abc17f706c7d4476c99f commit 1dcd371031b936bff673abc17f706c7d4476c99f Author: Patti <patricialor@chromium.org> Date: Fri Jan 05 01:53:14 2018 Views: Preserve Button state on view hierarchy changes in descendants. HoverButtons created with the title & subtitle constructor lose focus when their title text is updated, as can be observed in the "Cookies (# in use)" button in the Page Info button on a website that uses a lot of cookies, such as https://nytimes.com. This is caused by views::Button resetting its ButtonState when the views hierarchy is updated, which in turn is caused by the StyledLabel title trashing all its children to reconstruct new children that contain the updated text. Fix by preventing the state reset if the the view hierarchy update does not involve the button itself (i.e., check if the button is the View being deleted before resetting the state). Bug: 791483 Change-Id: Id917dc8810e6330e76cd624e967adc55fed40e7d Reviewed-on: https://chromium-review.googlesource.com/848490 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#527186} [modify] https://crrev.com/1dcd371031b936bff673abc17f706c7d4476c99f/ui/views/controls/button/button.cc [modify] https://crrev.com/1dcd371031b936bff673abc17f706c7d4476c99f/ui/views/controls/button/button_unittest.cc
,
Jan 5 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Dec 4 2017