New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791467 link

Starred by 2 users
Status: Fixed
Owner:
mlippautz@chromium.org
Closed: Dec 2017
Cc:
falken@chromium.org
mlippautz@chromium.org
emir...@chromium.org
tzik@chromium.org
shimazu@chromium.org
hablich@chromium.org
█ magjed@chromium.org
jbroman@chromium.org
haraken@chromium.org
horo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 757440



Sign in to add a comment

2.5%-11.3% regression in speedometer at 519946:520107

Project Member Reported by hablich@chromium.org, Dec 4 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 4 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=791467

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d5a1e8864a8911be72fcb642ad27c9f0a77e3384f289e6ab916f03f6e5ed3e0f


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus7v2
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-win7-dual
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 11 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12872aa2040000
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Dec 11 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/16cd2852040000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Dec 11 2017

Cc: haraken@chromium.org mlippautz@chromium.org
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12872aa2040000

[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag
By mlippautz@chromium.org 路 Wed Nov 29 10:09:43 2017
chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Dec 11 2017

Cc: tzik@chromium.org falken@chromium.org emir...@chromium.org magjed@chromium.org horo@chromium.org shimazu@chromium.org
Owner: shimazu@chromium.org
馃搷 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16cd2852040000

[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag
By mlippautz@chromium.org 路 Wed Nov 29 10:09:43 2017
chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7

WebRTC: Migrate completely to new video codec factories API
By magjed@chromium.org 路 Wed Nov 29 10:21:53 2017
chromium @ c47b4d110a697afa6a6ee4d4748028312c65ec19

Remove WTF::internal::TimeWrapper
By tzik@chromium.org 路 Wed Nov 29 10:25:57 2017
chromium @ 91813e6590835f7ea1760d5752445e2be93d263d

Use std::set for keeping events in ServiceWorkerTimeoutTimer
By shimazu@chromium.org 路 Wed Nov 29 10:37:39 2017
chromium @ ad50bed3f641eaa1d28e88632a2f771765c3c7c0

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 7 by haraken@chromium.org, Dec 12 2017

Cc: jbroman@chromium.org
Owner: mlippautz@chromium.org
The culprit should be this one:

> [oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag
> By mlippautz@chromium.org 路 Wed Nov 29 10:09:43 2017
> chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7

Michael: Have all the regressions on Speedometer already fixed by your write-barrier optimization CL?

Comment 8 by mlippautz@chromium.org, Dec 14 2017

Blocking: 757440
Components: -Blink>JavaScript Blink>MemoryAllocator>GarbageCollection
Status: Fixed (was: Assigned)
The infrastructure for incremental marking was put behind compile time flags for now.
►

Sign in to add a comment