Change ResolutionChangePolicy from unscoped enum to enum class
Reported by
vm.ar...@samsung.com,
Dec 4 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce the problem: Currently media::ResolutionChangePolicy enum is unscoped enum. What is the expected behavior? Change unscoped enum to enum class What went wrong? Currently media::ResolutionChangePolicy enum is unscoped enum. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 62.0.3202.94 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Dec 4 2017
,
Dec 4 2017
,
Dec 4 2017
,
Dec 5 2017
patch under review https://chromium-review.googlesource.com/c/chromium/src/+/796250
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f90f205aa681878bd3fae952f445310dada9d50 commit 2f90f205aa681878bd3fae952f445310dada9d50 Author: mallikarjun82 <vm.arjun@samsung.com> Date: Tue Dec 05 11:21:17 2017 Change ResolutionChangePolicy from unscoped enum to enum class Bug: 791427 Change-Id: Ic421215d3e77e1d6381512d29e1457fba15135ca Reviewed-on: https://chromium-review.googlesource.com/796250 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#521663} [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/content/browser/media/capture/desktop_capture_device_unittest.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/content/browser/media/capture/web_contents_video_capture_device.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/content/browser/media/capture/web_contents_video_capture_device_unittest.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/content/renderer/media/media_stream_constraints_util_video_content.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/content/renderer/media/user_media_client_impl_unittest.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/media/capture/mojo/video_capture_types_struct_traits.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/media/capture/video_capture_types.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/media/capture/video_capture_types.h [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/media/capture/video_capture_types_unittest.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/services/video_capture/test/fake_device_descriptor_unittest.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/services/video_capture/test/fake_device_test.cc [modify] https://crrev.com/2f90f205aa681878bd3fae952f445310dada9d50/services/video_capture/test/mock_device_test.cc
,
Dec 5 2017
Patch is merged and request to resolve this bug
,
Dec 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
Marking this crbug as Fixed per comment 8. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cm.san...@samsung.com
, Dec 4 2017