New issue
Advanced search Search tips

Issue 791396 link

Starred by 2 users
Status: Fixed
Owner:
amistry@chromium.org
Closed: Nov 5
Cc:
hidehiko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocking:
issue 892001
issue 855197
issue 901689



Sign in to add a comment

Zip Archiver: revise to build with minizip library 2.2.x (ToT)

Project Member Reported by yamaguchi@chromium.org, Dec 4 2017 
Zip Archiver currently uses this revision.
e07e141475220196b55294c8172b274cc32d642d
Committed on Sep 24, 2017,

Update Zip Archiver to compile with latest minizip.

Comment 1 by yamaguchi@chromium.org, Dec 4 2017

Cc: hidehiko@chromium.org
Status: Untriaged (was: Available)
+hidehiko for Issue 780388.
If we were to make the zip library and rewrite the Zip Archiver extension for using it on M66, it might not be a good idea for us to rewrite the extension for minizip 2.2 on M65.

Comment 2 by yamaguchi@chromium.org, Dec 18 2017

Blocking: -782197
Labels: -M-65
Summary: Zip Archiver: revise to build with minizip library 2.2.x (ToT) (was: Zip Archiver: update with latest minizip library)
This is not a blocker of 782197 now.
We will make Zip Archiver build with the newer commit of the 1.2 branch of minizip to merge fixes for that issue, but not of the master (2.2.4) for now.

Comment 3 by sashab@chromium.org, Feb 22 2018

Labels: CrOS-FilesApp-Zip

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip

Comment 5 by weifangsun@chromium.org, Feb 28 2018

Labels: M-67
Status: Assigned (was: Untriaged)

Comment 6 by yamaguchi@chromium.org, Mar 6 2018

Owner: ----
Status: Available (was: Assigned)

Comment 7 by sashab@chromium.org, Apr 5 2018

Labels: -M-67

Comment 8 by amistry@chromium.org, Sep 24

Blocking: 855197
Owner: amistry@chromium.org
Status: Assigned (was: Available)

Comment 9 by amistry@chromium.org, Oct 4

Blocking: 892001

Comment 10 by amistry@chromium.org, Nov 4

Blocking: 901689
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e

commit 21ce588d37c189646cd80e46c7ea1ddd5ec0f98e
Author: Anand K. Mistry <amistry@chromium.org>
Date: Mon Nov 05 07:06:07 2018

Uprev minizip to 2.7.0

BUG= 791396 , 855197 

Change-Id: I4e4602e3748247c6bd0d1973c368467e1dc057fc
Reviewed-on: https://chromium-review.googlesource.com/c/1309387
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605270}
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/DEPS
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/BUILD.gn
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/compressor_archive_minizip.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/compressor_archive_minizip.h
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/compressor_archive_minizip_unittest.cc
[add] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/minizip_helpers.h
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip.h
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip_unittest.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_reader_javascript_stream.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/testing/libfuzzer/fuzzers/BUILD.gn
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/testing/libfuzzer/fuzzers/minizip_compress_fuzzer.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/testing/libfuzzer/fuzzers/minizip_uncompress_fuzzer.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/BUILD.gn
[add] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/DEPS
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/README.chromium
[add] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/mz_os_chrome.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/ui/file_manager/integration_tests/file_manager/zip_files.js

Comment 12 by amistry@chromium.org, Nov 5

Status: Fixed (was: Assigned)
►

Sign in to add a comment