New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791395 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-12-12
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

platform_AddPrinter.generic fails

Project Member Reported by xiaochu@chromium.org, Dec 4 2017

Issue description

Comment 1 by ka...@chromium.org, Dec 4 2017

Thanks Xiaochu for filing this bug. Failure started with R64-10106.0.9

CrOs diff - https://crosland.corp.google.com/log/10105.0.0..10106.0.0
CUPS change shown - https://chromium-review.googlesource.com/750045

Comment 2 by ka...@chromium.org, Dec 4 2017

Labels: -Pri-3 Pri-2
Owner: skau@chromium.org

Comment 3 by skau@chromium.org, Dec 5 2017

Labels: M-65
Status: Started (was: Untriaged)
I'll update the golden file.
 Issue 792480  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e8ea91cb528d08d1dcb0362bee8b0de9d7a9c76d

commit e8ea91cb528d08d1dcb0362bee8b0de9d7a9c76d
Author: Sean Kau <skau@chromium.org>
Date: Fri Dec 08 11:59:24 2017

autotest: Update golden file

platform_AddPrinter.generic needed an update to its golden
file to match the cups-filters update.

BUG= chromium:791395 
TEST=test_that ... platform_AddPrinter.generic passes

Change-Id: Ib64689c7bf793861f47e54d9f3a5c7d48d5d72eb
Reviewed-on: https://chromium-review.googlesource.com/812153
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/e8ea91cb528d08d1dcb0362bee8b0de9d7a9c76d/client/site_tests/platform_AddPrinter/golden_printing_request_generic.bin

Comment 6 by skau@chromium.org, Dec 9 2017

NextAction: 2017-12-12
Status: Fixed (was: Started)
Waiting on bvt-perbuild to run with the new file.  But it should be fixed now.
Status: Verified (was: Fixed)
thanks!
The NextAction date has arrived: 2017-12-12

Comment 10 by ka...@chromium.org, Dec 12 2017

Still failing boards - elm, kevin, and veyron family.
The failure reason is different though. Now /bin/cat crashes during dynamic library loading. It seems to be launched by cups-filters. There's *FoomaticRIPCommandLine: "cat%A%B%Z" in PPD and this in log:

2017-12-08T15:37:02.710412+01:00 DEBUG cupsd[4619]: [Job 1] Starting process \"kid3\" (generation 1)
2017-12-08T15:37:02.710421+01:00 DEBUG cupsd[4619]: [Job 1] Starting process \"kid4\" (generation 2)
2017-12-08T15:37:02.710431+01:00 DEBUG cupsd[4619]: [Job 1] Starting process \"renderer\" (generation 2)
2017-12-08T15:37:02.710440+01:00 DEBUG cupsd[4619]: [Job 1] JCL: \033%-12345X@PJL
2017-12-08T15:37:02.710450+01:00 DEBUG cupsd[4619]: [Job 1] <job data> 
2017-12-08T15:37:02.710461+01:00 DEBUG cupsd[4619]: [Job 1] hrDeviceDesc=\"Unknown\"
2017-12-08T15:37:02.710470+01:00 DEBUG cupsd[4619]: [Job 1] renderer received signal 31
2017-12-08T15:37:02.710480+01:00 DEBUG cupsd[4619]: [Job 1] Process is dying with \"Encountered error Broken pipe during fwrite\", exit stat 1
2017-12-08T15:37:02.710490+01:00 DEBUG cupsd[4619]: [Job 1] Cleaning up...
2017-12-08T15:37:02.710500+01:00 DEBUG cupsd[4619]: [Job 1] Killing pdf-to-ps
2017-12-08T15:37:02.710510+01:00 DEBUG cupsd[4619]: [Job 1] prtGeneralCurrentLocalization type is 0, expected 2!
2017-12-08T15:37:02.710520+01:00 DEBUG cupsd[4619]: [Job 1] backendWaitLoop(snmp_fd=6, addr=0xfd6eac4, side_cb=0xf17f141)
2017-12-08T15:37:02.712237+01:00 DEBUG cupsd[4619]: [Job 1] Killing kid3
2017-12-08T15:37:02.712281+01:00 DEBUG cupsd[4619]: [Job 1] End of messages
2017-12-08T15:37:02.712304+01:00 DEBUG cupsd[4619]: [Job 1] printer-state=3(idle)
2017-12-08T15:37:02.712321+01:00 DEBUG cupsd[4619]: [Job 1] printer-state-message="Filter failed"
2017-12-08T15:37:02.712334+01:00 DEBUG cupsd[4619]: [Job 1] printer-state-reasons=none

Here's the trace I get on veyron_minnie (not dissimilar to ones in the linked dashboard):
Operating system: Linux
                  0.0.0 Linux 3.14.0 #1 SMP PREEMPT Mon Dec 11 03:25:31 PST 2017 armv7l
CPU: arm
     ARMv1 ARM part(0x4100c0d0) features: swp,half,thumb,fastmult,vfpv2,edsp,thumbee,neon,vfpv3,tls,vfpv4,idiva,idivt
     4 CPUs

GPU: UNKNOWN

Crash reason:  SIGSYS
Crash address: 0x0
Process uptime: not available

Thread 0 (crashed)
 0  libc-2.23.so!__statfs + 0x7
     r0 = 0xaee21b0c    r1 = 0xbed16a48    r2 = 0xaee258d4    r3 = 0x0001aaa8
     r4 = 0xaee21b0c    r5 = 0xbed16a48    r6 = 0x00000003    r7 = 0x00000063
     r8 = 0xbed16b04    r9 = 0x00000000   r10 = 0xaee24aa8   r12 = 0xaee24e28
     fp = 0x00000000    sp = 0xbed169f4    lr = 0xaee1524d    pc = 0xaed6b318
    Found by: given as instruction pointer in context
 1  libselinux.so.1!init_lib [init.c : 38 + 0x7]
     r4 = 0xaee21b0c    r5 = 0xbed16a48    r6 = 0x00000003    r7 = 0xbed16aa8
     r8 = 0xbed16b04    r9 = 0x00000000   r10 = 0xaee24aa8    fp = 0x00000000
     sp = 0xbed169f8    pc = 0xaee1524d
    Found by: call frame info
 2  ld-2.23.so!call_init [dl-init.c : 72 + 0x5]
     r4 = 0x00000002    r5 = 0xaee15209    r6 = 0x00000003    r7 = 0xbed16af4
     r8 = 0xbed16b04    r9 = 0x00000002   r10 = 0xaee24aa8    fp = 0x00000000
     sp = 0xbed16ab0    pc = 0xaee32aa5
    Found by: call frame info
 3  ld-2.23.so!_dl_init [dl-init.c : 30 + 0x11]
     r4 = 0x00000000    r5 = 0x00000001    r6 = 0x00000003    r7 = 0xbed16af4
     r8 = 0xbed16b04    r9 = 0xaee4f908   r10 = 0x00000000    fp = 0x00000000
     sp = 0xbed16ad0    pc = 0xaee32b83
    Found by: call frame info
 4  ld-2.23.so!_dl_start_user + 0x22
     r4 = 0x00000000    r5 = 0x00000000    r6 = 0x07bb87b1    r7 = 0x00000000
     r8 = 0x00000000    r9 = 0x00000000   r10 = 0xaee4efb0    fp = 0x00000000
     sp = 0xbed16af0    pc = 0xaee27ab3
    Found by: call frame info

Loaded modules:
0x07bb1000 - 0x07c83fff  coreutils  ???  (main)
0xaec66000 - 0xaec67fff  libdl-2.23.so  ???
0xaec79000 - 0xaecdcfff  libpcre.so.1.2.8  ???
0xaecdf000 - 0xaedb5fff  libc-2.23.so  ???  (WARNING: Corrupt symbols, libc-2.23.so, 8AF5017EA5591D2A20559931B0444B6D0)
0xaedcc000 - 0xaeddbfff  libpthread-2.23.so  ???
0xaedef000 - 0xaedf3fff  librt-2.23.so  ???
0xaee05000 - 0xaee07fff  libattr.so.1.1.0  ???
0xaee0a000 - 0xaee23fff  libselinux.so.1  ???
0xaee27000 - 0xaee3efff  ld-2.23.so  ???

I skipped the most interesting line in the log:

2017-12-12T15:16:14.062326+01:00 DEBUG cupsd[6544]: [Job 1] Starting renderer with command: \"cat\"
2017-12-12T15:16:14.062343+01:00 DEBUG cupsd[6544]: [Job 1] Starting process \"kid3\" (generation 1)
...
FWIW, crrev.com/c/824607 fixes this for me.
I still have no idea why this stopped working though.

Comment 14 by skau@chromium.org, Dec 13 2017

syscalls can change when libc gets updated.
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1f9c08d070f55db9ae21c626bfdd459223606ee8

commit 1f9c08d070f55db9ae21c626bfdd459223606ee8
Author: Vladislav Kuzkokov <vkuzkokov@google.com>
Date: Tue Dec 19 04:33:05 2017

cups: Add statfs to the list of syscalls allowed to cupsd

statfs is used in libselinux initialization. Disallowing it prevents cups
from launching anything linked with libselinux including core utilities.

BUG= chromium:791395 
TEST=test_that --board=$BOARD $DUT_IP platform_AddPrinter.generic

Change-Id: I6e6865e8c501621cbd5455e8f5861b4a187596de
Reviewed-on: https://chromium-review.googlesource.com/824607
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/1f9c08d070f55db9ae21c626bfdd459223606ee8/net-print/cups/cups-2.1.4-r32.ebuild
[modify] https://crrev.com/1f9c08d070f55db9ae21c626bfdd459223606ee8/net-print/cups/files/cupsd-seccomp-arm.policy

Comment 16 by ka...@chromium.org, Dec 27 2017

Labels: Merge-Request-64
Status: Fixed (was: Assigned)
With the exception of few occasional ABORTs, the CUPS test is now passing consistently since 	10229.0.0
https://screenshot.googleplex.com/NzyACt45N1U

Requesting merge to M-64
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 27 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi, can I get a bit more context?  Is this addressing a bug or new feature development?   Introduced in M64 or ongoing beforehand?
It is a bug that happens sporadically (especially in recent days). It is discovered by autotest and user report.

Comment 20 by ka...@chromium.org, Dec 28 2017

Also, the fixed test is planned to be part of bvt-cq, and needs to stabilize on all active milestones.

Comment 21 by skau@google.com, Dec 31 2017

#18 this fix is for a bug introduced in M64 where we cannot print on ARM platforms.
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.

Status: Verified (was: Fixed)
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 5 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/be508fb17a833d0e787f64b3cc12e4ed7259ab02

commit be508fb17a833d0e787f64b3cc12e4ed7259ab02
Author: Vladislav Kuzkokov <vkuzkokov@google.com>
Date: Fri Jan 05 00:02:22 2018

cups: Add statfs to the list of syscalls allowed to cupsd

statfs is used in libselinux initialization. Disallowing it prevents cups
from launching anything linked with libselinux including core utilities.

BUG= chromium:791395 
TEST=test_that --board=$BOARD $DUT_IP platform_AddPrinter.generic

Change-Id: I6e6865e8c501621cbd5455e8f5861b4a187596de
Reviewed-on: https://chromium-review.googlesource.com/824607
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 1f9c08d070f55db9ae21c626bfdd459223606ee8)
Reviewed-on: https://chromium-review.googlesource.com/849812
Trybot-Ready: Sean Kau <skau@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>

[rename] https://crrev.com/be508fb17a833d0e787f64b3cc12e4ed7259ab02/net-print/cups/cups-2.1.4-r32.ebuild
[modify] https://crrev.com/be508fb17a833d0e787f64b3cc12e4ed7259ab02/net-print/cups/files/cupsd-seccomp-arm.policy

Project Member

Comment 25 by sheriffbot@chromium.org, Feb 12 2018

Cc: kbleicher@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 26 by sheriffbot@chromium.org, Feb 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 27 by skau@chromium.org, Feb 16 2018

Labels: -Merge-Approved-64

Sign in to add a comment