New issue
Advanced search Search tips

Issue 791393 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

fast/.../cssURLQuotes.html in webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 4 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of calamity@chromium.org

fast/.../cssURLQuotes.html in webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Builders failed on: 
- WebKit Android (Nexus4): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29


 
Owner: calamity@chromium.org
Test expectations diff:


--- /b/rr/tmpByfPXN/w/layout-test-results/fast/inspector-support/cssURLQuotes-expected.txt
+++ /b/rr/tmpByfPXN/w/layout-test-results/fast/inspector-support/cssURLQuotes-actual.txt
@@ -1,6 +1,6 @@
+CONSOLE ERROR: line 6: Not allowed to load local resource: should(Quote)
+CONSOLE ERROR: line 6: Not allowed to load local resource: quoted
 CONSOLE ERROR: line 6: Not allowed to load local resource: unquoted
-CONSOLE ERROR: line 6: Not allowed to load local resource: quoted
-CONSOLE ERROR: line 6: Not allowed to load local resource: should(Quote)
 ALERT: url("file:///unquoted") (URL should be quoted)
 ALERT: url("file:///quoted") (URL should be quoted)
 ALERT: url("file:///should(Quote)") (URL should be quoted)


Looks like the log order reversed for some reason....? Going to assume an update or something changed the log order and update the expectations.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827c12f9f2124a63c057daf7c4140a9818d9cf82

commit 827c12f9f2124a63c057daf7c4140a9818d9cf82
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Dec 04 07:21:31 2017

Update test expectations for cssURLQuotes.

The console logs are going the other way now.

Bug:  791393 
Change-Id: I2769852d449ce8edc3ead9b2127a7e63b55786ea
Reviewed-on: https://chromium-review.googlesource.com/804711
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521282}
[modify] https://crrev.com/827c12f9f2124a63c057daf7c4140a9818d9cf82/third_party/WebKit/LayoutTests/platform/android/fast/inspector-support/cssURLQuotes-expected.txt

Status: Fixed (was: Available)

Sign in to add a comment