New issue
Advanced search Search tips

Issue 791389 link

Starred by 2 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword Flaking on Mac

Project Member Reported by calamity@chromium.org, Dec 4 2017

Issue description

Components: UI>Browser>Passwords

Comment 4 by vabr@chromium.org, Dec 4 2017

Cc: -mkwst@chromium.org -vabr@chromium.org dvadym@chromium.org kolos@chromium.org
Components: -UI>Browser>Passwords UI>Browser>Passwords>Generation
Labels: Hotlist-TechnicalDebt Hotlist-Polish
Changing component and Cc to generation sub-team.

Comment 5 by kolos@chromium.org, Dec 4 2017

I re-enabled it 2 days (https://chromium-review.googlesource.com/c/chromium/src/+/797035). Fix doesn't work  :( I am afraid the test should be disabled on all platforms. 

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ce204cd470fc3258528404098577a0a42b3d70

commit a2ce204cd470fc3258528404098577a0a42b3d70
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 13 09:26:55 2018

Reenable PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword.

Bug: 791389
Change-Id: Iea3b6e0f2ec7899e099bd9d7e23017ac4c83e459
Reviewed-on: https://chromium-review.googlesource.com/1170908
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582537}
[modify] https://crrev.com/a2ce204cd470fc3258528404098577a0a42b3d70/chrome/browser/password_manager/password_generation_interactive_uitest.cc

Owner: vasi...@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11cd89f67aa9bdfb2149f98732e7f72e4bb6746d

commit 11cd89f67aa9bdfb2149f98732e7f72e4bb6746d
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Aug 15 11:35:04 2018

Revert "Reenable PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword."

This reverts commit a2ce204cd470fc3258528404098577a0a42b3d70.

Reason for revert: Sorry, still flaky; see  crbug.com/874380 

Original change's description:
> Reenable PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword.
> 
> Bug: 791389
> Change-Id: Iea3b6e0f2ec7899e099bd9d7e23017ac4c83e459
> Reviewed-on: https://chromium-review.googlesource.com/1170908
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582537}

TBR=vasilii@chromium.org,dvadym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 791389,  874380 
Change-Id: I1551a9ae472ef3e6645622951bdfcd87f2fb74c7
Reviewed-on: https://chromium-review.googlesource.com/1175761
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583215}
[modify] https://crrev.com/11cd89f67aa9bdfb2149f98732e7f72e4bb6746d/chrome/browser/password_manager/password_generation_interactive_uitest.cc

Status: Available (was: Fixed)
linux_chromium_asan_rel_ng and win7_chromium_rel_ng.

The test timed out. Probably the keystrokes never reached the input field.

Sign in to add a comment