Consider moving the implementation of AsyncOperation to .cc file |
|||
Issue descriptionThis comes from CL review[1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/787790/6/services/shape_detection/detection_utils_win.h#41
,
Mar 12 2018
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ccb03692c90184bdde10e4f7e69240a80a41080 commit 6ccb03692c90184bdde10e4f7e69240a80a41080 Author: junweifu <junwei.fu@intel.com> Date: Fri Mar 30 02:37:39 2018 ShapeDetection: Move the implementation of AsyncOperation to the .cc file It's better to put the class definition in a header file and the implementation in a C++ source file. Then, the source file is made part of the project, meaning it is compiled separately. BUG= 791371 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ic58d0c714b405ced8974aca22c3b20f7b479682f Reviewed-on: https://chromium-review.googlesource.com/982751 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#547078} [modify] https://crrev.com/6ccb03692c90184bdde10e4f7e69240a80a41080/services/shape_detection/detection_utils_win.cc [modify] https://crrev.com/6ccb03692c90184bdde10e4f7e69240a80a41080/services/shape_detection/detection_utils_win.h [modify] https://crrev.com/6ccb03692c90184bdde10e4f7e69240a80a41080/services/shape_detection/face_detection_impl_win.cc
,
Apr 3 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mcasas@chromium.org
, Mar 10 2018