New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Consider moving the implementation of AsyncOperation to .cc file

Project Member Reported by junwei...@intel.com, Dec 4 2017

Issue description

Comment 1 by mcasas@chromium.org, Mar 10 2018

Status: Assigned (was: Untriaged)

Comment 2 by junwei...@intel.com, Mar 12 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ccb03692c90184bdde10e4f7e69240a80a41080

commit 6ccb03692c90184bdde10e4f7e69240a80a41080
Author: junweifu <junwei.fu@intel.com>
Date: Fri Mar 30 02:37:39 2018

ShapeDetection: Move the implementation of AsyncOperation to the .cc file

It's better to put the class definition in a header file and the implementation
in a C++ source file. Then, the source file is made part of the project, meaning
it is compiled separately.

BUG= 791371 

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ic58d0c714b405ced8974aca22c3b20f7b479682f
Reviewed-on: https://chromium-review.googlesource.com/982751
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#547078}
[modify] https://crrev.com/6ccb03692c90184bdde10e4f7e69240a80a41080/services/shape_detection/detection_utils_win.cc
[modify] https://crrev.com/6ccb03692c90184bdde10e4f7e69240a80a41080/services/shape_detection/detection_utils_win.h
[modify] https://crrev.com/6ccb03692c90184bdde10e4f7e69240a80a41080/services/shape_detection/face_detection_impl_win.cc

Status: Fixed (was: Started)

Sign in to add a comment