New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791315 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::HTMLCanvasElement::UpdateMemoryUsage

Project Member Reported by ClusterFuzz, Dec 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4786894780235776

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::HTMLCanvasElement::UpdateMemoryUsage
  blink::HTMLCanvasElement::SetSurfaceSize
  blink::HTMLCanvasElement::Reset
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=518972:518993

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4786894780235776

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 3 2017

Components: Blink>HTML
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 3 2017

Labels: Test-Predator-Auto-Owner
Owner: xlai@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/6c4cca504533b317b3b61e7417e4582a45f58881 (Tear down ImageBuffer's reference to HTMLCanvasElement via ImageBufferClient).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by xlai@chromium.org, Dec 4 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52b7aa0dfacabfe1354a47414cb55ece1456758b

commit 52b7aa0dfacabfe1354a47414cb55ece1456758b
Author: xlai <xlai@chromium.org>
Date: Tue Dec 05 17:25:31 2017

Fix integer overflow

Bug:  791315 
Change-Id: I351a626d3d68657814e8c0fa3ed1d6f1eb153e80
Reviewed-on: https://chromium-review.googlesource.com/806296
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521730}
[modify] https://crrev.com/52b7aa0dfacabfe1354a47414cb55ece1456758b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Project Member

Comment 5 by ClusterFuzz, Dec 5 2017

ClusterFuzz has detected this issue as fixed in range 521729:521770.

Detailed report: https://clusterfuzz.com/testcase?key=4786894780235776

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::HTMLCanvasElement::UpdateMemoryUsage
  blink::HTMLCanvasElement::SetSurfaceSize
  blink::HTMLCanvasElement::Reset
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=518972:518993
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=521729:521770

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4786894780235776

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Dec 5 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4786894780235776 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment