New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 791254 link

Starred by 1 user
Status: Fixed
Owner:
js...@chromium.org
Closed: Dec 2017
Cc:
█ mgiuca@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Have a separate gperf file for unitesting of IDNToUnicode

Project Member Reported by js...@chromium.org, Dec 2 2017 
Not to forget:

Instead of adding a couple of test domains to the gperf (converted to Dafsa and actually used at runtime), make a separate a gperf file (that will be converted Dafsa). 

See net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
and net/base/registry_controlled_domains/registry_controlled_domain.cc .

Comment 1 by js...@chromium.org, Dec 2 2017

Owner: js...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by js...@chromium.org, Dec 4 2017

Components: UI>Security>UrlFormatting
Status: Started (was: Assigned)
A CL is up for review at 
https://chromium-review.googlesource.com/c/chromium/src/+/804693
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79da8bba7cc423ff59b87631ee1d37611e245d8f

commit 79da8bba7cc423ff59b87631ee1d37611e245d8f
Author: Jungshik Shin <jshin@chromium.org>
Date: Sun Dec 10 11:47:05 2017

Put test domains for IDN display in a separate file

The run-time top domain list will not have test domains any more.

Bug:  791254 
Test: components_unittests --gtest_filter=*IDNToUni*
Change-Id: I4636438301954c97a6479726e5af70d3a0b00ac8
Reviewed-on: https://chromium-review.googlesource.com/804693
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523023}
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/idn_spoof_checker.cc
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/idn_spoof_checker.h
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/BUILD.gn
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/README
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/alexa_domains.list
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/alexa_skeletons.gperf
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/make_alexa_top_list.py
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/make_top_domain_gperf.cc
[add] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/test_domains.list
[add] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/top_domains/test_skeletons.gperf
[modify] https://crrev.com/79da8bba7cc423ff59b87631ee1d37611e245d8f/components/url_formatter/url_formatter_unittest.cc

Comment 4 by js...@chromium.org, Dec 12 2017

Status: Fixed (was: Started)
►

Sign in to add a comment